Color Change Problem 2

Continuing the discussion from [Color Changer Gui not affecting Character]
PLEASE READ THE PREVIOUS COMMENTS BEFORE COMMENTING HERE

(Color Changer Gui not affecting Character):

**[quote=“starbest97, post:1, topic:1925704, full:true”]
My goal for this system is to successfully change the color of the avatar depending on what you pick. Currently the color changings being skin color and favorite color.

However, the only problem is that it doesn’t even add the changes to the character

For example, The Favorite color i chose is purple while the skin color I chose is this tan like color.
Color problem 1

But when i see it in game, This happens…
Color problem 2.0

This actually isn’t the original planned model, it is the image below. I don’t know why the model above had the arms colored
Color problem 3

I don’t think showing the entire system is necessary for this problem, but i should in case.

Ill start with the explorer first

This is what is in my starter character with it’s own FavColor and SkinColor Color3 Value

The image below shows one part the things each colorable part has, The main things to look at being FavColor and SkinColor, These values are actually bool values,

Color problem 5

This is the script that it is supposed to use the color 3 values for coloring every part.


local Svalue = script.Parent:WaitForChild("SkinColor")
local Fvalue = script.Parent:WaitForChild("FavColor")
local HumanParts = script.Parent:GetChildren()



for i = 1, #HumanParts do
	if HumanParts[i]:IsA("MeshPart") then
		if HumanParts[i].SkinColor.Value == true then
			HumanParts[i].Color = Color3.fromRGB(Svalue.Value)
		elseif HumanParts[i].FavColor.Value == true then
			HumanParts[i].Color = Color3.fromRGB(Fvalue.Value)
		else
		end
	end
end

Svalue.Changed:Connect(function()
	for i = 1, #HumanParts do
		if HumanParts[i]:IsA("MeshPart") then
			if HumanParts[i].SkinColor.Value == true then
				HumanParts[i].Color = Color3.fromRGB(Svalue.Value)
			elseif HumanParts[i].FavColor.Value == true then
				HumanParts[i].Color = Color3.fromRGB(Fvalue.Value)
			else
			end
		end
	end
end)
Fvalue.Changed:Connect(function()
	for i = 1, #HumanParts do
		if HumanParts[i]:IsA("MeshPart") then
			if HumanParts[i].SkinColor.Value == true then
				HumanParts[i].Color = Color3.fromRGB(Svalue.Value)
			elseif HumanParts[i].FavColor.Value == true then
				HumanParts[i].Color = Color3.fromRGB(Fvalue.Value)
			else
			end
		end
	end
end)

Mostly everything works, The values even have the colors i chose earlier, the coloring is the only thing wrong with it, I’m also sorry in advance if some parts of code are unnecessary or hard to read.
[/quote]

Color3.fromRGB(Svalue.Value)
Color3.fromRGB(Fvalue.Value)

Aren’t ‘Svalue’ and ‘Fvalue’ already Color3Value objects? If so you don’t need to pass their values to the Color3.fromRGB constructor function.

Ive tried to rename the variables and ive also tried removing the. Value of each variable and it dosent seem to work still.

If Svalue.Value/Fvalue.Value are Color3 values then don’t need to pass them to the Color3.fromRGB constructor function.

1 Like

Ok i get what you mean, I wasnt sure what it meant earlier and im sorry for the confusion.

It works now, Thank You very much, and sorry for the confusion earlier