CoreScript mouse panning code hardcodes screen resolution/aspect ratio

Bug Reports Engine Bugs
#1

https://github.com/ROBLOX/Core-Scripts/blob/master/PlayerScripts/PlayerScriptsPlace/StarterPlayer/StarterPlayerScripts/CameraScript/RootCamera.rbxmx#L244

Used like this:

https://github.com/ROBLOX/Core-Scripts/blob/master/PlayerScripts/PlayerScriptsPlace/StarterPlayer/StarterPlayerScripts/CameraScript/RootCamera.rbxmx#L684

#2

Why are either of these based on screen aspect ratio?

1 Like
#3

I just read this script a couple days ago in PlayerScripts.CameraScript.RootCamera from Play Solo. I thought it was strange that there were hardcoded values there. I think MouseTranslationToAngle and ScreenTranslationToAngle should just be the same function.

also, how are these angles?

#4

Looks fine to me. Camera panning speed should be consistent across different monitor aspect ratios.

#5

ConvexHero, always asking the bigger questions. :happy1:

I’ve noticed that the camera control script defines a TOUCH_SENSITIVITY vec2 that is more sensitive in X than in Y (clearly by design), which is probably why its hard to tell that the angle ultimately calculated from the thetas returned from this function are (sometimes) wrong.