Could I make a change script more efficient?

Help and Feedback Scripting Support
1 
local gold = game.Workspace.Userdata[player.Name.."_Data"].Inventory.Gold

gold.Changed:Connect(function() 
	script.Parent.Text = gold.Value
end)

So this the current way that I do the .Change when the gold is updated but if there was multiple values being update like gold, maybe diamonds or levels would I just use this script on everything that needs changing when a value is changed or could this be managed in one script maybe?

2

It really depends on how you handle player datas. Some developers used tables to save and change data when the player is in the server. Do note that if there is like 3 InstanceValue in a 30 player, that may cause some strain in the server (no evidence, but a guess)

3

Well right now, they a stored in the workspace inside a the players name Data: image

They are also handled in a script which using datastore2, and the armour, weapons and potions are stored in a table using JSONEncode.

4

That would impact performance when there are a lot of players. I would recommend using tables. As well, you do not need to JSONEncode tables while saving to DataStores.

5

Would a ModuleScript work? You can define a function in one:
modulescript. in ServerStorage
local module = {}
local example = function(callingScript, value)
value.Changed:Connect(function()
callingScript.Parent.Text = value.Value
end)
end
return module
In a normal script:
local modulescript = require(game.ServerStorage.ModuleScript)
modulescript.example(script, gold)

You can change some stuff if you want

6

In theory this should work but doesn’t for some reason, I get an error saying infinite yield.