So basically im trying to make a part damage a enemy when touched (not a player), and when I test them on them it doesn’t do damage. (Theres no errors either)
Script:
The hitbox is collision-off and anchored by the way.
maybe you disabled CanTouch or CanQuery? (in hitbox properties)
By doing return in line 17 you prevent the code below to execute
No they are on and if I did then the print wouldn’t work but it does for some reason
So should i do if not player then instead?
If you want to prevent the code below to execute when the player is nil then yes.
Like this:
if not player then return end
local player = game.Players:GetPlayerFromCharacter(Hit.Parent)
if player then return end --> ? if player was found then return?
Is it supposed to be like that? If the player was found then you are basically stopping the whole code
The point of the code is to make sure that if the hitbox hits a player then it won’t do damage, It is only going to be doing damage to npcs
Yes that is true, but essentially doing
if player then return end
The rest of the script won’t run because you’re telling the script to stop executing that code block if a part’s that is a descendant of a player is found, if you’re not looking to damage any players why bother even checking if the part that is touched is a descendant of a player? Simply remove that line and only check if that part’s descendant is the enemy’s .
I think you’re really overcomplicating this, a lot of unnecessary iterations for what!
if game:GetService("Players"):GetPlayerFromCharacter(Hit.Parent) == nil then
local EnemyHumanoid = Hit.Parent:FindFirstChild("Humanoid")
if EnemyHumanoid and EnemyHumanoid.Health > 0 then
EnemyHumanoid:TakeDamage(20)
end
end
It’s important that you make sure the enemy still has an existing humanoid incase it dies in between of damaging / killing it or else the script will not run after for the rest.
If that’s the case then, the line “if player then return end” shouldn’t cause any problems. The problem here is your canHIt variable.
You can check if the hit is a humanoid but not a player like this:
if hit.Parent:FindFirstChild("Humanoid") and not game:GetService("Players"):GetPlayerFromCharacter(hit.Parent) then
--code
end
Wrong,
if player then return end
Makes the script return nil / stop running since the code after this statement is still under the same code block.
I don’t get how it is the problem though, since in my other weapon I use the same script and it works perfectly fine, the only difference being the script isn’t in the damage part, its working from a folder
@abclike123ye Did you forget to change canHit back to true? Cuz it seems like you didn’t state there anywhere in the code thus potentially stopping your whole code with “if canHit == false”.
Plus yeah if you want to check whether a humanoid was a player or not you can do Squally’s way
No dude, it will only return if a player is FOUND from the character. If not then it’ll run normally
Well besides the statement, do you have a TouchEnded event to re-enable CanHit?
Yeah you’re right I forgot this was a Touched event, I thought it was a loop oops.
Yeah it only hits once, but even so I don’t get how the script just stops at the print, even if i delete the player check