Data Store Leaderboard

Help and Feedback Scripting Support
#1

Okay so, i’m going to keep this simple. I have my leaderboard script and my global leaderboard script. Here is the issue: The leaderboard saves fine, but the global leaderboard is not changing when a players leaderstat goes down. Any way i can fix this?

Here is the global leaderboard script:
local sg = script.Parent --Surface GUI
local sample = script:WaitForChild(“Sample”) --Our Sample frame
local sf = sg:WaitForChild(“ScrollingFrame”) --The scrolling frame
local ui = sf:WaitForChild(“UI”) --The UI list layout

local dataStoreService = game:GetService(“DataStoreService”)
–The data store service
local dataStore = dataStoreService:GetOrderedDataStore(“Leaderboard”)
–Get the data store with key “Leaderboard”
wait(10)
while true do
for i,plr in pairs(game.Players:GetChildren()) do–Loop through players
if plr.UserId>0 then–Prevent errors
local w = plr.leaderstats.Minutes.Value–Get value
if w then
pcall(function()
–Wrap in a pcall so if Roblox is down, it won’t error and break.
dataStore:UpdateAsync(plr.UserId,function(oldVal)
–Set new value
return tonumber(w)
end)
end)
end
end
end
local smallestFirst = false–false = 2 before 1, true = 1 before 2
local numberToShow = 100–Any number between 1-100, how many will be shown
local minValue = 1–Any numbers lower than this will be excluded
local maxValue = 10e30–(10^30), any numbers higher than this will be excluded
local pages = dataStore:GetSortedAsync(smallestFirst, numberToShow, minValue, maxValue)
–Get data
local top = pages:GetCurrentPage()–Get the first page
local data = {}–Store new data
for a,b in ipairs(top) do–Loop through data
local userid = b.key–User id
local points = b.value–Points
local username = “[Failed To Load]”–If it fails, we let them know
local s,e = pcall(function()
username = game.Players:GetNameFromUserIdAsync(userid)–Get username
end)
if not s then–Something went wrong
warn("Error getting name for “…userid…”. Error: "…e)
end
local image = game.Players:GetUserThumbnailAsync(userid, Enum.ThumbnailType.HeadShot, Enum.ThumbnailSize.Size150x150)
–Make a image of them
table.insert(data,{username,points,image})–Put new data in new table
end
ui.Parent = script
sf:ClearAllChildren()–Remove old frames
ui.Parent = sf
for number,d in pairs(data) do–Loop through our new data
local name = d[1]
local val = d[2]
local image = d[3]
local color = Color3.new(255,255,255)–Default color
if number == 1 then
color = Color3.new(1,1,0)–1st place color
elseif number == 2 then
color = Color3.new(0.9,0.9,0.9)–2nd place color
elseif number == 3 then
color = Color3.fromRGB(166, 112, 0)–3rd place color
end
local new = sample:Clone()–Make a clone of the sample frame
new.Name = name–Set name for better recognition and debugging
new.LayoutOrder = number–UIListLayout uses this to sort in the correct order
new.Image.Image = image–Set the image
new.Image.Place.Text = number–Set the place
new.Image.Place.TextColor3 = color–Set the place color (Gold = 1st)
new.PName.Text = name–Set the username
new.Value.Text = val–Set the amount of points
new.Value.TextColor3 = color–Set the place color (Gold = 1st)
new.PName.TextColor3 = color–Set the place color (Gold = 1st)
new.Parent = sf–Parent to scrolling frame
end
wait()
sf.CanvasSize = UDim2.new(0,0,0,ui.AbsoluteContentSize.Y)
–Give enough room for the frames to sit in
wait(60)
end

Here is the leaderboard script: (it’s a time played leaderboard)

local dss = game:GetService(“DataStoreService”)
local timePlayedDS = dss:GetOrderedDataStore(“timePlayedDS”)

game.Players.PlayerAdded:Connect(function(player)
local leaderstats = Instance.new(“Folder”, player)
leaderstats.Name = “leaderstats”
local timePlayed = Instance.new(“IntValue”, leaderstats)
timePlayed.Name = “Minutes”

local key = player.UserId

local data
local s, e = pcall(function()
	data = timePlayedDS:GetAsync(key)
end)
if s then
	timePlayed.Value = data
else
	timePlayed.Value = 0
end


while true do
	wait(60)
	timePlayed.Value = timePlayed.Value + 1
end

timePlayed.Value.Changed:Connect(function()
	local s, e = pcall(function()
	timePlayedDS:SetAsync(key, player.leaderstats["Minutes"].Value)
end)
if s then
	print("Success")
else
	warn(e)
end
end)

end)

Thanks for reading.

#2

I’m not familiar with global leaderboards or leaderboards in general but could you add a loop that constantly keeps the global leaderboard updated?

#3

Please codeblock your code so we can assist you better.

On a complete side note, saving / updating based off of the actual “leaderstats” value is a bad pratice, and one that will lead to many problems down the line.

Your frontend shouldn’t have anything to do with your backend.

1 Like