Data store not saving

ItzBloxyDev · May 17, 2022, 10:30am

local DataStoreService = game:GetService("DataStoreService")
local SaveData = DataStoreService:GetDataStore("SaveData")
local ToolFolder = game:GetService("ServerStorage"):FindFirstChild("SavedTools")
local Players = game:GetService("Players")

Players.PlayerAdded:Connect(function(Player)
	local ToolData = SaveData:GetAsync(Player.UserId)
	
	local Backpack = Player:WaitForChild("Backpack")
	local StarterGear = Player:WaitForChild("StarterGear")
	
	if ToolData then
		for i, v in pairs(ToolData) do
			if ToolFolder:FindFirstChild(v) and not Backpack:FindFirstChild(v) and not StarterGear:FindFirstChild(v) then
				ToolFolder[v]:Clone().Parent = Backpack
				ToolFolder[v]:Clone().Parent = StarterGear
			end
		end
	end
	
	Player.CharacterRemoving:Connect(function(Character)
		Character:WaitForChild("Humanoid"):UnequipTools()
	end)
end)

Players.PlayerRemoving:Connect(function(Player)
	local ToolTable
	
	for i,v in pairs(Player.Backpack:GetChildren()) do
        if not ToolTable then ToolTable = {} end
		table.insert(ToolTable, v.Name)
	end
	if ToolTable then
		SaveData:SetAsync(Player.UserId, ToolTable)
	end
end)

game:BindToClose(function()
   task.wait(2)
end)

EruptingStudiosGD · May 17, 2022, 10:31am

Ok… that’s odd I didn’t buy anything but I remembered a item I bought last time even though last time it didn’t save lol.

ItzBloxyDev · May 17, 2022, 10:32am

what do you mean? char limitation

EruptingStudiosGD · May 17, 2022, 10:33am

Ok so it does save the items but if I didn’t have that small code there it wouldn’t save them

ItzBloxyDev · May 17, 2022, 10:33am

ye, this is because the script stops running cause the server no longer exists.
or something along the lines of this

1NoFree · May 17, 2022, 10:37am

I recommend using pcall function when you loading data.

local ToolData

local success, errMsg = pcall(function()
    ToolData = SaveData:GetAsync(Player.UserId)
end)

if not success then
 player:Kick()
 warn(errMsg)
end

if success and ToolData then
-- next code
end

ItzBloxyDev · May 17, 2022, 10:38am

yes, I was going to mention this but had a feeling this is what you were going to say

EruptingStudiosGD · May 17, 2022, 10:39am

So like this?


local success, errMsg = pcall(function()
	ToolData = SaveData:GetAsync(Player.UserId)
end)

if not success then
	player:Kick()
	warn(errMsg)
end

if success and ToolData then
	local DataStoreService = game:GetService("DataStoreService")
	local SaveData = DataStoreService:GetDataStore("SaveData")
	local ToolFolder = game:GetService("ServerStorage"):FindFirstChild("SavedTools")
	local Players = game:GetService("Players")

	Players.PlayerAdded:Connect(function(Player)
		local ToolData = SaveData:GetAsync(Player.UserId)

		local Backpack = Player:WaitForChild("Backpack")
		local StarterGear = Player:WaitForChild("StarterGear")

		if ToolData then
			for i, v in pairs(ToolData) do
				if ToolFolder:FindFirstChild(v) and not Backpack:FindFirstChild(v) and not StarterGear:FindFirstChild(v) then
					ToolFolder[v]:Clone().Parent = Backpack
					ToolFolder[v]:Clone().Parent = StarterGear
				end
			end
		end

		Player.CharacterRemoving:Connect(function(Character)
			Character:WaitForChild("Humanoid"):UnequipTools()
		end)
	end)

	Players.PlayerRemoving:Connect(function(Player)
		local ToolTable

		for i,v in pairs(Player.Backpack:GetChildren()) do
			if not ToolTable then ToolTable = {} end
			table.insert(ToolTable, v.Name)
		end
		if ToolTable then
			SaveData:SetAsync(Player.UserId, ToolTable)
		end
	end)

	game:BindToClose(function()
		task.wait(2)
	end)
end

1NoFree · May 17, 2022, 10:39am

Also when you using SetAsync, I recommend pcall function.

EruptingStudiosGD · May 17, 2022, 10:40am

Could you give me a example to a pcall function I’m new thanks

1NoFree · May 17, 2022, 10:44am

local success, errMsg = pcall(function()
	ToolData = SaveData:GetAsync(Player.UserId)
end)

if not success then
	player:Kick("Error while loading data")
	warn(errMsg)
end

if success and ToolData then
	local DataStoreService = game:GetService("DataStoreService")
	local SaveData = DataStoreService:GetDataStore("SaveData")
	local ToolFolder = game:GetService("ServerStorage"):FindFirstChild("SavedTools")
	local Players = game:GetService("Players")

	Players.PlayerAdded:Connect(function(Player)
		local ToolData = SaveData:GetAsync(Player.UserId)

		local Backpack = Player:WaitForChild("Backpack")
		local StarterGear = Player:WaitForChild("StarterGear")

		if ToolData then
			for i, v in pairs(ToolData) do
				if ToolFolder:FindFirstChild(v) and not Backpack:FindFirstChild(v) and not StarterGear:FindFirstChild(v) then
					ToolFolder[v]:Clone().Parent = Backpack
					ToolFolder[v]:Clone().Parent = StarterGear
				end
			end
		end

		Player.CharacterRemoving:Connect(function(Character)
			Character:WaitForChild("Humanoid"):UnequipTools()
		end)
	end)

	Players.PlayerRemoving:Connect(function(Player)
		local ToolTable

		for i,v in pairs(Player.Backpack:GetChildren()) do
			if not ToolTable then ToolTable = {} end
			table.insert(ToolTable, v.Name)
		end
     local success, errMsg = pcall(function()
	     ToolData = SaveData:SetAsync(Player.UserId, ToolTable)
      end)
	end)

	game:BindToClose(function()
		task.wait(2)
	end)
end

That’s it I think

EruptingStudiosGD · May 17, 2022, 10:52am

Ok its broke again… I swear its the animations I go too change one and it breaks I think…

EruptingStudiosGD · May 17, 2022, 11:01am

And the output says

ServerScriptService.SaveTools:6: attempt to index nil with ‘Kick’

1NoFree · May 17, 2022, 11:02am

ooh try :kick lowercase. I made a typo :<

EruptingStudiosGD · May 17, 2022, 11:03am

output says

ServerScriptService.SaveTools:6: attempt to index nil with ‘kick’

on line 6 which is

Player:kick(“Error while loading data”)

1NoFree · May 17, 2022, 11:05am

what is parameter name of player?

EruptingStudiosGD · May 17, 2022, 11:05am

parameter Sorry what is that is it a players name?

1NoFree · May 17, 2022, 11:07am

parameter is like

game.Players.PlayerAdded:Connect(function(player) -- this variable

end)

1NoFree · May 17, 2022, 11:07am

so try this

player:kick("Error while loading data")

EruptingStudiosGD · May 17, 2022, 11:08am

Output: says:

ServerScriptService.SaveTools:6: attempt to index nil with ‘kick’

explorer