Data store not saving

EruptingStudiosGD · May 16, 2022, 7:26pm

Its not reloading items in from last play session

My output says nothing

code:

local DataStoreService = game:GetService("DataStoreService")
local SaveData = DataStoreService:GetDataStore("SaveData")

game:GetService("Players").PlayerAdded:Connect(function(Player)
	local ToolData = SaveData:GetAsync(Player.UserId)
	
	local Backpack = Player:WaitForChild("Backpack")
	local StarterGear = Player:WaitForChild("StarterGear")
	
	if ToolData ~= nil then
		for i, v in pairs(ToolData) do
			if ToolFolder:FindFirstChild(v) and Backpack:FindFirstChild(v) == nil and StarterGear:FindFirstChild(v) == nil then
				ToolFolder[v]:Clone().Parent = Backpack
				ToolFolder[v]:Clone().Parent = StarterGear
			end
		end
	end
	
	Player.CharacterRemoving:Connect(function(Character)
		Character:WaitForChild("Humanoid"):UnequipTools()
	end)
end)

game:GetService("Players").PlayerAdded:Connect(function(Player)
	local ToolTable = {}
	
	for i,v in pairs(Player.Backpack:GetChildren()) do
		table.insert(ToolTable, v.Name)
	end
	if ToolTable ~= nil then
		SaveData:SetAsync(Player.UserId, ToolTable)
	end
end)```

TortenSkjold · May 16, 2022, 10:01pm

Hi!

First of let’s clean up your script.

-- Make a variable for Players
local Players = game:GetService("Players")

game:GetService("Players").PlayerAdded:Connect(function(Player)
-- Have to be:
Players.PlayerAdded:Connect(function(Player)

if ToolData ~= nil then
-- Have to be:
if ToolData then

if ToolFolder:FindFirstChild(v) and Backpack:FindFirstChild(v) == nil and StarterGear:FindFirstChild(v) == nil then
-- Have to be:
if ToolFolder:FindFirstChild(v) and not Backpack:FindFirstChild(v) and not StarterGear:FindFirstChild(v) then

Players.PlayerAdded:Connect(function(Player)
-- Have to be:
Players.PlayerRemoving:Connect(function(Player)

if ToolTable ~= nil then
-- Have to be:
if ToolTable ~= {} then

Also I would suggest adding a BindToClose event, that saves players data when the server shuts down.

Dev_Sie · May 16, 2022, 10:04pm

Its because you don’t have PlayerRemoving event… both of them are PlayerAdded ._. Am I missing something or…?

TortenSkjold · May 16, 2022, 10:05pm

Yes you’re also missing that

if ToolTable ~= nil then

Will always not be nill in the last section, since it’s defined as {}

EruptingStudiosGD · May 17, 2022, 10:04am

Thank you I will use your script with the if ToolTable ~= il then will that be on the last row of the script? the output also says:

ServerScriptService.SaveTools:17: Expected ‘end’ (to close ‘then’ at column 29), got

ItzBloxyDev · May 17, 2022, 10:07am

You probably forgot an ‘end’. Send your current code

EruptingStudiosGD · May 17, 2022, 10:09am

Ok im using the code by @ItzBloxyDev

local Players = game:GetService("Players")
game:GetService("Players").PlayerAdded:Connect(function(Player)
	-- Have to be:
	Players.PlayerAdded:Connect(function(Player)
		if ToolData ~= nil then
			-- Have to be:
			if ToolData then
				if ToolFolder:FindFirstChild(v) and Backpack:FindFirstChild(v) == nil and StarterGear:FindFirstChild(v) == nil then
					-- Have to be:
					if ToolFolder:FindFirstChild(v) and not Backpack:FindFirstChild(v) and not StarterGear:FindFirstChild(v) then
						Players.PlayerAdded:Connect(function(Player)
							-- Have to be:
							Players.PlayerRemoving:Connect(function(Player)
								if ToolTable ~= nil then
									-- Have to be:
									if ToolTable ~= {} then```

ItzBloxyDev · May 17, 2022, 10:15am

When he said “have to be” he meant to replace it like this

local DataStoreService = game:GetService("DataStoreService")
local SaveData = DataStoreService:GetDataStore("SaveData")
local Players = game:GetService("Players")

Players.PlayerAdded:Connect(function(Player)
	local ToolData = SaveData:GetAsync(Player.UserId)
	
	local Backpack = Player:WaitForChild("Backpack")
	local StarterGear = Player:WaitForChild("StarterGear")
	
	if ToolData then
		for i, v in pairs(ToolData) do
			if ToolFolder:FindFirstChild(v) and not Backpack:FindFirstChild(v) and not StarterGear:FindFirstChild(v) then
				ToolFolder[v]:Clone().Parent = Backpack
				ToolFolder[v]:Clone().Parent = StarterGear
			end
		end
	end
	
	Player.CharacterRemoving:Connect(function(Character)
		Character:WaitForChild("Humanoid"):UnequipTools()
	end)
end)

Players.PlayerRemoving:Connect(function(Player)
	local ToolTable
	
	for i,v in pairs(Player.Backpack:GetChildren()) do
        if not ToolTable then ToolTable = {} end
		table.insert(ToolTable, v.Name)
	end
	if ToolTable then
		SaveData:SetAsync(Player.UserId, ToolTable)
	end
end)

EruptingStudiosGD · May 17, 2022, 10:16am

Yeah I’m very dumb at coding I am trying to learn

EruptingStudiosGD · May 17, 2022, 10:18am

Okay, so the output says only 1 thing when reloading the game up after buying an item in the last play session

ServerScriptService.SaveTools:13: attempt to index nil with 'FindFirstChild'

ItzBloxyDev · May 17, 2022, 10:20am

its because ToolFolder was never defined. Im guessing you were following a tutorial and missed a line?

EruptingStudiosGD · May 17, 2022, 10:20am

I was following a tutorial on YouTube but all my lines matched up to the tutorials one I checked like 4 times I did have this solved but it broke its self when adding a new feature in

ItzBloxyDev · May 17, 2022, 10:21am

can you send the link of the video to me?

EruptingStudiosGD · May 17, 2022, 10:21am

EruptingStudiosGD · May 17, 2022, 10:23am

Code maybe different because I had to make a other developer forum post it did work but broke after adding something in and the person that helped me was a bit cocky.

ItzBloxyDev · May 17, 2022, 10:23am

local DataStoreService = game:GetService("DataStoreService")
local SaveData = DataStoreService:GetDataStore("SaveData")
local ToolFolder = game:GetService("ServerStorage"):FindFirstChild("SavedTools")
local Players = game:GetService("Players")

Players.PlayerAdded:Connect(function(Player)
	local ToolData = SaveData:GetAsync(Player.UserId)
	
	local Backpack = Player:WaitForChild("Backpack")
	local StarterGear = Player:WaitForChild("StarterGear")
	
	if ToolData then
		for i, v in pairs(ToolData) do
			if ToolFolder:FindFirstChild(v) and not Backpack:FindFirstChild(v) and not StarterGear:FindFirstChild(v) then
				ToolFolder[v]:Clone().Parent = Backpack
				ToolFolder[v]:Clone().Parent = StarterGear
			end
		end
	end
	
	Player.CharacterRemoving:Connect(function(Character)
		Character:WaitForChild("Humanoid"):UnequipTools()
	end)
end)

Players.PlayerRemoving:Connect(function(Player)
	local ToolTable
	
	for i,v in pairs(Player.Backpack:GetChildren()) do
        if not ToolTable then ToolTable = {} end
		table.insert(ToolTable, v.Name)
	end
	if ToolTable then
		SaveData:SetAsync(Player.UserId, ToolTable)
	end
end)

This should work

EruptingStudiosGD · May 17, 2022, 10:27am

Ok this broke my animations in the sword and didn’t make the item save either when playing in the real game My output says nothing the animation works in studio though

ItzBloxyDev · May 17, 2022, 10:28am

the animations breaking probably has nothing to do with this script but if you add

game:BindToClose(function()
    task.wait(2)
end)

it will save since your testing by yourself

EruptingStudiosGD · May 17, 2022, 10:28am

My code for it to animate this is what seems to have broken it

–Animate–

	
	if Debounce == false then
		Debounce = true
		
		local Humanoid = Tool.Parent:WaitForChild("Humanoid")
		local AnimTrack = Humanoid:WaitForChild("Animator"):LoadAnimation(Slash)
		AnimTrack.Priority = Enum.AnimationPriority.Action4 --This broke the saving on the last post
		
		AnimTrack:Play()
		wait(1)
		Debounce = false
	end
end)```

EruptingStudiosGD · May 17, 2022, 10:29am

What line do i put this on

[Char limit]