Datastore best practices

[KrimsonWoIf]

You do not have the correct code.

That is way outdated

[zblox164 (zblox)]

This tutorial is decent and might help you improve and add more functionality such as session locking to your system:

DataStores - Beginners to Advanced

Hey! This tutorial will teach you about regular DataStores (I won’t include OrderedDataStores, but they are pretty similar). DataStore Version 2.0 won’t be included in this tutorial either. Over the course of this, we will script a DataStore (that will hopefully be safe). Important: This won’t be as safe as DataStore2 or ProfileService This won’t be as safe as DataStore2 or ProfileService, as both are heavily tested. So just use them if you need a safe DataStore, I only made this for showing…

[imNiceBox]

I referenced the most recent version of the code you posted.

[KrimsonWoIf]

You have to look at the module, not the code i posted. You can find it here

Easy Datastore | Reliable and easy to use datastores, using best practices!

Hello, everyone! I’m excited to share Easy Datastore This will be used for saving data in your games! Check out more information below: [image] Main purpose The primary purpose of Easy Datastore is to store data using reliable and simple systems. Additional Information Another piece of information about Easy Datastore is that it works with remote events. Use the economy module for simplified use! Documentation – Server Module.set(plr, currencyName, currencyValue) Module.get(plr, c…

[Meta_data (Meta)]

@KrimsonWoIf

if it still errors after 5 attempts, i will kick them and tell the player the game is experiencing issues

Still would trigger the PlayerRemoving event which would overwrite their data. You need to check to see if the module loaded their data before updating it in the PlayerRemoving event.

If you’re sharing a public module I would leave kicking up to the developer.

@KrimsonWoIf

to adress crashes, i will add a module.save function for the developers. The developers should call this function during major events like beating a level or buying currency.

This is fair. ProfileService and other modules like it usually just autosave every 30 seconds or so.

@KrimsonWoIf

My script verifies the data before saving it with updateasync

I don’t see that logic in any of the snippets you’ve posted. It simply calls saveData in the PlayerRemoving event, which is why I assumed it’s an issue.

EDIT: This reply is referencing the code snippet(s) you posted in this thread. If you want people to review your DataStore module you should post it in #help-and-feedback:code-review so people aren’t confused.

[asadefa]

Why not just:

local Players = game:GetService("Players")
Players.PlayerRemoving:Connect(saveData)
game:BindToClose(function()
    for _, Player in ipairs(Players:GetPlayers()) do
        saveData(Player)
    end
end)

[KrimsonWoIf]

I fixed the issue regarding it saving the data even if its outdated.

I havent released it yet though since i am waiting to first add autosaving then release one big update.

[imNiceBox]

That’s what I meant.
Additionally, you should make sure not to save the data twice when the server shuts down.

[KrimsonWoIf]

Please review the module to see the code

@asadefa my module had implemented this featue before you mentioned it.

Creator Hub - Store

Furthermore, its recommended by AI

[OneEDM (EDM)]

@KrimsonWoIf

Furthermore, its recommended by AI

Stop spreading this extremely misleading statement- AI is not a trustworthy source of information all it did was see your post appear in search results and summarize it. There was no deep analysis into the code or any sort of reasoning behind this showing up.