Datastore not loading values.`

[dukzae]

Have you tried doing this in a live game instead of in studio?

[LucasMZ_RBX (LucasMZ)]

@astrozzyz

for i,v in ipairs(inventory) do
    if table.find(Table, v.Name) then
        v.Value = Table[v.Name]
    end
end

You can replace this with:

for i, v in pairs(Table) do
    if table.find(inventory, i) then
        table.find(inventory, i).Value = v or 0
    end
end

---

And this:

@astrozzyz

    for i,v in pairs(inventory) do
        local index = SaveDict[i]
            if index then
    	    index = v.Value
    	    print(index)
    	    print("SET")
    	end
    end

With:

for _, child in ipairs(inventory) do
    if SaveDict[child.Name] then
        SaveDict[child.Name] = child.Value
    end
end --// make sure the value names are the same as the ones on the SaveDict.

[astrozzyz (astrozyz)]

Hey, testing this had no effect. I’m assuming the problem now lies with loading, but if it was then the values will be reset to 0, but in the DataStore Editor it says the correct values (somewhat). I am confused on why

This is what the plugin says

And this is what the output prints (after loading values)

(Where it says 0 is what the values are.)

Edit: Tried editing with the plugin and no effect

[LucasMZ_RBX (LucasMZ)]

Yep, problem with loading…

@LucasTutoriaisSaimo

for i, v in pairs(Table) do
    if table.find(inventory, i) then
        table.find(inventory, i).Value = v or 0
    end
end

Ok let’s change some stuff yet again I forgot Instances can’t be gotten with their names but anyways.

for _, v in ipairs(inventory) do
    if Table[v.Name] then
        v.Value = Table[v.Name]
    end
end

[astrozzyz (astrozyz)]

now this loads but it doesn’t save

[LucasMZ_RBX (LucasMZ)]

Can you send me an updated script again with the new changes?

[astrozzyz (astrozyz)]

Here’s the saving

function module:SaveItems(player)
	local inventory = game.ServerStorage.PlayerValues[player.UserId].Inventory:GetChildren()
	local SaveDict = {
		["Teddy"] = 0,
		["Dragon"] = 0,
		["Panda"] = 0,
		["Bear"] = 0,
		["Deer"] = 0,
		["Pig"] = 0,
		["Monkey"] = 0,
		["Bunny"] = 0,
		["Dog"] = 0,
		["Cat"] = 0
	}


	for _, child in ipairs(inventory) do
		if SaveDict[child.Name] then
			print(child.Name)
			SaveDict[child.Name] = child.Value
		end
	end
	local success, errormsg = pcall(function()
		invData:SetAsync(player.UserId,SaveDict)
	end)

	if not success then
		warn(errormsg)
	else
		print("SAVED")
		
		for i,v in pairs(SaveDict) do
			print(SaveDict[i])
		end
	end
end

[LucasMZ_RBX (LucasMZ)]

@astrozzyz

for _, child in ipairs(inventory) do
		if SaveDict[child.Name] then
			print(child.Name)
			SaveDict[child.Name] = child.Value
		end
	end

Just change this to:

for _, child in pairs(inventory) do
    SaveDict[child.Name] = child.Value
end

Also are you sure everything has the same name and everything?

Also, anything about the script you’re calling these functions from?

[astrozzyz (astrozyz)]

Tried this same issue, won’t save, but it loads.

@LucasTutoriaisSaimo

Also are you sure everything has the same name and everything?

Yes they are the exact names

@LucasTutoriaisSaimo

Also, anything about the script you’re calling these functions from?

Its just a playeradded event to load, and a playerremoving to save.

[LucasMZ_RBX (LucasMZ)]

@astrozzyz

Its just a playeradded event to load, and a playerremoving to save.

Anyhow, can I see it?

@astrozzyz

Tried this same issue, won’t save, but it loads.

Idk then.

[astrozzyz (astrozyz)]

game.Players.PlayerAdded:Connect(function(player)
	local playerFolder = script.Folder:Clone()
	playerFolder.Name = player.UserId
	playerFolder.Parent = game.ServerStorage.PlayerValues

	--GetHatchedData(player)

	Inventory:LoadItems(player)
end)

game.Players.PlayerRemoving:Connect(function(player)
	local playerFolder = game.ServerStorage.PlayerValues[player.UserId]
	
	--[[
	for i,v in ipairs(playerFolder.HatchedData:GetDescendants()) do 
		if v:IsA("IntValue") then
			local name = v.Name
			local user = player.UserId

			if v.Value ~= 0 and v.Value ~= hatchedData:GetAsync(user.. name) then
				local s, e = pcall(function()
					hatchedData:SetAsync(user.. name, v.Value)
				end)

				if not s then warn(e) end

				Inventory:SaveItems(player)
			end
		end
	end
	--]]
	
	Inventory:SaveItems(player)
	wait(1)
	playerFolder:Destroy()
end)

ignore the commented out code thats for saving something different, the inventory is handled with a module script/

[DargoA]

I have an idea as to why this doesn’t work. I think if you are in Roblox Studio, and you press Stop, the player removing event seems to have some problems. Either test this on the Roblox Player, or add an autosave that saves in an interval (60 seconds recommended). Hope this helps!

[LucasMZ_RBX (LucasMZ)]

I think it’s more of a problem of him not having a BindToClose() or something.

[angrybino]

The server shutdowns whenever you leave the game in Studio, which is exactly the reason you need to save the data on DataModel | Documentation - Roblox Creator Hub.

game:BindToClose(function()
    for _, player in ipairs(game.Players:GetPlayers()) do
        -- save data here in a new thread
    end
end)  

[astrozzyz (astrozyz)]

I feel like an idiot. I didn’t think that a bind to close would mess with this, but ig it did. Thanks for this, and thanks to @IEnforce_Lawz, @LucasTutoriaisSaimo, and whoever else helped me! TYSM

[LucasMZ_RBX (LucasMZ)]

I would recommend only doing a wait() when on Studio, and then if it’s not studio, loop through every player and save their data. On Studio, the problem is mostly the server closing before the player removing event happens.

[astrozzyz (astrozyz)]

hahhahhhahahahahaha funny moment the datastore is literally duplicating the values idk why

[LucasMZ_RBX (LucasMZ)]

Probably a issue on another script which deals giving a player pets and such. I would create another topic.

[astrozzyz (astrozyz)]

Most likely isn’t, the same script has a function that gives the player the amount of pets based on the datastore, it’s something like

for i = 1, dataValue, 1 do

loop. I can double check but I dont know why itll be doing this

[LucasMZ_RBX (LucasMZ)]

Does the :AddItem() function add a value into the player’s inventory? If yes, then the loop to load the data would use that function instead.