DataStore Saving Problem

CowboySticky · August 19, 2020, 5:36pm

I’m trying to get my data store to save when the player leaves the game, I have 2 different scripts both in ServerScriptService. One holds the data store, this one:

local datastore = game:GetService("DataStoreService")
local ds1 = datastore:GetDataStore("TimeSave")
 
local badgeservice = game:GetService("BadgeService")
local badgeid = 2124575491
local badgeid2 = 2124565356
local badgeid3 = 2124565358
local badgeid4 = 2124565361
 
game.Players.PlayerAdded:Connect(function(plr)
    local m = 0
    local leaderstats = Instance.new("Folder")
    leaderstats.Parent = plr
    leaderstats.Name = "leaderstats"
 
 
    local gems = Instance.new("IntValue")
    gems.Parent = leaderstats
    gems.Name = "Time"
 
    local data
 
    local success, err = pcall(function()
        data = ds1:GetAsync(plr.UserId)
    end)
 
    if success then
        gems.Value = data
    end 
 
    repeat wait()
        m = m + 1
        if m == 2 then
            m = 0
            if plr.leaderstats.Time.Value >= 600 then 
            badgeservice:AwardBadge(plr.UserId, badgeid)
            if plr.leaderstats.Time.Value >= 3600 then 
 
                badgeservice:AwardBadge(plr.UserId, badgeid2)
 
                if plr.leaderstats.Time.Value >= 18000 then 
 
                    badgeservice:AwardBadge(plr.UserId, badgeid3)
 
                    if plr.leaderstats.Time.Value >= 36000 then 
 
                        badgeservice:AwardBadge(plr.UserId, badgeid4)
 
                    end
                end
            end
        end
        end
        wait(1)
        plr.leaderstats.Time.Value = plr.leaderstats.Time.Value + 1
    until plr == nil  
end)

The other one makes the data store save. This one:

local p = game:GetService("Players"):GetPlayerByUserId(1)


game.Players.PlayerRemoving:Connect(function(plr)
	  
	local leaderstats = Instance.new("Folder")
	local a = plr.leaderstats.Time.Value  
	local datastore = game:GetService("DataStoreService")
	local ds1 = datastore:GetDataStore("TimeSave")
	
	ds1:UpdateAsync(p, a) ---Saves the data.
	
	
		
	
	
end)

For some reason it won’t save, please let me know what I’m doing wrong. Thanks.

Syntheix · August 19, 2020, 5:39pm

There’s no point of making a new script to save and get data, put them all in one script.
Next your making a new leaderstats folder, and I assume LUA doesnt know which one to save. plr already has a leaderstats folder so making a new one is useless.

Next, use SetAsync() instead of UpdateAsync() I dont know why but its just better.

If you put them all in the same script, the saving data script should work if you run a pcall().
Make sure to set leaderstats = to the existing leaderstats

jumbopushpop112 · August 19, 2020, 5:43pm

Make sure you have API turned on, huge factor.

CowboySticky · August 19, 2020, 5:43pm

The reason I’m using another script is it’s less mess and it’s easier to do. I tried using SetAsync() but I didn’t know how to use it very well. So I used UpdateAsync() instead.

Syntheix · August 19, 2020, 5:45pm

Set async is practically the same thing. Just the player that you want to save it to, then the arguments (data you want to save)

CowboySticky · August 19, 2020, 5:46pm

Something like this?

local p = game:GetService("Players"):GetPlayerByUserId(1)


game.Players.PlayerRemoving:Connect(function(plr)
	  
	local leaderstats = Instance.new("Folder")
	local a = plr.leaderstats.Time.Value  
	local datastore = game:GetService("DataStoreService")
	local ds1 = datastore:GetDataStore("TimeSave")
	
	ds1:SetAsync(p, a) ---Saves the data.
	
	
		
	
	
end)

Syntheix · August 19, 2020, 5:50pm

Once again remove the leaderstats folder. Player already has one assuming that you have a leaderstats system.
local leaderstats = plr.leaderstats

Two, use a pcall to set the async since ROBLOX Api’s can still fail.

 local success, err = pcall(function()
  --- blah blah do stuff here
)

Three, you are saving the player’s data that is leaving, not the one that you defined. Why are you using p if that’s only saving data for that specific player?

Do ds1:SetAsync(plr, a)

AbiZinho · August 19, 2020, 5:53pm

Firstly, I would also suggest putting all the code in one script, so its easier to manage and handle, unless you absolutely need to.

When you run the function connected with the PlayerRemoving event, you save the value of Time, yet you get the Value of gems when the player joins again. Could this be a possible mistake? You should try to save the gems Value if you want to retrieve it the next time the player joins the game.

Additionally, UpdateAsync accepts two parameters, the key it should update data in, and a function that actually updates the data (which it runs on its own). See here for more info. However, I think it makes little difference to use UpdateAsync in this case, and you could use SetAsync here. I made example code below to use as a guideline.

game.Players.PlayerRemoving:Connect(function(Player)
     local leaderstats = Player.leaderstats
     local Gems_Value = leaderstats.Gems.Value
     local datastore = game:GetService("DataStoreService")
     local ds1 = datastore:GetDataStore("TimeSave")

     local success, err = pcall(function()
        ds1:SetAsync(Player.UserId, Gems_Value)
    end)   

end)

@Syntheix UpdateAsync is actually more reliable of a saving method compared to SetAsync when use correctly. If you would like to learn more please read this great article.

CowboySticky · August 19, 2020, 5:55pm

Thanks. Could I use the code you used in the example to save the data?

AbiZinho · August 19, 2020, 5:56pm

This would likely work if you were planning to save the Gems the player has. However, you save the Time in your original post, so I’m not sure if this would be what you need.

CowboySticky · August 19, 2020, 5:57pm

Wouldn’t it be the same though if I change Gems to Time in this line?

local Gems_Value = leaderstats.Time.Value

Syntheix · August 19, 2020, 5:59pm

But isn’t time and gems value different? That would be over complicating it? Unless your planning to change Time.value to Gems.Value

AbiZinho · August 19, 2020, 5:59pm

It’s hard to tell because in your script you have written the following code.

local success, err = pcall(function()
      data = ds1:GetAsync(plr.UserId)
end)
 
if success then
     gems.Value = data
end

If you don’t save the gems.Value, you will always be using default data and it will never properly save.

What is the Time data used for anyways?

CowboySticky · August 19, 2020, 6:00pm

It’s made so I can award time badges, in other words, award a badge for staying in the game a curtain amount of time. I’m trying to make it save so you don’t have to restart everytime you rejoin.

AbiZinho · August 19, 2020, 6:02pm

Oh I see now, silly me.

Nevermind, this will work. Use leaderstats.Time.Value. Sorry, I did not see this.

CowboySticky · August 19, 2020, 6:04pm

Thanks. Sorry just want to double check, so something like this? For some reason it still won’t save in studio.


game.Players.PlayerRemoving:Connect(function(Player)
     local leaderstats = Player.leaderstats
     local timevalue = leaderstats.Time.Value
     local datastore = game:GetService("DataStoreService")
     local ds1 = datastore:GetDataStore("TimeSave")

     local success, err = pcall(function()
        ds1:SetAsync(Player.UserId, timevalue)
    end)   

end)

AbiZinho · August 19, 2020, 6:06pm

All good, but make sure to remove these lines

     local datastore = game:GetService("DataStoreService")
     local ds1 = datastore:GetDataStore("TimeSave")

Since you will be putting all the code in one script instead of two. Use the variables defined at the top of your first script (datastore and ds1).

CowboySticky · August 19, 2020, 6:09pm

Before:
Screen Shot 2020-08-19 at 1.08.20 PM
After:

I think I did something wrong, for some reason it won’t save when you leave. It just sets back to 0. I assume I put it in the wrong place.

local datastore = game:GetService("DataStoreService")
local ds1 = datastore:GetDataStore("TimeSave")
 
local badgeservice = game:GetService("BadgeService")
local badgeid = 2124575491
local badgeid2 = 2124565356
local badgeid3 = 2124565358
local badgeid4 = 2124565361
 
game.Players.PlayerAdded:Connect(function(plr)
    local m = 0
    local leaderstats = Instance.new("Folder")
    leaderstats.Parent = plr
    leaderstats.Name = "leaderstats"
 
 
    local gems = Instance.new("IntValue")
    gems.Parent = leaderstats
    gems.Name = "Time"
 
    local data
 
    local success, err = pcall(function()
        data = ds1:GetAsync(plr.UserId)
    end)
 ---Where is saves.
	  game.Players.PlayerRemoving:Connect(function(Player)
		local leaderstats = Player.leaderstats
     local timevalue = leaderstats.Time.Value   
		     
		local success, err = pcall(function()
        ds1:SetAsync(Player.UserId, timevalue)
    end)   

end)  
---End of where it saves.	
	
	
	
	
	if success then
        gems.Value = data
    end 
 
    repeat wait()
        m = m + 1
        if m == 2 then
            m = 0
            if plr.leaderstats.Time.Value >= 600 then 
            badgeservice:AwardBadge(plr.UserId, badgeid)
            if plr.leaderstats.Time.Value >= 3600 then 
 
                badgeservice:AwardBadge(plr.UserId, badgeid2)
 
                if plr.leaderstats.Time.Value >= 18000 then 
 
                    badgeservice:AwardBadge(plr.UserId, badgeid3)
 
                    if plr.leaderstats.Time.Value >= 36000 then 
 
                        badgeservice:AwardBadge(plr.UserId, badgeid4)
 
                    end
                end
            end
        end
        end
        wait(1)
        plr.leaderstats.Time.Value = plr.leaderstats.Time.Value + 1
    until plr == nil  
end)

AbiZinho · August 19, 2020, 6:17pm

stickymirro511:

game.Players.PlayerRemoving:Connect(function(Player)
     local leaderstats = Player.leaderstats
     local timevalue = leaderstats.Time.Value   
		     
     local success, err = pcall(function()
        ds1:SetAsync(Player.UserId, timevalue)
    end)   

end)

Make sure to put this code at the very end, after game.Players.PlayerAdded.

Are there any errors in the output?

CowboySticky · August 19, 2020, 6:20pm

I think i see the problem, success is defined twice. Could that be a problem?