Deaths aren't counting for leaderstats

Megaificent · March 26, 2020, 9:47pm

hello. not too sure why these deaths aren’t counting for the leaderstats if anyone could help me thank you for your time. there isn’t any errors in the output by the looks of things. if u need me to provide u with more info ill gladly be willing to do so. thanks.

leaderstats script

	local leaderstats = Instance.new("Folder", player)
    leaderstats.Name = "leaderstats"
	leaderstats.Parent = player
	
	local level = Instance.new("IntValue")
	level.Name = "Level"
	level.Value = 0
	level.Parent = leaderstats
	
	local XP = Instance.new("IntValue")
	XP.Name = "XP"
	XP.Value = 0
	XP.Parent = leaderstats
	
    local Deaths = Instance.new("IntValue", leaderstats)
    Deaths.Name = "Deaths"
    Deaths.Value = 0
    Deaths.Parent = leaderstats

2nd part to leaderstats script

	local player = game.Players.LocalPlayer or game.Players.PlayerAdded:Wait()
    local char = player.Character or player.CharacterAdded:Wait()
    local humanoid = char:WaitForChild("Humanoid")

    humanoid.Died:Connect(function(plr)
	    plr.leaderstats.Deaths.Value = plr.leaderstats.Deaths.Value + 1
		
	end)		
end

Spooce · March 26, 2020, 9:51pm

You named the value “Deaths” and referred to it as “Death” here.

Megaificent · March 26, 2020, 9:57pm

continues to not count my deaths for the leaderstats.

Spooce · March 26, 2020, 9:59pm

This event doesn’t have any parameters; try using the player variable you initialized above.

sjr04 · March 26, 2020, 10:03pm

Also you aren’t using a server script so this won’t be replicated. Use a server script.

NewPuncher · March 26, 2020, 10:04pm

Move this section to the server script since you’ve already defined the player.

local char = player.Character or player.CharacterAdded:Wait()
local humanoid = char:WaitForChild("Humanoid")

humanoid.Died:Connect(function()
    player.leaderstats.Deaths.Value = player.leaderstats.Deaths.Value + 1
	
end)

Megaificent · March 26, 2020, 10:12pm

it is in service script service, also still not working. ill show u my whole script.

Megaificent · March 26, 2020, 10:12pm

local Players = game:GetService("Players")
local DataStoreService = game:GetService("DataStoreService")
local SaveDataStore = DataStoreService:GetDataStore("SaveData")

local function SavePlayerData(player)
	
	local success, errormsg = pcall(function()
		local SaveData = {}
		for i, stats in pairs(player.leaderstats:GetChildren()) do
			SaveData[stats.Name] = stats.Value
		end	
		SaveDataStore:SetAsync(player.UserId, SaveData)
	end)
	
	if not success then 
		return errormsg
	end			
end	

game.Players.PlayerAdded:Connect(function(player)
	
	local leaderstats = Instance.new("Folder", player)
    leaderstats.Name = "leaderstats"
	leaderstats.Parent = player
	
	local level = Instance.new("IntValue")
	level.Name = "Level"
	level.Value = 0
	level.Parent = leaderstats
	
	local XP = Instance.new("IntValue")
	XP.Name = "XP"
	XP.Value = 0
	XP.Parent = leaderstats
	
    local Deaths = Instance.new("IntValue", leaderstats)
    Deaths.Name = "Deaths"
    Deaths.Value = 0
    Deaths.Parent = leaderstats

	
local Data = SaveDataStore:GetAsync(player.UserId)
	
	if Data then
		for i, stats in pairs(leaderstats:GetChildren()) do
			stats.Value = Data[stats.Name]
		end		
	else		
		print(player.Name .. " has no data.")			
	end
		
	local expToLevelUp
	local expForPreviousLevel = 0

	while wait() do
				
	    local player = game.Players.LocalPlayer or game.Players.PlayerAdded:Wait()
        local char = player.Character or player.CharacterAdded:Wait()
        local humanoid = char:WaitForChild("Humanoid")

        humanoid.Died:Connect(function()
	        player.leaderstats.Deaths.Value = player.leaderstats.Deaths.Value + 1
		
		local levelBar = player.PlayerGui:WaitForChild("LevelBar")	
		if level.Value < 1 then 
			
			expToLevelUp = 100 
		else
			expToLevelUp = math.floor(level.Value ^ 1.3) * 200 + math.floor(level.Value ^ 4)
		end
		
		if XP.Value >= expToLevelUp then
			level.Value = level.Value + 1	
		end
		
		expForPreviousLevel = math.floor((level.Value - 1) ^ 1.3) * 200 + math.floor((level.Value - 1) ^ 4)
		
		local expDifference = expToLevelUp - expForPreviousLevel
		local expDifference2 = XP.Value - expForPreviousLevel
			
		
		levelBar.Bar:TweenSize(UDim2.new(levelBar.BarBackground.Size.X.Scale * (expDifference2 / expDifference), 0, levelBar.BarBackground.Size.Y.Scale, 0), Enum.EasingDirection.InOut, Enum.EasingStyle.Quint, 0.001)
		levelBar.Experience.Text = expDifference2 .. "/" .. expDifference
		levelBar.Level.Text = "Level: " .. level.Value
		
		XP.Value = XP.Value + 1
		
	end)
end


Players.PlayerRemoving:Connect(function(player)
	
	local errormsg = SavePlayerData(player)
	
	if errormsg then	
		warn(errormsg)		
	end
end)

game:BindToClose(function()
	for i, player in pairs(Players:GetPlayers()) do	
		
		local errormsg = SavePlayerData(player)
		if errormsg then
			warn(errormsg)
		end			
	end
	wait(2)	
	end)
end)

NewPuncher · March 26, 2020, 10:15pm

You cannot use LocalPlayer on a server script. You’ve already defined player with the PlayerAdded function so you might as well use that.

Megaificent · March 26, 2020, 10:21pm

changed that, i know this is off topic but now its not showing the deaths category for the leaderstats?

NewPuncher · March 26, 2020, 10:24pm

Did you change the parent of Deaths? If it isn’t parented to leaderstats it won’t show on the player list.

Megaificent · March 26, 2020, 10:25pm

no.

	
    local Deaths = Instance.new("IntValue", leaderstats)
    Deaths.Name = "Deaths"
    Deaths.Value = 0
    Deaths.Parent = leaderstats

NewPuncher · March 26, 2020, 10:26pm

That’s peculiar. If you use the explorer when you play test is it there?
Also if there are any, any errors?

Megaificent · March 26, 2020, 10:30pm

weird. just tested again and it worked, also found an error relating to deaths. character is not a valid member of RBXScriptSignal.

NewPuncher · March 26, 2020, 10:34pm

That’s assumably because you did

 player =  game.Players.PlayerAdded:Wait()

If the Humanoid.Died() function is inside the game.Players.PlayerAdded function at the top of the script you don’t need to define the player anymore I.e you can get rid of the line I stated.

Megaificent · March 26, 2020, 10:35pm

so would i delete that complete line of code?

NewPuncher · March 26, 2020, 10:35pm

Yes. That should work since you’ve already defined player at the start of the script.

Megaificent · March 26, 2020, 10:40pm

so it decided nawt to show the deaths for the leaderstats again. no clue why it keeps working and not working. no errors relating to script.

Megaificent · March 26, 2020, 10:40pm

local Players = game:GetService("Players")
local DataStoreService = game:GetService("DataStoreService")
local SaveDataStore = DataStoreService:GetDataStore("SaveData")

local function SavePlayerData(player)
	
	local success, errormsg = pcall(function()
		local SaveData = {}
		for i, stats in pairs(player.leaderstats:GetChildren()) do
			SaveData[stats.Name] = stats.Value
		end	
		SaveDataStore:SetAsync(player.UserId, SaveData)
	end)
	
	if not success then 
		return errormsg
	end			
end	

game.Players.PlayerAdded:Connect(function(player)
	
	local leaderstats = Instance.new("Folder", player)
    leaderstats.Name = "leaderstats"
	leaderstats.Parent = player
	
	local level = Instance.new("IntValue")
	level.Name = "Level"
	level.Value = 0
	level.Parent = leaderstats
	
	local XP = Instance.new("IntValue")
	XP.Name = "XP"
	XP.Value = 0
	XP.Parent = leaderstats
	
    local Deaths = Instance.new("IntValue", leaderstats)
    Deaths.Name = "Deaths"
    Deaths.Value = 0
    Deaths.Parent = leaderstats

	
local Data = SaveDataStore:GetAsync(player.UserId)
	
	if Data then
		for i, stats in pairs(leaderstats:GetChildren()) do
			stats.Value = Data[stats.Name]
		end		
	else		
		print(player.Name .. " has no data.")			
	end
		
	local expToLevelUp
	local expForPreviousLevel = 0

	while wait() do
		
        local char = player.Character or player.CharacterAdded:Wait()
        local humanoid = char:WaitForChild("Humanoid")

        humanoid.Died:Connect(function()
	        player.leaderstats.Deaths.Value = player.leaderstats.Deaths.Value + 1
		
		local levelBar = player.PlayerGui:WaitForChild("LevelBar")	
		if level.Value < 1 then 
			
			expToLevelUp = 100 
		else
			expToLevelUp = math.floor(level.Value ^ 1.3) * 200 + math.floor(level.Value ^ 4)
		end
		
		if XP.Value >= expToLevelUp then
			level.Value = level.Value + 1	
		end
		
		expForPreviousLevel = math.floor((level.Value - 1) ^ 1.3) * 200 + math.floor((level.Value - 1) ^ 4)
		
		local expDifference = expToLevelUp - expForPreviousLevel
		local expDifference2 = XP.Value - expForPreviousLevel
			
		
		levelBar.Bar:TweenSize(UDim2.new(levelBar.BarBackground.Size.X.Scale * (expDifference2 / expDifference), 0, levelBar.BarBackground.Size.Y.Scale, 0), Enum.EasingDirection.InOut, Enum.EasingStyle.Quint, 0.001)
		levelBar.Experience.Text = expDifference2 .. "/" .. expDifference
		levelBar.Level.Text = "Level: " .. level.Value
		
		XP.Value = XP.Value + 1
		
	end)
end


Players.PlayerRemoving:Connect(function(player)
	
	local errormsg = SavePlayerData(player)
	
	if errormsg then	
		warn(errormsg)		
	end
end)

game:BindToClose(function()
	for i, player in pairs(Players:GetPlayers()) do	
		
		local errormsg = SavePlayerData(player)
		if errormsg then
			warn(errormsg)
		end			
	end
	wait(2)	
	end)
end)

NewPuncher · March 26, 2020, 10:51pm

When the leaderboard does work, do the deaths count?
As for the fact that it doesn’t work, I’m not really sure why the leaderstats do and don’t appear, you’ve seem to create the leaderstats just fine.