"Developer" icon is black on "Page doesn't exist" page with dark mode


On “Page doesn’t exist” page of the DevForum, when using dark mode the “Developer” icon is black instead of white in most pages of the forum. I think that the page was overlooked when dark mode was introduced. I can reproduce it 100% of the times, and I’m using Edge Chromium Dev 82.0.439.1, 64-bit.

5 Likes

This also happens with Vincent and Grey Amber themes.

1 Like

The underlying issue here seems to be the Discourse 404 page not respecting theme-specific icons. (If you look closely, you’ll see it’s using the light theme icon).

You may want to report this on https://meta.discourse.org as I’m not sure if this is a DevForum-specific issue.

2 Likes

Fixed:
image

It looks like the ID on the logo is different on specifically that page (not entirely sure if Discourse made it that way intentionally or not), so I modified the CSS to take it into account.

(You may have to hard-refresh to see it)

4 Likes

This seems to have caused the full logo to show when the topic name and stuff is visible.

Edit: This is how it used to look. (I modified the CSS to undo the change)

1 Like

Should be fixed after a hard refresh now

2 Likes

The error page is showing the black logo again. Is this intentional?

Why does it even matter that the logo is black on a page that tells you a topic doesn’t exist, espacially if it’s only happening on THAT PAGE?

It hurts your eyes in general.

1 Like

I think I forgot to adjust it for all themes. Should be fixed now. :smiley:

3 Likes