Do player connections get disconnected when player leaves?

[apenzijncoolenleuk1 (Apenz1)]

Hello, I’m trying to execute some code (on the server) when a player changes his team.
I’m using this code:

local Players = game:GetService("Players")
for _, player in pairs(Players:GetPlayers()) do
	player:GetPropertyChangedSignal("Team"):Connect(function()
           print("Player changed team")
           -- Executing code here...
	end)
end

But will this code not cause a memory leak? I’ve looked on the forum and from what I’ve read Players don’t get “:Destroy()”-ed when they leave. So the connection would still be active when the specified Player left the game? Would there be a better way to know if a Player changed it’s team? (preferably without RemoteEvents)

Any help is appreciated.

[Useless_Dolphin (Useful)]

To my knowledge connections don’t disconnect unless you disconnect the function using :Disconnect()

[WaterJamesPlough (Neil)]

As much as I know, that code won’t cause any kind of Memory leaks but I have a feeling you should connect it when a player joins instead of running a loop through all players.

Also as said on the Devhub API, you might want to Disconnect the connection is its necessary but in this case when player leaves the player instance is deleted so the Connection is disconnected automatically.

Connections like Runservice RenderStepped, Heartbeat etc that need to do something for a short time should be disconnected, otherwise they might cause Memory leak.

[angrybino]

Yes, they do get disconnected because whenever a player leaves, the parent of that player is set to nil or in other ways, the player object is destroyed.

Your code won’t cause a memory leak but wouldn’t work for new players either since you only loop once.

A better way to know if a player changed their team is to use the PlayerAdded event, that way the code will work for everyone. However there is still 1 drawback. If the code executes really late when there are still players in the server, it would only count for new players. It’s better to have a function and run that function for every player ( looping ).

game.Players.PlayerAdded:Connect(function(player)
     player:GetPropertyChangedSignal("Team"):Connect(function()
           print(player.Name .. " changed their team")
           -- Executing code here...
	end)
end)

[apenzijncoolenleuk1 (Apenz1)]

Thanks for your quick replies @Dolphin_Worm, @WaterJamesPlough and @SilentsReplacement.
I also thought connections on a player would be destroyed when they left, but I found some topics that say the contrary. They are kind of old but I think still relevant?

Properly destroy player on leave

The destroy wiki explains that destroy “Sets the Instance.Parent property to nil, locks the Instance.Parent property, disconnects all connections and calls Destroy on all children” As a Roblox developer, it is currently too hard to manually unlink the player signal connections (such as CharacterAdded) to prevent memory leaks and other bugs that may rely on the player connections being disconnected (because you expect certain items to be garbage collected, but they persist indefinitely) If Ro…

When a player leaves the place, do all connections attached directly to the player get disconnected?

ex: Players.PlayerAdded:connect(function(p) p.ChildAdded:connect(function() -- connection get disconnected end) end) Does the ChildAdded event get disconnected? If not, there’s a lot of memory leaks left for me to fix.

Also I want it so that only the players in-game at that moment get a connection. So using PlayerAdded isn’t the right solution here.

[angrybino]

Wouldn’t work, by the time the script runs there are no players in the server. Only would work if the script ran really late when the players are in the game.

[apenzijncoolenleuk1 (Apenz1)]

Yes, this code snippet is part of a larger script and runs when a round in my game starts. After players have joined.

[angrybino]

You are all good then. The code itself won’t cause a memory leak as I previously said.