Else statement not working correctly?

Help and Feedback Scripting Support
#1

For some reason, if I’m not within that distance it only prints (“NOT SHOWING EGG”), which is fine. But if you are within that distance. Both start printing… when It’s only supposed to print (“SHOWING EGG”)?

function HotkeyService:GetNearbyEggs()
	local MaxDistance = 10
	for _, Egg in pairs(game.Workspace.Eggs:GetChildren()) do
		local Char = Player.Character
		local Distance = Player:DistanceFromCharacter(Egg.PrimaryPart.Position)
		local Billboard = Client:FindFirstChild("EggBillboard")
		if Distance < MaxDistance then
			print("SHOWING EGG")
		else
			print("NOT SHOWING EGG")
		end
	end
end

function HotkeyService:Initialize()
	RunService:BindToRenderStep("Eggs", 1, function()
		self:GetNearbyEggs()
	end)
end
#2

Try printing the distance value to see if it is working properly.

1 Like
#3

Since I have three eggs, it prints the distance from all three eggs.

image

#4

Compare them with the MaxDistance value.

#5

This is if I’m near one of the eggs.

print(Distance < MaxDistance)

image

#6

Assuming that you were near an egg when the issue occurred, it appears that the reason it is printing “both” values is because you had some eggs within the maximum distance, while others weren’t. It isn’t actually printing both values, it is just printing one.

1 Like
#7

So I should probably add some type of debounce to detect if it is within distance on one of the three eggs.

#8

Something like this would work.

function HotkeyService:GetNearbyEggs()

	local MaxDistance = 10
	local IsNearby = false

	for _, Egg in pairs(game.Workspace.Eggs:GetChildren()) do
		local Char = Player.Character
		local Distance = Player:DistanceFromCharacter(Egg.PrimaryPart.Position)
		local Billboard = Client:FindFirstChild("EggBillboard")
		if Distance < MaxDistance then
			print("SHOWING EGG")
			IsNearby = true
			break
		end
	end

	if not IsNearby then
		print("NOT SHOWING EGG")
	end
end
1 Like
#9

Works until you walk away from the egg.

#10

It’s within the function, so every time that function is called it’s a clean slate. If you want it to work otherwise you’d have to make the flag (IsNearby) global.

1 Like
#11

How could that be done? I’m trying to, but I’m having a hard time doing so and the logic behind figuring this out.

#12

Declare IsNearby outside of the function?

#13

Yes, it is currently declared outside of the function at the moment.

#14

I figured it out myself.

Here is the solution for those who are interested in how I did it:

Solution:

--// MODULE \\--
-- Variables:
local Client = Player.PlayerGui.Client
local Eggs = game.Workspace.Eggs
local MaxDistance = 10
local NearbyEgg
local ShowingEgg = false

function EggService:GetNearbyEgg()
	for _, Egg in pairs(game.Workspace.Eggs:GetChildren()) do
		local Distance = Player:DistanceFromCharacter(Egg.PrimaryPart.Position)
		if Distance < MaxDistance then
			NearbyEgg = tostring(Egg)
		end
	end
end

function EggService:Initialize()
	RunService:BindToRenderStep("Eggs", 1, function()
		self:GetNearbyEgg() -- Always gets the NearbyEgg.
		if NearbyEgg then -- Checks until NearbyEgg is actually defined.
			local Distance = Player:DistanceFromCharacter(Eggs[NearbyEgg].PrimaryPart.Position)
			if Distance < MaxDistance then
				if not ShowingEgg then
					print("Close to " .. NearbyEgg .. "!")
					ShowingEgg = true
				end
			else
				print("Not close to any egg.")
				ShowingEgg = false
			end
		end
	end)
end

Print:

image This printed the name of the closest eggs at the time, if within MaxDistance.