Error with code

Help and Feedback Scripting Support
#1

Hey all, I am making this gate code but I don’t know why I am getting this error. Please help.

image_2022-06-14_175511332
image_2022-06-14_175511332828×550 48.7 KB

Note: I am not great with coding so don’t judge me.

#2

use Vector3.new

if gate.Position == Vector3.new(-21.5, 12.625, -79,75) then
#3

I am not getting an error but the down tween doesn’t play.

Again, I am not good at coding as I am still learning.

My code also:

local gate = game.Workspace.Doors.Gate1.Gate
local status = game.Workspace.Values.Status
local label = script.Parent.Status.SurfaceGui.TextLabel
local button = script.Parent.Open.ClickDetector

local ts = game:GetService("TweenService")

local info = TweenInfo.new(10)
local p = {Position = Vector3.new(-21.5, 15.625, -79.75)}
local r = {Position = Vector3.new(-21.5, 6.5, -79.75)}

local up = ts:Create(gate, info, p)
local down = ts:Create(gate, info, r)

button.MouseClick:Connect(function()
	up:Play()
	end)

button.MouseClick:Connect(function()
	if gate.Position == Vector3.new(-21.5, 12.625, -79,75) then
		down:Play()
	else
		up:Play()
	end
end)
#4 
if gate.Position == Vector3.new(-21.5, 12.625, -79,75) then
		down:Play()
	elseif gate.Position == Vector3.new(-21.5, 6.5, -79.75) then
		up:Play()
	end
#5

Isn’t it better to use else instead of elseif?

#6

Sorry, it still doesn’t work.

Here’s my code:

local gate = game.Workspace.Doors.Gate1.Gate
local status = game.Workspace.Values.Status
local label = script.Parent.Status.SurfaceGui.TextLabel
local button = script.Parent.Open.ClickDetector

local ts = game:GetService("TweenService")

local info = TweenInfo.new(10)
local p = {Position = Vector3.new(-21.5, 15.625, -79.75)}
local r = {Position = Vector3.new(-21.5, 6.5, -79.75)}

local up = ts:Create(gate, info, p)
local down = ts:Create(gate, info, r)

button.MouseClick:Connect(function()
	

if gate.Position == Vector3.new(-21.5, 12.625, -79,75) then
	down:Play()
elseif gate.Position == Vector3.new(-21.5, 6.5, -79.75) then
	up:Play()
	end
end)
#7

got a little idea:
instead of checking gates position you could check bool value
this might work

local gate = game.Workspace.Doors.Gate1.Gate
local status = game.Workspace.Values.Status
local label = script.Parent.Status.SurfaceGui.TextLabel
local button = script.Parent.Open.ClickDetector
local open = false

local ts = game:GetService("TweenService")

local info = TweenInfo.new(10)
local p = {Position = Vector3.new(-21.5, 15.625, -79.75)}
local r = {Position = Vector3.new(-21.5, 6.5, -79.75)}

local up = ts:Create(gate, info, p)
local down = ts:Create(gate, info, r)

button.MouseClick:Connect(function()
if open then
	down:Play()
else
	up:Play()
	end
end)
1 Like
#8

This is the correct way to do this, however you don’t change the boolean when the gate is open,i.e.

button.MouseClick:Connect(function()
	if open then
		down:Play()
		open = false;
	else
		up:Play()
		open = true;
	end
end)
2 Likes
#9

open and status looks like used already.

And, what’s object’s initial position?

#10

Status is for later in the code. It’s for a screen that shows whether the gate is opened or closed.

1 Like
#11

You could just use that instead of open. Is the status value a boolean or something else?

#12

Yours kind of worked but I did it a different way.

Here’s my code:

button.MouseClick:Connect(function()
	if gate.Position == Vector3.new(-21.5, 15.625, -79.75) then
		open = true
		down:Play()
	elseif gate.Position == Vector3.new(-21.5, 6.5, -79.75) then
		open = false
		up:Play()
	end
end)
#13

So, basically, the code works now.

#14

I’ll mark yours as the solution because it was close to my code.

#15

You don’t need to check the doors position, the open boolean tells you the position by it’s very nature (up = true, down = false).

#16 
button.MouseClick:Connect(function()
	open = not open
	if open then up:Play() else down:Play() end
end)
#17

Always better to code with the compound operator (makes it more readable since all the information is on the same line). However, I try to keep the code as close to the original to save over complicating the solution. Not one like given to anyone, man you must be the harshest of critics!