Expressions system no longer working when player resets?

Help and Feedback Scripting Support
, ,
#1

Hi, so, the issue i have here is quite simple and understandable. The character’s expression system here won’t work anymore after they reset. I don’t know or understand why? The local script is in StarterCharacterScripts, btw.

LocalScript:

--||Services
local Players = game:GetService("Players")
local RunService = game:GetService("RunService")
local ReplicatedStorage = game:GetService("ReplicatedStorage")
--||Variables
local Utilities = ReplicatedStorage:WaitForChild("Utilities")
local Expressions = require(Utilities.Expressions)
local Player = Players.LocalPlayer
local Character = Player.Character or Player.CharacterAdded:Wait()
local CharacterSettings = Character:WaitForChild("Settings")
local Humanoid = Character:WaitForChild("Humanoid")
local Animator = Humanoid.Animator
--|Expression
RunService.Heartbeat:Connect(function()
    for _, Anim in Animator:GetPlayingAnimationTracks() do
        if CharacterSettings:GetAttribute("Hurting") == false and (Anim.Name == "Animation1" or Anim.Name == "Animation2") and CharacterSettings:GetAttribute("Drifting") == false and CharacterSettings:GetAttribute("Bolting") == false and CharacterSettings:GetAttribute("Tramping") == false then
            Expressions:Swap("Happy", "Happy", "HappyClosed", "Idle")
        elseif (Anim.Name == "WalkAnim" or Anim.Name == "RunAnim") and CharacterSettings:GetAttribute("Hurting") == false and CharacterSettings:GetAttribute("Drifting") == false and CharacterSettings:GetAttribute("Bolting") == false and CharacterSettings:GetAttribute("Tramping") == false then
            Expressions:Swap("Happy", "Happy", "HappyOpen", "Walk/Run")
        elseif Anim.Name == "JumpAnim" and CharacterSettings:GetAttribute("Hurting") == false and CharacterSettings:GetAttribute("Drifting") == false and CharacterSettings:GetAttribute("Bolting") == false and CharacterSettings:GetAttribute("Tramping") == false then
            Expressions:Swap("Happy", "Blink", "HappyClosed", "Jump")
        elseif Anim.Name == "FallAnim" and CharacterSettings:GetAttribute("Hurting") == false and CharacterSettings:GetAttribute("Drifting") == false and CharacterSettings:GetAttribute("Bolting") == false and CharacterSettings:GetAttribute("Tramping") == false then
            Expressions:Swap("Happy", "Down", "HappyClosed", "Fall")
        elseif Anim.Name == "Ventilator" and CharacterSettings:GetAttribute("Hurting") == false and CharacterSettings:GetAttribute("Drifting") == false and CharacterSettings:GetAttribute("Bolting") == false and CharacterSettings:GetAttribute("Tramping") == false then
            Expressions:Swap("Happy", "Up", "HappyOpen", "Ventilator")
        elseif Anim.Name == "Ring" and CharacterSettings:GetAttribute("Hurting") == false or CharacterSettings:GetAttribute("Bolting") == true then
            Expressions:Swap("Surprised", "Happy", "HappyOpen", "Ring/Bolt")
        elseif Anim.Name == "Drift" and CharacterSettings:GetAttribute("Hurting") == false or CharacterSettings:GetAttribute("Drifting") == true then
            Expressions:Swap("Happy", "Down", "Curious", "Drift")
        elseif Anim.Name == "Tramp" and CharacterSettings:GetAttribute("Hurting") == false or CharacterSettings:GetAttribute("Tramping") == true then
            Expressions:Swap("Angry", "Blink", "AngryClosed", "Tramp")
        elseif Anim.Name == "Propel" and CharacterSettings:GetAttribute("Hurting") == false or CharacterSettings:GetAttribute("Propelling") == true then
            Expressions:Swap("Happy", "Blink", "HappyClosed", "Jump")
        elseif CharacterSettings:GetAttribute("Hurting") == true then
            Expressions:Swap("Sad", "Sad", "BoredClosed", "Hurt")
        end
    end
end)

ModuleScript:

--||Services
local Players = game:GetService("Players")
--||Variables
local Player = Players.LocalPlayer
local Character = Player.Character or Player.CharacterAdded:Wait()
local CharacterSettings = Character:WaitForChild("Settings")
local EyebrowsV = {
    Character:WaitForChild("LeftEyebrow").GUI,
    Character:WaitForChild("RightEyebrow").GUI
}
local EyesV = {
    Character:WaitForChild("LeftEye").GUI,
    Character:WaitForChild("RightEye").GUI,
    Character:WaitForChild("LeftEye").ChronoGUI,
    Character:WaitForChild("RightEye").ChronoGUI
}
local MouthV = Character:WaitForChild("Mouth").GUI
local MouthSide = ""
--------------------------------------
local Expressions = {}
--||Functions
function Expressions:MouthFaceCamera(Root, Camera)
    if Character then
        local ViewDistance = (Root.Position - Camera.CFrame.Position).Unit
        local Dot = ViewDistance:Dot(Root.CFrame.RightVector)
        if Dot > -1 and Dot < 0 then
            MouthSide = "Left"
        elseif Dot < 1 and Dot > 0 then
            MouthSide = "Right"
        end
    end
end
--------------------------------------
function Expressions:Swap(Eyebrows: string, Eyes: string, Mouth: string, Expression: string)
    CharacterSettings:SetAttribute("Expression", Expression)
    --------------------------------------
    for _, Eyebrow : SurfaceGui in ipairs(EyebrowsV) do
        for _, Image : ImageLabel in ipairs(Eyebrow:GetChildren()) do
            if Image.Name ~= Eyebrows then
                Image.Visible = false
            else
                Image.Visible = true
            end
        end
    end
    --------------------------------------
    for _, Eye : SurfaceGui in ipairs(EyesV) do
        if not string.match(Eye.Name, "Chrono") then
            for _, Image : ImageLabel in ipairs(Eye:GetChildren()) do
                if Image.Name ~= Eyes then
                    Image.Visible = false
                else
                    Image.Visible = true
                end
            end
        else
            for _, Image : ImageLabel in ipairs(Eye:GetChildren()) do
                if not string.match(Image.Name, Eyes) then
                    Image.Visible = false
                else
                    Image.Visible = true
                    if CharacterSettings:GetAttribute("Energy") < 32 then
                        Image.ImageTransparency = 1
                    elseif CharacterSettings:GetAttribute("Energy") > 32 and CharacterSettings:GetAttribute("Energy") < 70 then
                        Image.ImageTransparency = 0.5
                    elseif CharacterSettings:GetAttribute("Energy") > 70 and CharacterSettings:GetAttribute("Energy") < 101 then
                        Image.ImageTransparency = 0
                    end
                end
            end
        end
    end
    --------------------------------------
    for _, Image : ImageLabel in ipairs(MouthV:GetChildren()) do
        if not string.match(Image.Name, Mouth) or not string.match(Image.Name, MouthSide) then
            Image.Visible = false
        elseif string.match(Image.Name, Mouth) and string.match(Image.Name, MouthSide) then
            Image.Visible = true
        end
    end
end
--------------------------------------
return Expressions

1 Like
#2

When the character resets, all the connections that points to the character will be disconnected.

Probably an easy solution is to remove the script along with the character when it resets and clone it back again.

But I’m not too sure though just test if it works

1 Like
#3

So, like, a script in StarterPlayerScripts that clones the LocalScript into the Character for example?

#4

Did u parent the local script into StarterPlayerScripts?

#5

You should parent it to StarterCharacterScripts

#6

Doesn’t matter whether it’s in StarterCharacterScripts or StarterPlayerScripts, the same bug still occurs. I think it’s a problem with the Module script probably.

#7

You’ve got to update the variables inside the module script with the new character hierarchy. Might sound dumb but the first time you require a module script and it succeeds, is the only time require runs or starts the script inside (module script context isn’t gced, leaving variables to their past.). Meaning each time you respawn, you’ll probably need an expression.setup(yourCharacter) resetting the values on the top of the module script. In that new setup function.

I guess this only applies if you destroy your character and create a new on when the user respawns.

1 Like
#8

I don’t really understand. What would i put in the expression.setup thingy? Do i connect it to a CharacterAdded event or something?

#9

Yeah, precisely. Essentially inside your expression module, you’ll start with:

function Expression.Setup(newChar: Model)
        Character = newChar
        CharacterSettings = Character:WaitForChild("Settings")
        -- // etc redoing all the character specific stuff that's typically done on runtime
end

--inside of your character added connection:
Expression.Setup(char)

This way it’ll refresh those values with your new character that the player just received.

1 Like
#10

I did what you said and yet it doesn’t seem to be working?

--||Services
local Players = game:GetService("Players")
--||Variables
local Player = Players.LocalPlayer
local Character
local CharacterSettings
local EyebrowsV
local EyesV
local MouthV
local MouthSide = ""
--------------------------------------
local Expressions = {}
--||Functions
function Expressions.Setup(NewCharacter: Model)
    Character = NewCharacter
    CharacterSettings = Character:WaitForChild("Settings")
    EyebrowsV = {
        Character:WaitForChild("LeftEyebrow").GUI,
        Character:WaitForChild("RightEyebrow").GUI
    }
    EyesV = {
        Character:WaitForChild("LeftEye").GUI,
        Character:WaitForChild("RightEye").GUI,
        Character:WaitForChild("LeftEye").ChronoGUI,
        Character:WaitForChild("RightEye").ChronoGUI
    }
    MouthV = Character:WaitForChild("Mouth").GUI
end
--------------------------------------
function Expressions:MouthFaceCamera(Root, Camera)
    local ViewDistance = (Root.Position - Camera.CFrame.Position).Unit
    local Dot = ViewDistance:Dot(Root.CFrame.RightVector)
    if Dot > -1 and Dot < 0 then
        MouthSide = "Left"
    elseif Dot < 1 and Dot > 0 then
        MouthSide = "Right"
    end
end
--------------------------------------
function Expressions:Swap(Eyebrows: string, Eyes: string, Mouth: string, Expression: string)
    CharacterSettings:SetAttribute("Expression", Expression)
    --------------------------------------
    for _, Eyebrow : SurfaceGui in ipairs(EyebrowsV) do
        for _, Image : ImageLabel in ipairs(Eyebrow:GetChildren()) do
            if Image.Name ~= Eyebrows then
                Image.Visible = false
            else
                Image.Visible = true
            end
        end
    end
    --------------------------------------
    for _, Eye : SurfaceGui in ipairs(EyesV) do
        if not string.match(Eye.Name, "Chrono") then
            for _, Image : ImageLabel in ipairs(Eye:GetChildren()) do
                if Image.Name ~= Eyes then
                    Image.Visible = false
                else
                    Image.Visible = true
                end
            end
        else
            for _, Image : ImageLabel in ipairs(Eye:GetChildren()) do
                if not string.match(Image.Name, Eyes) then
                    Image.Visible = false
                else
                    Image.Visible = true
                    if CharacterSettings:GetAttribute("Energy") < 32 then
                        Image.ImageTransparency = 1
                    elseif CharacterSettings:GetAttribute("Energy") > 32 and CharacterSettings:GetAttribute("Energy") < 70 then
                        Image.ImageTransparency = 0.5
                    elseif CharacterSettings:GetAttribute("Energy") > 70 and CharacterSettings:GetAttribute("Energy") < 101 then
                        Image.ImageTransparency = 0
                    end
                end
            end
        end
    end
    --------------------------------------
    for _, Image : ImageLabel in ipairs(MouthV:GetChildren()) do
        if not string.match(Image.Name, Mouth) or not string.match(Image.Name, MouthSide) then
            Image.Visible = false
        elseif string.match(Image.Name, Mouth) and string.match(Image.Name, MouthSide) then
            Image.Visible = true
        end
    end
end
--||Connection(s)
Player.CharacterAdded:Connect(function(NewChar: Model)
    Expressions.Setup(NewChar)
end)
--------------------------------------
return Expressions
#11

It could be that the Player’s Character is already added so the CharacterAdded Signal won’t be fired in-time.

Try doing something like this:

--||Connection(s)
if Player.Character then
    Expressions.Setup(Player.Character)
end

Player.CharacterAdded:Connect(function(NewChar: Model)
    Expressions.Setup(NewChar)
end)
--------------------------------------
return Expressions
#12

Still gives the same results sadly.

#13

Is the script in StarterPlayerScripts or did you already try placing it there with the edit i provided?

1 Like
#14

Interesting, and even adding the starting character on load. So it works like how you previously had it or just not at all?

Guess you’ll have to try some debugging, maybe try setting a default expression right after the new character was created and set. Or see if the function is being called. Then double check if the characters are the same from what it is now and what set values are currently.

Lastly, which might sound really dumb, but after your character dies and despawns, see if that original heartbeat is still running. Because if it is some how magically still running, it might be overwriting your new character’s expressions with old character ones.

1 Like
#15

It is in StarterPlayerScripts, i moved it to StarterCharacterScripts and now it works!

#16

Actually, turns out it does work, i just had to put the script in StarterCharacterScripts. Thanks @Kitsomia @ThtRookie !

1 Like