Feedback on Audio Visualiser Script

Help and Feedback Code Review
#1

Hi this is my First Topic so yeah please dont be Annoyed if i don Something Wrong.

Ok So. I’m Making a Audio Visualiser with a Part. But i don’t know if its good enough?
Any Feedback is Appreciated

while true do

wait()

local PlayBackLoudness = game.Workspace.Music_Folder.Music1.PlaybackLoudness

script.Parent.Size = Vector3.new(PlayBackLoudness / 199, PlayBackLoudness / 199, PlayBackLoudness / 199)

end

3 Likes
#2

This all depends on your definition of “good enough”. If it functions and that’s all you want then yeah, it’s good enough.
I would suggest:

  • Clamping the size of the part if you want a minimum size at all times.
  • Define the Sound instance before the loop, not that it’s a major issue but it’s a bit easier on the eyes.
  • Running the effect on the client so you’re able to run it every frame, ensuring the smoothest possible experience for the player.
  • Lerping the size so that sudden changes in the music aren’t as violent/sharp/choppy.

Besides that, it’s decent. At the same time I can’t really provide a good thorough review on it as I don’t know exactly what you’re going for with this, but as far as visualising the loudness of a sound, it works.

1 Like