For loop not changing the value of my value

Help and Feedback Scripting Support
#1

I am trying to make this script give a player a plot for them to build on, but it won’t set the owners value. I have been looking through this code for 10 minutes, and I can’t see the problem.


local plots = script.Parent.Plot
local plot

local function giveplot(plr)
	
	print("PlotGiver fired!")
	
	for i, plot in pairs(plots:GetChildren()) do
		
		print("Looping...")
		
		if plot:WaitForChild("Owner").Value ~= nil then
			
			print("Owner!")
			print(players:FindFirstChild(tostring(plot.Owner.Value)))
		else
			
			print("No owner!")
			
			plot:WaitForChild("Owner").Value = plr
			
			plot = plot
			
			game.ReplicatedStorage.GivenPlot:FireClient(plr, plot)
			
			break
			
		end
		
	end
	
end

players.PlayerAdded:Connect(giveplot)

There’s no error outputted.

1 Like
#2

Have you tried printing the value to make sure it is the desired value?

print(plot:WaitForChild("Owner").Value)
#3

I just tried that, and now I got a output.

“16:55:48.562 - Attempt to connect failed: Passed value is not a function”
Line 36.
AKA player added.

#4

You’re connecting to the function after you call it, remove the set of parentheses calling the function.
( players.PlayerAdded:Connect(giveplot) )

#5

Okay, let me try that. I’ll see if it works.

#6

Only PlotGiver fired is printed.

#8

What do you mean? If he calls the function before :Connecting to it, it’ll Connect the return value of the function, not the function itself.

#10

The script isn’t in plots.

#11

Are there any errors? The issue might be that plots has no children.

#12

It’s gone now.

#13

Can I see your hierarchy? You might be looping through the wrong thing, since that script works for me.

#15

snippet

#16

That looks like mine, it definitely should be printing Looping. Is there anything that could be destroying the Grids? Any other scripts that access them?

#17

No script is destroying it, and it now prints everything.

#18

When you said “not showing the value” do you mean the value never changes or that the client doesn’t ever get the event?

#19

The value never changes.

#21

If there’s no errors, I don’t know why your script doesn’t work. I can run your script and have it work fine, so it’s probably the issue of another script in your game.

#22

I’m back, and I don’t think it is because I have only two scripts in the explorer, and both of them don’t destroy anything.

#23

Edit: didn’t see the picture right :frowning:

I believe the problem here is your checking all the descendants of the plot folder, including those scripts. Since the scripts don’t have an Owner value, it’s infinitely waiting. Try adding: if plot:IsA(“Part”) then, right after your loop starts. Don’t forget to add in another end as well.

#24

The scripts aren’t in the plot folder, look at his hierarchy picture.