Global Leaderboard not working?

FxllenCode · October 25, 2020, 3:44pm

Hello Developers,

Before I start, please note that I want to be explained the answer, not just spoonfed. I want to actually learn from this mistake. Please keep that in mind.

I’ve been working on a Global Leaderboard for my game, K-Pop hangout. After watching a tutorial from @UseCode_Tap, I thought that I understood OrderedDataStores. However, this is the error I keep getting:

I’ve tried a few diffrent solutions with no luck. Here is my code:

DataService

local DataStoreService = game:GetService("DataStoreService")
local WinsLeaderboard = DataStoreService:GetOrderedDataStore("timeDataStore".."-time")

local function updateLeaderboard()
	local success, errorMessage = pcall(function()
		local Data = WinsLeaderboard:GetSortedAsync(false, 5)
		local WinsPage = Data:GetCurrentPage()
		for Rank, data in ipairs(WinsPage) do
			local userName = game.Players:GetNameFromUserIdAsync(tonumber(data.key))
			local Name = userName
			local Time = data.value
			local isOnLeaderboard = false
			for i, v in pairs (game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder:GetChildren()) do
				if v.Player.Text == Name then
					isOnLeaderboard = true
					break
				end
			end
			local userName = Data.key
			print(userName)
			if Time and isOnLeaderboard == false then
				
				local newLbFrame = game.ReplicatedStorage:WaitForChild("LeaderboardFrame"):Clone()
				newLbFrame.Player.Text = Name
				newLbFrame.Time.Text = Time
				newLbFrame.Rank.Text = "#"..Rank
				newLbFrame.Position = UDim2.new(0, 0, newLbFrame.Position.Y.Scale + .08 * #game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder:GetChildren(), 0)
				newLbFrame.Parent = game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder
			end
			
			
		end
		
		
	end)
	
	if not success then
		warn(errorMessage)
	end
	
	
end

while true do
	
	for _, player in pairs (game.Players:GetPlayers()) do
		WinsLeaderboard:SetAsync(player.UserId .. "-time", player.leaderstats.TimePlayed.Value)
	end
	
	for _, frame in pairs (game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder:GetChildren()) do
		frame:Destroy()
	end
	
	updateLeaderboard()
	print("Updated Leaderboard")
	
	

	
	wait(30)
	


	
end

Here is workspace, just in case:

Data saves fine, datastores are seeminly not the issue. I think I might be using OrderedDataStore wrong.

Again, I am a novice scripter, so I would like to be explained the solution, not just spoonfed.

Thank you!

YummyYorkie123 · October 25, 2020, 3:46pm

did you mean to put an = between these? It’s saying there’s a problem with WinsPage in your ipairs loop so this is likely the issue .

FxllenCode · October 25, 2020, 3:47pm

That fixed the original error, now I am getting this:

(Cannot believe I overlooked that!)

YummyYorkie123 · October 25, 2020, 3:50pm

When you click on it, does it redirect you to one of the scripts and the line the error has occurred on? Thank you, that would help

FxllenCode · October 25, 2020, 3:52pm

Line 36 of LeaderboardHandler, specifically:

	if not success then
		warn(errorMessage)
	end

YummyYorkie123 · October 25, 2020, 3:56pm

OK, this may be the line that’s causing the problem - maybe, I’m not an expert at DataStores. Try removing the “-time” bit at the end, I think that if you include that, it’s trying to define a DataStore called “timeDataStore-time”, so this could be the problem that’s then causing it to not work.

FxllenCode · October 25, 2020, 3:57pm

-time is the specific key I am using, it’s better to have one datastore with different keys. (Correct me if I’m wrong about that).

YummyYorkie123 · October 25, 2020, 3:58pm

Another typo? Did you mean game.Workspace.GlobalLeaderboard?

YummyYorkie123 · October 25, 2020, 3:59pm

You’re probably right, I usually make a separate datastore for everything because I’m overly complicating

FxllenCode · October 25, 2020, 4:00pm

Still didn’t fix it, however probably fixed another error somewhere along the lines.

I need to be more careful!

YummyYorkie123 · October 25, 2020, 4:06pm

OK, just been reading through the developer pages on OrderedDataStores.

Here, try it just with:

local userName = data.key
print(userName)

See what it comes up with - if it doesn’t print anything at all, then something before the ipairs loop has gone wrong.

YummyYorkie123 · October 25, 2020, 4:09pm

I’ve also got a feeling there’s something wrong with the ‘Rank’ part, which could relate to that Argument 1 missing/nil error. I’ll have a check through that.

FxllenCode · October 25, 2020, 4:14pm

Your theory was right, nothing printed.

FxllenCode · October 26, 2020, 11:14pm

Update: Still having issues, looked through my code and I cannot figure out why. Help is appreciated.

FxllenCode · November 12, 2020, 12:33am

Updated this post with the new code, still not working.

cc @YummyYorkie123

anthropomorphic_dev · November 12, 2020, 2:13am

Is there Data in the Data store?

FxllenCode · November 12, 2020, 2:13am

Yes. There is data of around 5 people.

anthropomorphic_dev · November 12, 2020, 2:21am

Hmm try setting some different fake users using :SetAsync()

You can remove them later

OrderedDataStore:SetAsync("Jonny", 56)
OrderedDataStore:SetAsync("Mary", 68)
OrderedDataStore:SetAsync("John", 99)

tell me if it works

FxllenCode · November 12, 2020, 2:21am

It doesn’t make a difference. Per the tutorial I used, it should work even with one person.

anthropomorphic_dev · November 12, 2020, 2:41am

Sorry for being late
But im going to test your code to see if it works give me a moment