Global Leaderboard not working?

Help and Feedback Scripting Support
#8

Another typo? Did you mean game.Workspace.GlobalLeaderboard?

2 Likes
#9

You’re probably right, I usually make a separate datastore for everything because I’m :sparkles: overly complicating :sparkles:

1 Like
#10

Still didn’t fix it, however probably fixed another error somewhere along the lines.

I need to be more careful! :man_facepalming:

1 Like
#11

OK, just been reading through the developer pages on OrderedDataStores.

Here, try it just with:

local userName = data.key
print(userName)

See what it comes up with - if it doesn’t print anything at all, then something before the ipairs loop has gone wrong.

2 Likes
#12

I’ve also got a feeling there’s something wrong with the ‘Rank’ part, which could relate to that Argument 1 missing/nil error. I’ll have a check through that.

2 Likes
#13

Your theory was right, nothing printed.

1 Like
#14

Update: Still having issues, looked through my code and I cannot figure out why. Help is appreciated.

1 Like
#15

Updated this post with the new code, still not working.

cc @YummyYorkie123

1 Like
#16

Is there Data in the Data store?

1 Like
#17

Yes. There is data of around 5 people.

1 Like
#18

Hmm try setting some different fake users using :SetAsync()

You can remove them later

OrderedDataStore:SetAsync("Jonny", 56)
OrderedDataStore:SetAsync("Mary", 68)
OrderedDataStore:SetAsync("John", 99)

tell me if it works

1 Like
#19

It doesn’t make a difference. Per the tutorial I used, it should work even with one person.

1 Like
#20

Sorry for being late
But im going to test your code to see if it works give me a moment

2 Likes
#21

Well im getting this error
Argument 1 missing or nil
which leads to

local userName = game.Players:GetNameFromUserIdAsync(tonumber(data.key))

The key is not the UserId of a player as when you set the Data of the player you have player.UserId … “-time” for GetNameFromUserIdAsync() to work it has to be a straight UserId without* anything else

 local userName = Data.key

also make the D in Data lowercase it will error if not also you previously defined the name of the player on the leaderboard so this line of code is unnecessary

Besides these errors this is my output after fixing them

https://gyazo.com/839e87a0003dfa1af7154b72e1671629

2 Likes
#22

I’ll try it tomorrow. Thank you!

1 Like
#23

So I made some changes, making the key only the UserId. Now, I get no errors, but it still doesn’t work. Here is my new code:

local DataStoreService = game:GetService("DataStoreService")
local WinsLeaderboard = DataStoreService:GetOrderedDataStore("timeDataStore".."-time")

local function updateLeaderboard()
	local success, errorMessage = pcall(function()
		local Data = WinsLeaderboard:GetSortedAsync(false, 5)
		local WinsPage = Data:GetCurrentPage()
		for Rank, data in ipairs(WinsPage) do
			local userName = game.Players:GetNameFromUserIdAsync(tonumber(data.key))
			local Name = userName
			local Time = data.value
			local isOnLeaderboard = false
			for i, v in pairs (game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder:GetChildren()) do
				if v.Player.Text == Name then
					isOnLeaderboard = true
					break
				end
			end
		
		
			print(userName)
			if Time and isOnLeaderboard == false then
				
				local newLbFrame = game.ReplicatedStorage:WaitForChild("LeaderboardFrame"):Clone()
				newLbFrame.Player.Text = Name
				newLbFrame.Time.Text = Time
				newLbFrame.Rank.Text = "#"..Rank
				newLbFrame.Position = UDim2.new(0, 0, newLbFrame.Position.Y.Scale + .08 * #game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder:GetChildren(), 0)
				newLbFrame.Parent = game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder
			end
			
		
			
		end
		

		
		
		
		
	end)
	
	
end

while true do
	
	for _, player in pairs (game.Players:GetPlayers()) do
		WinsLeaderboard:SetAsync(player.UserId .. "-time", player.leaderstats.TimePlayed.Value)
	end
	
	for _, frame in pairs (game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder:GetChildren()) do
		frame:Destroy()
	end
	
	updateLeaderboard()
	print("Updated Leaderboard")
	
	

	
	wait(30)
	


	
end
1 Like
#24

Try running it without the pcall. This way, it will show you the error, rather than erring silently (if an error occurs in a pcall, it doesn’t do anything)

What error do you get if you do this?

1 Like
#25

Good idea, trying that quickly.

1 Like
#26

Errors:

image
image3840×2160 1.17 MB

Leads to line 9, and line 56.

1 Like
#27

It may have something to do with this line:

Earlier, some one said to add this code:

This adds values to the stores with strings as their keys, not ints. When it runs, it tries to convert the string to an int but can’t because it’s only letter, so it returns nil (I think). Because of this, the get user from userid function will error because the first argument is nil.

If there is nothing else saved to the data store, you could try changing its name and adding this code:

OrderedDataStore:SetAsync("12344", 56)
OrderedDataStore:SetAsync("54321", 68)
OrderedDataStore:SetAsync("21357", 99)

(Those are just random numbers)

1 Like