Help with adding debounce to spawning cars?

Help and Feedback Scripting Support
#1

Hey guys im not very good at scripting but I was wondering of you could help me add a debounce to this car spawning script?

this is also part of my cash script.

local replicatedStorage = game:GetService("ReplicatedStorage")

local datastore = game:GetService("DataStoreService")

local dsl = datastore:GetDataStore("StageSaveSystem")

game.Players.PlayerAdded:connect(function(plr)

local folder =Instance.new("Folder", plr)

folder.Name = "leaderstats"

local Cash = Instance.new("IntValue", folder)

Cash.Name = "Cash"

Cash.Value = dsl:GetAsync(plr.UserId) or 200

dsl:SetAsync(plr.UserId, Cash.Value)

Cash.Changed:connect(function()

dsl:SetAsync(plr.UserId, Cash.Value)

end)

end)

game.ReplicatedStorage:WaitForChild("CheckPrice").OnServerInvoke = function(player,NameOfCar)

return game.ServerStorage.Cars:FindFirstChild(NameOfCar).Price.Value

end

game.ReplicatedStorage:WaitForChild("SpawnCar").OnServerEvent:connect(function(player,NameOfCar)

local car = game.ServerStorage.Cars:FindFirstChild(NameOfCar):Clone()

car:SetPrimaryPartCFrame(player.Character.HumanoidRootPart.CFrame + Vector3.new(0,0,15))

car.Parent = workspace

car:MakeJoints()

car.Name = player.Name…"'s "…NameOfCar

end)

2 Likes
#3

A Debounce is as simple as

local Debounce = false

Part.Touched:Connect(function()
    if not Debounce then
        Debounce = true
        --code to Fire server
        wait(5) --how long before button can be activated again
        Debounce = false
    end
end)
1 Like
#4 
local replicatedStorage = game:GetService("ReplicatedStorage")
local datastore = game:GetService("DataStoreService")
local dsl = datastore:GetDataStore("StageSaveSystem")

game.Players.PlayerAdded:connect(function(plr)
    local folder =Instance.new("Folder", plr)
    folder.Name = "leaderstats"

    local Cash = Instance.new("IntValue", folder)
    Cash.Name = "Cash"
    Cash.Value = dsl:GetAsync(plr.UserId) or 200

    dsl:SetAsync(plr.UserId, Cash.Value)
    Cash.Changed:connect(function()
        dsl:SetAsync(plr.UserId, Cash.Value)
    end)
end)

game.ReplicatedStorage:WaitForChild("CheckPrice").OnServerInvoke = function(player,NameOfCar)
    return game.ServerStorage.Cars:FindFirstChild(NameOfCar).Price.Value
end

game.ReplicatedStorage:WaitForChild("SpawnCar").OnServerEvent:connect(function(player,NameOfCar)
    local car = game.ServerStorage.Cars:FindFirstChild(NameOfCar):Clone()
    car:SetPrimaryPartCFrame(player.Character.HumanoidRootPart.CFrame + Vector3.new(0,0,15))
    car.Parent = workspace
    car:MakeJoints()
    car.Name = player.Name…"'s "…NameOfCar
end)

I realised that this is the server code. You should put the debounce locally, otherwise the debounce will conflict if two players attempt the same input.

#5

Actually, a good practice is to also add a debounce on the server in case of exploits.

1 Like
#6

how would I do that im not very good at scripting.

#7

That’d be a little tricky, the debounce should be bound to each player then. A table, I assume?

Edit: A guess

local DebounceTable = {}

game:GetService("Players").PlayerAdded:Connect(function(player)
    DebounceTable[player] = {debounce = false}
end)

-- some thing that removes the inserted
1 Like
#8

Exactly!

A table with player names and the time left they have until the server can process their request again.

#9

the main problem is people keep spawning the cars and spam clicking the button which makes the cars spawn inside each other and then it lags the server hard and then cars burst everywhere.

#10

I’m aware of that, and I have provided an example above, which I think should work.

#11

Wouldn’t you want users to only spawn one car? One car per user?

#12

I see that but where do I have to insert that script?

#13

one car yes but thare is different cars with different colors but yes one car of that type per person

#15

On the client, the code that handles the button should have code similar to this

local Debounce = false

Part.Touched:Connect(function()
    if not Debounce then
        Debounce = true
        --code to Fire server
        wait(5) --how long before button can be activated again
        Debounce = false
    end
end)

On the server, the code that spawns the car should have the code similar to what @anon81993163 has posted. This is to ensure that exploiters can’t abuse the car spawner even if the debounce on the client is compromised.

#17

maybe @uJordy because I don’t want them spam clicking it and a debounce would work and maybe destroying the old car?

#18

You need:

  • DebounceTable[player], who triggered it.
  • DebounceTable[player][debounce] if it’s true or false.
local Players = game:GetService("Players")
local replicatedStorage = game:GetService("ReplicatedStorage")
local datastore = game:GetService("DataStoreService")
local dsl = datastore:GetDataStore("StageSaveSystem")
local DebounceTable = {}

Players.PlayerAdded:connect(function(plr)
    DebounceTable[plr] = {debounce = false}
    local folder =Instance.new("Folder", plr)
    folder.Name = "leaderstats"

    local Cash = Instance.new("IntValue", folder)
    Cash.Name = "Cash"
    Cash.Value = dsl:GetAsync(plr.UserId) or 200

    dsl:SetAsync(plr.UserId, Cash.Value)
    Cash.Changed:connect(function()
        dsl:SetAsync(plr.UserId, Cash.Value)
    end)
end)

Players.PlayerRemoving:Connect(function(plr)
    DebounceTable[plr] = nil
end)

replicatedStorage:WaitForChild("CheckPrice").OnServerInvoke = function(player,NameOfCar)
    return game.ServerStorage.Cars:FindFirstChild(NameOfCar).Price.Value
end

replicatedStorage:WaitForChild("SpawnCar").OnServerEvent:connect(function(player,NameOfCar)
    if DebounceTable[player][debounce] then
        return -- if it's true, it won't process the cloning
    end
    DebounceTable[player][debounce] = true

    local car = game.ServerStorage.Cars:FindFirstChild(NameOfCar):Clone()
    car:SetPrimaryPartCFrame(player.Character.HumanoidRootPart.CFrame + Vector3.new(0,0,15))
    car.Parent = workspace
    car:MakeJoints()
    car.Name = player.Name…"'s "…NameOfCar
    wait(5) -- Cooldown
    DebounceTable[player][debounce] = false
end)
#19

so this will add a debounce so they cant spam click the button?

#20

Yes, that’s correct. It will not cause an unnecessary amount of cars spawning in rapid succession.

#21

something happened the … in
car.Name = player.Name…"'s "…NameOfCar

was a error its green and has a red line

and now the script wont work

Screenshot%20(205)
Screenshot%20(205)3840Ă—2160 474 KB

#22

car.Name = player.Name.."s "..NameOfCar

try this

2 Likes
#23

Don’t forget to add pcalls for when you :Set or :Get Async for the datastores.
Also remember to capitalise that c for :connect :wink:.