Help with buy button

itzmerose_12 · December 4, 2021, 9:40am

You can write your topic however you want, but you need to answer these questions:

What do you want to achieve? I want my buy button to work
What is the issue? Even tho i have enough currency, the tool is not getting bought
What solutions have you tried so far? I have learnt more about remote functions, yet it doesn’t work. I also looked up multiple videos

--Server Side
local remotecon = {}

local items = game.ReplicatedStorage.Shared:WaitForChild("Tools")
function remotecon.buy(player,toolName)
	local tool = items:FindFirstChild(toolName)
	if tool ~= nil then
		if not player.Ownedtools:FindFirstChild(toolName) and player.Equipped.Value ~= toolName then
			price = tool.Cost.Value
			--plr dosent have tool
			if player.leaderstats.Coins.Value >= price  then
				
				local newtoolval = Instance.new("StringValue")
				newtoolval.Name = toolName
				newtoolval.Parent = player
				player.Current = toolName
				
				for i,v in pairs(player.Backpack:GetChildren()) do
					if v:IsA("Tool") then
						v:Destroy()
					end
				end
				
				local gear = tool:Clone()
				gear.Parent = player.Backpack
				
				player.leaderstats.Coins.Value = player.leaderstats.Coins.Value - price
				
				return "Yes"
			else 
				return "no"
			end
		elseif player.Ownedtools:FindFirstChild(toolName) and player.Equipped.Value ~= toolName then
			for i,v in pairs(player.Backpack:GetChildren()) do
				if v:IsA("Tool") then
					v:Destroy()
				end
			end

			local gear = tool:Clone()
			gear.Parent = player.Backpack
			
			return "Equipped"
		elseif player.Ownedtools:FindFirstChild(toolName) and player.Equipped.Value == toolName then
			for i,v in pairs(player.Backpack:GetChildren()) do
				if v:IsA("Tool") then
					v:Destroy()
				end
			end

			local gear = tool:Clone()
			gear.Parent = player.Backpack
			return "Equipped"
		end
		
	else
		return "error"
	end
end

game.ReplicatedStorage.Remotes.buytool.OnServerInvoke = function(player,toolName)
	remotecon.buy(player,toolName)
end
return remotecon

--Client side

local shop = script.Parent.tools_gui.tools_frame



for i, item in ipairs(Tools) do
	if item:IsA("Tool") then
		local price = item:FindFirstChild("Cost")
		local img = item:FindFirstChild("ImgID")
		local order = item:FindFirstChild("order")
		
		if price and img and order then
			print(item.Name)
			local temp = temp:Clone()
			temp.Parent = scrollingFrame
			temp.Name = item.Name
			temp.img.Image = img.Value
			local priceval = Instance.new("StringValue")
			priceval.Value = price.Value
			priceval.Parent = temp
			temp.Visible = true
			temp.MouseButton1Click:Connect(function()
				shop.tool_img.Image = img.Value
				selectedtemp = temp
				shop.price.Text = price.Value
				shop.name.Text = item.Name
			end)
		else
			continue
		end
	end
end

if selectedtemp ~= nil then
	
end

shop.canbuy.MouseButton1Click:Connect(function()
	if selectedtemp ~= nil then
		local result = game.ReplicatedStorage.Remotes.buytool:InvokeServer(selectedtemp.Name)
	end
end)

Also it doesn’t show me any errors. Help is appreciated.Thank you!

AntiHack919 · December 4, 2021, 9:43am

First. Check if you’re giving coins to the player locally. If that’s the case, do the money checking on the client side.

Ready2XD · December 4, 2021, 10:29am

--Server Side
local remotecon = {}

local items = game.ReplicatedStorage.Shared:WaitForChild("Tools")
function remotecon.buy(player,toolName)
	local tool = items:FindFirstChild(toolName)
	if tool ~= nil then
		if not player.Ownedtools:FindFirstChild(toolName) and player.Equipped.Value ~= toolName then
			price = tool.Cost.Value
			--plr dosent have tool
			if player.leaderstats.Coins.Value >= price  then
				
				local newtoolval = Instance.new("StringValue")
				newtoolval.Name = toolName
				newtoolval.Parent = player
				player.Current = toolName
				
				for i,v in pairs(player.Backpack:GetChildren()) do
					if v:IsA("Tool") then
						v:Destroy()
					end
				end
				
				local gear = tool:Clone()
				gear.Parent = player.Backpack
				
				player.leaderstats.Coins.Value = player.leaderstats.Coins.Value - price
				
				return "Yes"
			else 
				return "no"
			end
		if player.Ownedtools:FindFirstChild(toolName) and player.Equipped.Value ~= toolName then
			for i,v in pairs(player.Backpack:GetChildren()) do
				if v:IsA("Tool") then
					v:Destroy()
				end
			end

			local gear = tool:Clone()
			gear.Parent = player.Backpack
			
			return "Equipped"
		elseif player.Ownedtools:FindFirstChild(toolName) and player.Equipped.Value == toolName then
			for i,v in pairs(player.Backpack:GetChildren()) do
				if v:IsA("Tool") then
					v:Destroy()
				end
			end

			local gear = tool:Clone()
			gear.Parent = player.Backpack
			return "Equipped"
		end
		
	else
		return "error"
	end
end

game.ReplicatedStorage.Remotes.buytool.OnServerInvoke = function(player,toolName)
	remotecon.buy(player,toolName)
end
return remotecon

Ready2XD · December 4, 2021, 10:32am

I don’t think that it will work but you can try.

daulric · December 4, 2021, 10:38am

use remte event to listen for the client

itzmerose_12 · December 4, 2021, 11:04am

im checking giving coins through the client side only

itzmerose_12 · December 4, 2021, 11:09am

im not trying to do a one-way communication if so then remote event is the option. But i am trying to do two-way communication so im using remote functions.

itzmerose_12 · December 4, 2021, 11:10am

it doesn’t work. it showed me errors but i solved your script. My button still isnt working

Forummer · December 4, 2021, 4:20pm

You should probably add prints to each line to see where it fails.

itzmerose_12 · December 5, 2021, 4:36am

So everything rpints but the client side aint printing, only in this function:

shop.canbuy.MouseButton1Click:Connect(function()
	if selectedtemp ~= nil then
		local result = game.ReplicatedStorage.Remotes.buytool:InvokeServer(selectedtemp.Name)
		print("buying")
	end
end)

Gmorcad12345 · December 5, 2021, 6:22am

No please don’t do that exploiters will just break your game

AntiHack919 · December 5, 2021, 8:04am

They will break your game. Whatever you do.

itzmerose_12 · December 5, 2021, 8:52am

I changed it now, but still my buy button aint working. Any ideas why?

Gmorcad12345 · December 5, 2021, 12:17pm

Try spamming print statements everywhere to see where the script breaks

itzmerose_12 · December 5, 2021, 1:21pm

thats what, this part isn’t getting print:

shop.canbuy.MouseButton1Click:Connect(function()
	if selectedtemp ~= nil then
		local result = game.ReplicatedStorage.Remotes.buytool:InvokeServer(selectedtemp.Name)
		print("buying")
	end
end)

itzmerose_12 · December 7, 2021, 9:17am

i still haven’t figured out. Please help. Thank you.

itzmerose_12 · December 8, 2021, 4:41pm

For reference, i used this video: [FINISHING THE SHOP] How to make a SIMULATOR GAME in ROBLOX STUDIO PART 7! - YouTube

Gmorcad12345 · December 9, 2021, 3:38pm

Can you do print(result) and see if it says nil?

Gmorcad12345 · December 9, 2021, 3:40pm

Try doing shop["tool_img"].Image

Also in this script you gotta spam print statements too. What I’d do is literally do a print() at every line. Could be very tedious but it solved 99% of my problems

itzmerose_12 · December 9, 2021, 4:48pm

it isn’t printing ANYTHING. if u want here is my output tab:

And i did make it print.

Also for reference i watched this video tutorial: [FINISHING THE SHOP] How to make a SIMULATOR GAME in ROBLOX STUDIO PART 7! - YouTube