Help with DataStore2 Global Leaderboard

Help and Feedback Scripting Support
#1

So I made a global leaderboard for kills but now my datastore2 is not working well. I don’t know if I’m doing this right.

local DataStoreService = game:GetService("DataStoreService")
local DataStore = DataStoreService:GetOrderedDataStore("Kills") <---

local gui = script.Parent.Parent
local mainFrame = script.Parent
local List = mainFrame:WaitForChild("List")
local template = script:WaitForChild("Template")

local Board = gui.Parent

local DataStore2 = require(game.ServerScriptService.Saver:WaitForChild("DataStore2"))

local refreashRate = 10 -- seconds
local maxPlayers = 100 -- max players on board

function refreashBoard()
	for i, player in ipairs(game.Players:GetPlayers()) do
		local CurrencyStore = DataStore2("Kills", player) <---
		local value = CurrencyStore:Get()
		if value then
			local newValue = math.round(value * 1000)
			DataStore:SetAsync(player.UserId, newValue)
		else
			repeat task.wait(0.1)
				value = CurrencyStore:Get()
			until value ~= nil
		end
	end
	
	local success, errorMessage = pcall(function()
		local data = DataStore:GetSortedAsync(false, maxPlayers)
		local page = data:GetCurrentPage()
		
		for rank, saveData in ipairs(page) do
			local user = game.Players:GetNameFromUserIdAsync(tonumber(saveData.key))
			local currency = saveData.value
			
			if currency then
				local newTemplate = template:Clone()
				newTemplate.Name = user
				newTemplate.Parent = List
			end
			task.wait(0.1)
		end
	end)
end

refreashBoard()

while task.wait(refreashRate) do
	refreashBoard()
end
#2

What exactly is not working right? Are there any errors or does it not save?

#3

Well, I keep getting errors from other scripts using the same DataStore2.

attempt to compare number <= nil

It think it might be from my global leaderboard because it started happening after I made it.

#4

Can you screenshot full error?

#5

image
image1172×82 5.81 KB

#6

Nothing wrong with the script.

image
image838×283 21.1 KB

#7

Try printing KillsStore:Get().

#8

Prints “0”.

The error occurs only sometimes.

#9

Everything works fine when I disable all the global leaderboard scripts.

#10

In that case, you can put a check to make sure that when you compare KillsStore:Get() and v.Kills KillsStore:Get() is not nil.

for i,v in ipairs(bla bla bla) do
 local killsstoreval = KillsStore:Get()
 if killsstoreval ~= nil then
  if killsstoreval >= v.Kills then
   return v
  end
 end
end

Edit: You also should put the same check for v.Kills, just in case.

#11

Ok but I want to fix whatever is happening with the global leaderboard.

#12

I am not sure what happens here, you will have to debug the entire leaderboard system. Maybe it is not how the global leaderboard works itself, but how other scripts communicate with it.

1 Like