How Can I Improve Scripting With Rarities To Make It More Efficient And Organized

Help and Feedback Code Review
,
#1

I want to improve my scripting with rarities. I need a way to make it more efficient and more Organized.

So The Idea was to make the rarities chances:

  • Common: 50%
  • Uncommon: 25%
  • Rare: 15%
  • Epic: 8.75%
  • Legendary: 1%
  • Mythic: 0.25%

RarityModule.Rarities = {
	["USA"] = {
		Chance = 2733.75,
		Rarity = "Common",
		Color = Color3.fromRGB(168, 168, 168)
	},
	["Canada"] = {
		Chance = 2577.92,
		Rarity = "Common",
		Color = Color3.fromRGB(168, 168, 168)
	},
	["Brazil"] = {
		Chance = 2422.08,
		Rarity = "Common",
		Color = Color3.fromRGB(168, 168, 168)
	},

	["China"] = {
		Chance = 500,
		Rarity = "Uncommon",
		Color = Color3.fromRGB(0, 193, 0)
	},
	["Japan"] = {
		Chance = 418.75,
		Rarity = "Uncommon",
		Color = Color3.fromRGB(0, 193, 0)
	},
	["Germany"] = {
		Chance = 337.5,
		Rarity = "Uncommon",
		Color = Color3.fromRGB(0, 193, 0)
	},
	["France"] = {
		Chance = 256.25,
		Rarity = "Uncommon",
		Color = Color3.fromRGB(0, 193, 0)
	},

	["India"] = {
		Chance = 175,
		Rarity = "Rare",
		Color = Color3.fromRGB(0, 0, 255)
	},
	["Australia"] = {
		Chance = 143.75,
		Rarity = "Rare",
		Color = Color3.fromRGB(0, 0, 255)
	},
	["Mexico"] = {
		Chance = 112.5,
		Rarity = "Rare",
		Color = Color3.fromRGB(0, 0, 255)
	},
	["Russia"] = {
		Chance = 81.25,
		Rarity = "Rare",
		Color = Color3.fromRGB(0, 0, 255)
	},

	["Italy"] = {
		Chance = 50,
		Rarity = "Epic",
		Color = Color3.fromRGB(170, 0, 255)
	},
	["South Korea"] = {
		Chance = 43.75,
		Rarity = "Epic",
		Color = Color3.fromRGB(170, 0, 255)
	},
	["Sweden"] = {
		Chance = 37.5,
		Rarity = "Epic",
		Color = Color3.fromRGB(170, 0, 255)
	},
	["Netherlands"] = {
		Chance = 31.25,
		Rarity = "Epic",
		Color = Color3.fromRGB(170, 0, 255)
	},

	["United Kingdom"] = {
		Chance = 25,
		Rarity = "Legendary",
		Color = Color3.fromRGB(255, 170, 0)
	},
	["Spain"] = {
		Chance = 20,
		Rarity = "Legendary",
		Color = Color3.fromRGB(255, 170, 0)
	},
	["Egypt"] = {
		Chance = 15,
		Rarity = "Legendary",
		Color = Color3.fromRGB(255, 170, 0)
	},
	["South Africa"] = {
		Chance = 10,
		Rarity = "Legendary",
		Color = Color3.fromRGB(255, 170, 0)
	},
	["Argentina"] = {
		Chance = 5,
		Rarity = "Legendary",
		Color = Color3.fromRGB(255, 170, 0)
	},

	["Greece"] = {
		Chance = 2.5,
		Rarity = "Mythic",
		Color = Color3.fromRGB(153, 0, 0)
	},
	["Finland"] = {
		Chance = 1.25,
		Rarity = "Mythic",
		Color = Color3.fromRGB(153, 0, 0)
	},
}

RarityModule.ChooseRarity = function()
	local Randomnumber = math.random(1, 10000) -- Use the total weight range
	local Counter = 0

	for rarity, weight in pairs(RarityModule.Rarities) do
		Counter += weight.Chance
		if Randomnumber <= Counter then
			return rarity, print(rarity, weight.Rarity), print(weight)
		end
	end
end

return RarityModule
#2

I don’t know why would you want to do it, if you don’t use your code every frame (which is very unlikely) efficiency doesn’t matter, some areas of scripting like initialization or very rare/almost non existant scenarios shall not be optimized, it’s a waste of time

If you want your code more organized, you can soft-code maximum range and turn some of if statements into guard clausses to reduce nesting, you can also not use print in normal game because it’s useless if you don’t debug your game

Another thing is that your naming in for loop is kindof incorrect, you loop not through rarity and weight but rather through Country and It’s data

Example:

--/ Functions
function RarityModule.randomCountry()
    local RandomNumber = math.random(1, RarityModule.TotalWeightRange)
    local Counter = 0
    
    for Country, Data in RarityModule.Countries do
        Counter += Data.Chance
        if RandomNumber > Counter then continue end
        
        return Country
    end
end