How can I keep my data from updating if the pcall function fails?
local _DATASTORE_SEVER = game:GetService("DataStoreService"):GetDataStore("____SEERRRVVVEEREEEERR_DDDAAAATTTTAAAAAAA_______")
for i = 1, 5 do
task.wait(2)
local Save__DATA, _message = pcall(function()
_DATASTORE_SEVER:SetAsync("TEST", math.random(1,15))
game.Workspaaaceee = 3 --ERROR (on purpose.)
--Keep the data from saving due to this error.
end)
if Save__DATA == true then
print("Saved", i)
else
warn(_message)
end
print(_DATASTORE_SEVER:GetAsync("TEST"))
end
I think you would have to unsave your data if it errors. Because after it saves it’s saved. Other options might be keeping the previous save in the data store like having 2 saves.
I think it is actually being saved. I’m like 80% sure it is saving the data and then erroring AFTERWARDS thus returning where it errored… if that makes sense.
The data is in the process of saving, but then the error is called when there are too many Data Requests sent. When too much Requests are sent, the data fails to save before it finishes.
In other words, you’re gonna have to fix the error. I don’t think its possible to save the data after the error is called.
local _DATASTORE_SEVER = game:GetService("DataStoreService"):GetDataStore("____SEERRRVVVEEREEEERR_DDDAAAATTTTAAAAAAA_______")
for i = 1, 5 do
task.wait(2)
local Save__DATA, _message = pcall(function()
coroutine.wrap(function()
_DATASTORE_SEVER:SetAsync("TEST", math.random(1,15))
end)
game.Workspaaaceee = 3 --ERROR (on purpose.)
--Keep the data from saving due to this error.
end)
if Save__DATA == true then
print("Saved", i)
else
warn(_message)
end
print(_DATASTORE_SEVER:GetAsync("TEST"))
end
local _DATASTORE_SEVER = game:GetService("DataStoreService"):GetDataStore("____SEERRRVVVEEREEEERR_DDDAAAATTTTAAAAAAA_______")
for i = 1, 5 do
task.wait(2)
local Save__DATA, _message = pcall(function()
local save = coroutine.wrap(function()
_DATASTORE_SEVER:SetAsync("TEST", math.random(1,15))
end)
save()
game.Workspaaaceee = 3 --ERROR (on purpose.)
--Keep the data from saving due to this error.
end)
if Save__DATA == true then
print("Saved", i)
else
warn(_message)
end
print(_DATASTORE_SEVER:GetAsync("TEST"))
end
The pcall means at all a “protected call”, it lets you run a task that can have a success or you can catch an error within, if the function errors, what do you expect? It won’t save.
In addition to the stated above, you may be doing something else wrong if you got rid of the error and still got no data change at all.
Also, it doesn’t make sense you’re doing this within a loop, this is why it sends the request to the queue, because you’re sending too many of them. Break the loop once it is saved.
This is happening because the error happens after the saving. the :SetAsync() call succeeds THEN the pcall errors.
To simulate a failing call, you could move the error to before the SetAsync. (By the way, try using the builtin error() function instead.
But besides all of this, SetAsync has been prone to data loss because it has no handling, so if you pass in nil, it just completely clears the player’s data. I’d recommend using some of the many, many datastore modules that take care of the messy saving process automatically (I use ProfileService, because it’s super good at preventing data loss and easy to use once you understand it).
Well you see, I wanted to originally use profileService for this but I couldn’t figure out how to save data on my game/server (NOT FOR THE PLAYER) AND update / send updates across servers without profile service automatically releasing my data and not holding onto my data when I need too. IF you’d like to help me out with that then yes, pls dm me.
local _DATASTORE_SEVER = game:GetService("DataStoreService"):GetDataStore("____SEERRRVVVEEREEEERR_DDDAAAATTTTAAAAAAA_______")
for i = 1, 5 do
task.wait(5)
coroutine.wrap(function()
local Save__DATA, _message
Save__DATA, _message = pcall(function()
_DATASTORE_SEVER:SetAsync("TEST", math.random(1,15))
game.Workspaaaceee = 3 --the script will stop running because of this error
end)
if Save__DATA == true then
print("Saved", i)
else
warn(_message)
end
print(_DATASTORE_SEVER:GetAsync("TEST"))
end)
end
local _DATASTORE_SEVER = game:GetService("DataStoreService"):GetDataStore("____SEERRRVVVEEREEEERR_DDDAAAATTTTAAAAAAA_______")
for i = 1, 5 do
print(1)
task.wait(60)
local save = coroutine.wrap(function()
print(2)
local Save__DATA, _message
Save__DATA, _message = pcall(function()
_DATASTORE_SEVER:SetAsync("TEST", math.random(1,15))
game.Workspaaaceee = 3 --the script will stop running because of this error
end)
if Save__DATA == true then
print("Saved", i)
else
warn(_message)
end
print(_DATASTORE_SEVER:GetAsync("TEST"))
end)
save()
end
Sorry if I didn’t understand it at all, but from the very first start, why would your pcall fail? You should only be trying to save data within, if the request fails, then the save isn’t performed.
Example:
local function func(oldValue)
return ... -- new value to save
end
local success, name, keyInfo = pcall(function()
return GlobalDataStore:UpdateAsync(key, func)
end)
if not success then
warn("Something went wrong!")
else
print("Version: " .. keyInfo.Version)
end
Nothing more, nothing less. The saving of it shouldn’t be interfered or enclosed with anything else, not recommended.
