How Can I Make Sword Killzone?

WesGhosts · June 7, 2019, 2:38pm

So I am working on a sword fighting game with my friend, I am trying to setup the sword where only standing on certain parts, players can kill each other. But when they are off the part they cannot kill anyone until they are back on that part just like in StickMasterLuke’s game Fencing. How am I able to do this?

ok_wannabe · June 7, 2019, 2:50pm

This surely isn’t the most efficient way to do it, but this is what I would do:

Make a function that runs when the part is touched, using .Touched, and then create a value in the player’s character, named something like “IsFighting”. Inside the .Touched function add a .TouchedEnded function. Inside the .TouchEnded remove the “IsFighting” value from the character.

In the sword script, check if the player’s character has the “IsFighting” value in it. If so, allow them to kill the player.

Here’s some code:

--Inside the certain part
script.Parent.Touched:Connect(function(Hit)
    if Hit.Parent:FindFirstChild("Humanoid") and not Hit.Parent:FindFirstChild("IsFighting") then
        local IsFighting = Instance.new("IntValue")
        IsFighting.Name = "IsFighting"
        IsFighting.Parent = Hit.Parent

        script.Parent.TouchEnded:Connect(function()
            IsFighting:Remove()
        end)
    end
end)

--Add an 'if' statement in the sword script
if Character:FindFirstChild("IsFighting") then
    --However the sword damages the player
end

WesGhosts · June 7, 2019, 2:58pm

I’m still new at LUA and I am having issues trying to figure this out a bit.

ok_wannabe · June 7, 2019, 2:59pm

Did you try the method I suggested?
Or troubles with what the code is doing?

WesGhosts · June 7, 2019, 3:03pm

So I tried putting the script in a part but then the line “Character” is underlined in red when its in the part.

ok_wannabe · June 7, 2019, 3:05pm

The line “Character” in the sword script? If so, I’m sorry I didn’t clarify. I meant that to be however the character is defined in the sword script. If you’re not sure what it’s defined as, could you post the sword script?

WesGhosts · June 7, 2019, 3:08pm

Oh it goes in the sword, I put it in the part.

WesGhosts · June 7, 2019, 3:09pm

Do I have to make a IsFighting IntValue in the parts or no?

ok_wannabe · June 7, 2019, 3:11pm

You only need to make an IsFighting value inside the character model
.

WesGhosts · June 7, 2019, 3:12pm

Where would I find the character model?

ok_wannabe · June 7, 2019, 3:13pm

The script will make the IsFighting value for you

WesGhosts · June 7, 2019, 3:13pm

Ok and I just tested it out but I still died.

ok_wannabe · June 7, 2019, 3:14pm

Did you add the if statement to the sword script, and replace ‘Character’ with however the character is defined?

WesGhosts · June 7, 2019, 3:15pm

I had the script in a part not the sword, so character is no longer underlined in red.

ok_wannabe · June 7, 2019, 3:17pm

I’m sorry my post wasn’t very clear.

Put this script in the killzone part:

script.Parent.Touched:Connect(function(Hit)
    if Hit.Parent:FindFirstChild("Humanoid") and not Hit.Parent:FindFirstChild("IsFighting") then
        local IsFighting = Instance.new("IntValue")
        IsFighting.Name = "IsFighting"
        IsFighting.Parent = Hit.Parent

        script.Parent.TouchEnded:Connect(function()
            IsFighting:Remove()
        end)
    end
end)

And could you post the sword script?

WesGhosts · June 7, 2019, 3:19pm

Here’s the sword script

--EUROCOW WAS HERE BECAUSE I MADE THE PARTICLES AND THEREFORE THIS ENTIRE SWORD PRETTY AND LOOK PRETTY WORDS AND I'D LIKE TO DEDICATE THIS TO MY FRIENDS AND HI LUCKYMAXER PLS FIX SFOTH SWORDS TY LOVE Y'ALl
--Updated for R15 avatars by StarWars
--Re-updated by TakeoHonorable

Tool = script.Parent
Handle = Tool:WaitForChild("Handle")

function Create(ty)
	return function(data)
		local obj = Instance.new(ty)
		for k, v in pairs(data) do
			if type(k) == 'number' then
				v.Parent = obj
			else
				obj[k] = v
			end
		end
		return obj
	end
end

local BaseUrl = "rbxassetid://"

Players = game:GetService("Players")
Debris = game:GetService("Debris")
RunService = game:GetService("RunService")

DamageValues = {
	BaseDamage = 5,
	SlashDamage = 10,
	LungeDamage = 30
}

--For R15 avatars
Animations = {
	R15Slash = 522635514,
	R15Lunge = 522638767
}

Damage = DamageValues.BaseDamage

Grips = {
	Up = CFrame.new(0, 0, -1.70000005, 0, 0, 1, 1, 0, 0, 0, 1, 0),
	Out = CFrame.new(0, 0, -1.70000005, 0, 1, 0, 1, -0, 0, 0, 0, -1)
}

Sounds = {
	Slash = Handle:WaitForChild("SwordSlash"),
	Lunge = Handle:WaitForChild("SwordLunge"),
	Unsheath = Handle:WaitForChild("Unsheath")
}

ToolEquipped = false

--For Omega Rainbow Katana thumbnail to display a lot of particles.
for i, v in pairs(Handle:GetChildren()) do
	if v:IsA("ParticleEmitter") then
		v.Rate = 20
	end
end

Tool.Grip = Grips.Up
Tool.Enabled = true

function IsTeamMate(Player1, Player2)
	return (Player1 and Player2 and not Player1.Neutral and not Player2.Neutral and Player1.TeamColor == Player2.TeamColor)
end

function TagHumanoid(humanoid, player)
	local Creator_Tag = Instance.new("ObjectValue")
	Creator_Tag.Name = "creator"
	Creator_Tag.Value = player
	Debris:AddItem(Creator_Tag, 2)
	Creator_Tag.Parent = humanoid
end

function UntagHumanoid(humanoid)
	for i, v in pairs(humanoid:GetChildren()) do
		if v:IsA("ObjectValue") and v.Name == "creator" then
			v:Destroy()
		end
	end
end

function Blow(Hit)
	if not Hit or not Hit.Parent or not CheckIfAlive() or not ToolEquipped then
		return
	end
	local RightArm = Character:FindFirstChild("Right Arm") or Character:FindFirstChild("RightHand")
	if not RightArm then
		return
	end
	local RightGrip = RightArm:FindFirstChild("RightGrip")
	if not RightGrip or (RightGrip.Part0 ~= Handle and RightGrip.Part1 ~= Handle) then
		return
	end
	local character = Hit.Parent
	if character == Character then
		return
	end
	local humanoid = character:FindFirstChildOfClass("Humanoid")
	if not humanoid or humanoid.Health == 0 then
		return
	end
	local player = Players:GetPlayerFromCharacter(character)
	if player and (player == Player or IsTeamMate(Player, player)) then
		return
	end
	UntagHumanoid(humanoid)
	TagHumanoid(humanoid, Player)
	humanoid:TakeDamage(Damage)	
end


function Attack()
	Damage = DamageValues.SlashDamage
	Sounds.Slash:Play()

	if Humanoid then
		if Humanoid.RigType == Enum.HumanoidRigType.R6 then
			local Anim = Instance.new("StringValue")
			Anim.Name = "toolanim"
			Anim.Value = "Slash"
			Anim.Parent = Tool
		elseif Humanoid.RigType == Enum.HumanoidRigType.R15 then
			local Anim = Tool:FindFirstChild("R15Slash")
			if Anim then
				local Track = Humanoid:LoadAnimation(Anim)
				Track:Play(0)
			end
		end
	end	
end

function Lunge()
	Damage = DamageValues.LungeDamage

	Sounds.Lunge:Play()
	
	if Humanoid then
		if Humanoid.RigType == Enum.HumanoidRigType.R6 then
			local Anim = Instance.new("StringValue")
			Anim.Name = "toolanim"
			Anim.Value = "Lunge"
			Anim.Parent = Tool
		elseif Humanoid.RigType == Enum.HumanoidRigType.R15 then
			local Anim = Tool:FindFirstChild("R15Lunge")
			if Anim then
				local Track = Humanoid:LoadAnimation(Anim)
				Track:Play(0)
			end
		end
	end	
	--[[
	if CheckIfAlive() then
		local Force = Instance.new("BodyVelocity")
		Force.velocity = Vector3.new(0, 10, 0) 
		Force.maxForce = Vector3.new(0, 4000, 0)
		Debris:AddItem(Force, 0.4)
		Force.Parent = Torso
	end
	]]
	
	wait(0.2)
	Tool.Grip = Grips.Out
	wait(0.6)
	Tool.Grip = Grips.Up

	Damage = DamageValues.SlashDamage
end

Tool.Enabled = true
LastAttack = 0

function Activated()
	if not Tool.Enabled or not ToolEquipped or not CheckIfAlive() then
		return
	end
	Tool.Enabled = false
	local Tick = RunService.Stepped:wait()
	if (Tick - LastAttack < 0.2) then
		Lunge()
	else
		Attack()
	end
	LastAttack = Tick
	--wait(0.5)
	Damage = DamageValues.BaseDamage
	local SlashAnim = (Tool:FindFirstChild("R15Slash") or Create("Animation"){
		Name = "R15Slash",
		AnimationId = BaseUrl .. Animations.R15Slash,
		Parent = Tool
	})
	
	local LungeAnim = (Tool:FindFirstChild("R15Lunge") or Create("Animation"){
		Name = "R15Lunge",
		AnimationId = BaseUrl .. Animations.R15Lunge,
		Parent = Tool
	})
	Tool.Enabled = true
end

function CheckIfAlive()
	return (((Player and Player.Parent and Character and Character.Parent and Humanoid and Humanoid.Parent and Humanoid.Health > 0 and Torso and Torso.Parent) and true) or false)
end

function Equipped()
	Character = Tool.Parent
	Player = Players:GetPlayerFromCharacter(Character)
	Humanoid = Character:FindFirstChildOfClass("Humanoid")
	Torso = Character:FindFirstChild("Torso") or Character:FindFirstChild("HumanoidRootPart")
	if not CheckIfAlive() then
		return
	end
	ToolEquipped = true
	Sounds.Unsheath:Play()
end

function Unequipped()
	Tool.Grip = Grips.Up
	ToolEquipped = false
end

Tool.Activated:Connect(Activated)
Tool.Equipped:Connect(Equipped)
Tool.Unequipped:Connect(Unequipped)

Connection = Handle.Touched:Connect(Blow)```

1waffle1 · June 7, 2019, 3:21pm

Just pointing out that this TouchEnded connection never goes away, and more connections will be created on top of it and run at the same time. Not disconnecting it creates a memory leak. Just using script.Parent.TouchEnded:Wait() would be a clean way to solve this.

WesGhosts · June 7, 2019, 3:23pm

I just tried and now my sword will not slash or lunge.

ok_wannabe · June 7, 2019, 3:24pm

In the Blow() funciton, change

humanoid:TakeDamage(Damage)

to

if not humanoid.Parent:FindFirstChild("IsFighting") then
    humanoid:TakeDamage(Damage)
end

ok_wannabe · June 7, 2019, 3:24pm

What can happen if there is a memory leak? Also, is there an alternative to my method?