How Can I Make Sword Killzone?

ok_wannabe · June 7, 2019, 3:24pm

In the Blow() funciton, change

humanoid:TakeDamage(Damage)

to

if not humanoid.Parent:FindFirstChild("IsFighting") then
    humanoid:TakeDamage(Damage)
end

ok_wannabe · June 7, 2019, 3:24pm

What can happen if there is a memory leak? Also, is there an alternative to my method?

NokaAngel · June 7, 2019, 3:29pm

Still not even taking damage, lunging or slashing, & no audio is coming out of the sword.

ok_wannabe · June 7, 2019, 3:29pm

Are there any errors in the code?

NokaAngel · June 7, 2019, 3:31pm

I don’t see any errors showing up even in the developer console.

ok_wannabe · June 7, 2019, 3:32pm

Did you edit anything other than the humanoid:TakeDamage(Damage) part?

NokaAngel · June 7, 2019, 3:33pm

I added this into it

if not humanoid.Parent:FindFirstChild("IsFighting") then
    humanoid:TakeDamage(Damage)
end```

ok_wannabe · June 7, 2019, 3:34pm

Could you post the whole script again? (sorry this is taking so long, lol)

NokaAngel · June 7, 2019, 3:35pm

if Character:FindFirstChild("IsFighting") then
end

--Rescripted by Luckymaxer
--EUROCOW WAS HERE BECAUSE I MADE THE PARTICLES AND THEREFORE THIS ENTIRE SWORD PRETTY AND LOOK PRETTY WORDS AND I'D LIKE TO DEDICATE THIS TO MY FRIENDS AND HI LUCKYMAXER PLS FIX SFOTH SWORDS TY LOVE Y'ALl
--Updated for R15 avatars by StarWars
--Re-updated by TakeoHonorable

Tool = script.Parent
Handle = Tool:WaitForChild("Handle")

function Create(ty)
	return function(data)
		local obj = Instance.new(ty)
		for k, v in pairs(data) do
			if type(k) == 'number' then
				v.Parent = obj
			else
				obj[k] = v
			end
		end
		return obj
	end
end

local BaseUrl = "rbxassetid://"

Players = game:GetService("Players")
Debris = game:GetService("Debris")
RunService = game:GetService("RunService")

DamageValues = {
	BaseDamage = 0,
	SlashDamage = 10,
	LungeDamage = 30
}

--For R15 avatars
Animations = {
	R15Slash = 522635514,
	R15Lunge = 522638767
}

Damage = DamageValues.BaseDamage

Grips = {
	Up = CFrame.new(0, 0, -1.70000005, 0, 0, 1, 1, 0, 0, 0, 1, 0),
	Out = CFrame.new(0, 0, -1.70000005, 0, 1, 0, 1, -0, 0, 0, 0, -1)
}

Sounds = {
	Slash = Handle:WaitForChild("SwordSlash"),
	Lunge = Handle:WaitForChild("SwordLunge"),
	Unsheath = Handle:WaitForChild("Unsheath")
}

ToolEquipped = false

--For Omega Rainbow Katana thumbnail to display a lot of particles.
for i, v in pairs(Handle:GetChildren()) do
	if v:IsA("ParticleEmitter") then
		v.Rate = 20
	end
end

Tool.Grip = Grips.Up
Tool.Enabled = true

function IsTeamMate(Player1, Player2)
	return (Player1 and Player2 and not Player1.Neutral and not Player2.Neutral and Player1.TeamColor == Player2.TeamColor)
end

function TagHumanoid(humanoid, player)
	local Creator_Tag = Instance.new("ObjectValue")
	Creator_Tag.Name = "creator"
	Creator_Tag.Value = player
	Debris:AddItem(Creator_Tag, 2)
	Creator_Tag.Parent = humanoid
end

function UntagHumanoid(humanoid)
	for i, v in pairs(humanoid:GetChildren()) do
		if v:IsA("ObjectValue") and v.Name == "creator" then
			v:Destroy()
		end
	end
end

function Blow(Hit)
	if not Hit or not Hit.Parent or not CheckIfAlive() or not ToolEquipped then
		return
	end
	local RightArm = Character:FindFirstChild("Right Arm") or Character:FindFirstChild("RightHand")
	if not RightArm then
		return
	end
	local RightGrip = RightArm:FindFirstChild("RightGrip")
	if not RightGrip or (RightGrip.Part0 ~= Handle and RightGrip.Part1 ~= Handle) then
		return
	end
	local character = Hit.Parent
	if character == Character then
		return
	end
	local humanoid = character:FindFirstChildOfClass("Humanoid")
	if not humanoid or humanoid.Health == 0 then
		return
	end
	local player = Players:GetPlayerFromCharacter(character)
	if player and (player == Player or IsTeamMate(Player, player)) then
		return
	end
	UntagHumanoid(humanoid)
	TagHumanoid(humanoid, Player)
	if not humanoid.Parent:FindFirstChild("IsFighting") then
    humanoid:TakeDamage(Damage)
end	
end


function Attack()
	Damage = DamageValues.SlashDamage
	Sounds.Slash:Play()

	if Humanoid then
		if Humanoid.RigType == Enum.HumanoidRigType.R6 then
			local Anim = Instance.new("StringValue")
			Anim.Name = "toolanim"
			Anim.Value = "Slash"
			Anim.Parent = Tool
		elseif Humanoid.RigType == Enum.HumanoidRigType.R15 then
			local Anim = Tool:FindFirstChild("R15Slash")
			if Anim then
				local Track = Humanoid:LoadAnimation(Anim)
				Track:Play(0)
			end
		end
	end	
end

function Lunge()
	Damage = DamageValues.LungeDamage

	Sounds.Lunge:Play()
	
	if Humanoid then
		if Humanoid.RigType == Enum.HumanoidRigType.R6 then
			local Anim = Instance.new("StringValue")
			Anim.Name = "toolanim"
			Anim.Value = "Lunge"
			Anim.Parent = Tool
		elseif Humanoid.RigType == Enum.HumanoidRigType.R15 then
			local Anim = Tool:FindFirstChild("R15Lunge")
			if Anim then
				local Track = Humanoid:LoadAnimation(Anim)
				Track:Play(0)
			end
		end
	end	
	--[[
	if CheckIfAlive() then
		local Force = Instance.new("BodyVelocity")
		Force.velocity = Vector3.new(0, 10, 0) 
		Force.maxForce = Vector3.new(0, 4000, 0)
		Debris:AddItem(Force, 0.4)
		Force.Parent = Torso
	end
	]]
	
	wait(0.2)
	Tool.Grip = Grips.Out
	wait(0.6)
	Tool.Grip = Grips.Up

	Damage = DamageValues.SlashDamage
end

Tool.Enabled = true
LastAttack = 0

function Activated()
	if not Tool.Enabled or not ToolEquipped or not CheckIfAlive() then
		return
	end
	Tool.Enabled = false
	local Tick = RunService.Stepped:wait()
	if (Tick - LastAttack < 0.2) then
		Lunge()
	else
		Attack()
	end
	LastAttack = Tick
	--wait(0.5)
	Damage = DamageValues.BaseDamage
	local SlashAnim = (Tool:FindFirstChild("R15Slash") or Create("Animation"){
		Name = "R15Slash",
		AnimationId = BaseUrl .. Animations.R15Slash,
		Parent = Tool
	})
	
	local LungeAnim = (Tool:FindFirstChild("R15Lunge") or Create("Animation"){
		Name = "R15Lunge",
		AnimationId = BaseUrl .. Animations.R15Lunge,
		Parent = Tool
	})
	Tool.Enabled = true
end

function CheckIfAlive()
	return (((Player and Player.Parent and Character and Character.Parent and Humanoid and Humanoid.Parent and Humanoid.Health > 0 and Torso and Torso.Parent) and true) or false)
end

function Equipped()
	Character = Tool.Parent
	Player = Players:GetPlayerFromCharacter(Character)
	Humanoid = Character:FindFirstChildOfClass("Humanoid")
	Torso = Character:FindFirstChild("Torso") or Character:FindFirstChild("HumanoidRootPart")
	if not CheckIfAlive() then
		return
	end
	ToolEquipped = true
	Sounds.Unsheath:Play()
end

function Unequipped()
	Tool.Grip = Grips.Up
	ToolEquipped = false
end

Tool.Activated:Connect(Activated)
Tool.Equipped:Connect(Equipped)
Tool.Unequipped:Connect(Unequipped)

Connection = Handle.Touched:Connect(Blow)```

ok_wannabe · June 7, 2019, 3:38pm

I think I know the problem…
Replace

if not humanoid.Parent:FindFirstChild("IsFighting") then

with

if humanoid.Parent:FindFirstChild("IsFighting") then

1waffle1 · June 7, 2019, 3:44pm

A memory leak is when you’re wasting space storing things you don’t need anymore. In this case, it’s the function call that just removes an object. You can replace this

script.Parent.TouchEnded:Connect(function()
	IsFighting:Remove()
end)

with this

local touchEndedConnection;
touchEndedConnection = script.Parent.TouchEnded:Connect(function()
	touchEndedConnection:Disconnect()
	IsFighting:Destroy()
end)

or this, which yields, but that doesn’t matter here because nothing else happens afterwards

script.Parent.TouchEnded:Wait()
IsFighting:Destroy()

NokaAngel · June 7, 2019, 3:46pm

It is still not working it keeps doing the same thing.

ok_wannabe · June 7, 2019, 3:48pm

Was the sword working in the first place? The code I said to add shouldn’t have changed anything other than the humanoid taking damage

NokaAngel · June 7, 2019, 3:49pm

If we never added anything it worked fine.

NokaAngel · June 7, 2019, 3:53pm

I’m gonna grab a different sword see if that does anything.

ThatTimothy · June 7, 2019, 5:46pm

Just check if the humanoid root part’s x and z positions are within the x and z boundaries of the part. That would make the solution quite easy.

Mr_Code · June 7, 2019, 7:18pm

Nice brief explanation of the memory leak and how to fix it.

This is a great opportunity though to also highlight the other line you switched, changing IsFighting:Remove() to IsFighting:Destroy(). There’s no instance that you should be using :remove() over :destroy(). When you remove an object it’s the same as setting the parent to nil and the object sticks around. When you destroy an object, you ensure that it’ll garbage collect nicely.

In this case the difference probably wouldn’t have been too great, but :destroy() is a good thing to get in the habit of!

Here’s a useful thread going into far greater detail on memory leaks for those interested.

Blend_it · June 8, 2019, 3:26am

Wouldn’t you be able to use Region3 for this?

NokaAngel · June 8, 2019, 4:01am

So I have never gotten it to work. Any other ideas?

emperormicah · June 8, 2019, 4:44am

I think it would be a lot easier and maybe cheaper to check if a player’s character is within bounds of a certain region/part everytime you deal damage than setup collision detection events.

You can read the x/z positions of the characters HumanoidRootPart and compare if they are less or more than the minimum/maximum bounds of the area where you want to allow damaging.

(pretty much what REALTimothy0812 said)