Hi there!
Back at it again with some more outstanding issues (woohoo)
I have a problem with my VFX script. I have been working on it with some great folks over this topic and a great problem has spawned. For some reason, my script is REALLY lagging the game when I run. I’m not sure why. Here’s footage of it in action.
Here are the scripts in question:
OnAction located in StarterPlayerScripts
local player = game:GetService("Players").LocalPlayer
local char = player.Character or player.CharacterAdded:Wait()
local humanoid = char:WaitForChild("Humanoid")
local hrp = char:WaitForChild("HumanoidRootPart")
local root = char:WaitForChild("HumanoidRootPart")
local fallDistance
local VFXController = require(game:GetService("ReplicatedFirst").Modules.VFXController)
if humanoid and root then
local headHeight
humanoid.FreeFalling:Connect(function(state)
if state then
headHeight = root.Position.Y
elseif not state and headHeight ~= nil then
fallDistance = headHeight - root.Position.Y
--print("Fall distance: " .. fallDistance)
end
end)
end
humanoid.StateChanged:Connect(function(old, new)
if old == Enum.HumanoidStateType.Freefall and new == Enum.HumanoidStateType.Landed and fallDistance >= 22 then
local animation = script.Parent:WaitForChild("Animate").land.landAnim
local dance = humanoid:LoadAnimation(animation)
dance:Play()
VFXController.Action("Stomp", false)
task.wait(0.2)
end
end)
local isIdle = false
local db = true
game:GetService("RunService").RenderStepped:Connect(function()
while humanoid.MoveDirection.Magnitude > 0 and humanoid.FloorMaterial ~= Enum.Material.Air do
print(humanoid.FloorMaterial)
print("Person is running")
VFXController.Action("Run", true)
task.wait(0.2)
end
end)
VFXController (ModuleScript in ReplicatedFirst)
local VFX = {}
-- Variables
local ReplicatedStorage = game:GetService("ReplicatedStorage")
local TweenService = game:GetService("TweenService")
local Player = game.Players.LocalPlayer
local Effects = ReplicatedStorage.VFX.Effects
local Actions = ReplicatedStorage.VFX.Actions
local UserRunning = false
-- Functions
-- When user stomps it activates the VFX related to it
local function Stomp()
local VFXFolder = Actions.Stomp
local InitialSize = Vector3.new(0.15, 1, 2.309)
for _, VFXContent in pairs(VFXFolder:GetChildren()) do
if VFXContent:isA("Model") and VFXContent.Name == "Triangles" then
local SparkEffect = Effects.Spark:Clone()
SparkEffect.Parent = Player.Character:WaitForChild("Torso")
local ModelClone = VFXContent:Clone()
ModelClone.Parent = workspace
ModelClone:MoveTo(Vector3.new(Player.Character:WaitForChild("Torso").Position.X, Player.Character:WaitForChild("Torso").Position.Y - 7, Player.Character:WaitForChild("Torso").Position.Z))
for _, VFXDescendant in pairs(ModelClone:GetChildren()) do
VFXDescendant.Size = InitialSize
local RandomSize = math.random(4, 8)
local ShowTween = TweenService:Create(VFXDescendant, TweenInfo.new(0.2, Enum.EasingStyle.Quint, Enum.EasingDirection.InOut), {Size = Vector3.new(VFXDescendant.Size.X, RandomSize, VFXDescendant.Size.Z)})
ShowTween:Play()
SparkEffect.Enabled = true
end
task.wait(0.2)
for _, VFXDescendants in pairs(ModelClone:GetChildren()) do
local HideTween = TweenService:Create(VFXDescendants, TweenInfo.new(0.1, Enum.EasingStyle.Quint, Enum.EasingDirection.InOut), {Size = Vector3.new(InitialSize)})
HideTween:Play()
SparkEffect:Destroy()
end
task.wait(0.1)
ModelClone:Destroy()
end
end
end
local funcRunning = false
-- When user runs it activates the VFX related to it
local function Run()
local VFXFolder = Actions.Run
if funcRunning then return end
funcRunning = true
for _, VFXContent in VFXFolder:GetChildren() do
local Leg = math.random(0,1)
local VFXDescendant = VFXContent:Clone()
if Leg == 0 then
VFXDescendant.Parent = game.Players.LocalPlayer.Character:WaitForChild("Left Leg")
VFXDescendant.Position = game.Players.LocalPlayer.Character:WaitForChild("Left Leg").Position
else
VFXDescendant.Parent = game.Players.LocalPlayer.Character:WaitForChild("Right Leg")
VFXDescendant.Position = game.Players.LocalPlayer.Character:WaitForChild("Right Leg").Position
end
local RunningTween = TweenService:Create(VFXDescendant, TweenInfo.new(0.5, Enum.EasingStyle.Quint, Enum.EasingDirection.Out), {Transparency = 1, Orientation = Vector3.new(math.random(0, 360),math.random(0, 360),math.random(0, 360))})
RunningTween:Play()
RunningTween.Completed:Connect(function()
VFXDescendant:Destroy()
end)
task.wait(0.1)
end
funcRunning = false
end
local function Idle(Condition)
return
end
-- On Fired
function VFX.Action(Action, isRunning)
UserRunning = isRunning
if Action == "Stomp" then
Stomp()
end
if Action == "Run" then
Run()
end
if Action == "Idle" then
Idle()
end
end
return VFX
Thanks,
Aki
sorry for the wasted time 
///////