Hello developers!
I’m trying to find on how to make a system whenever for example a user gets over 1000 coins in my game. And if the user already has the badge it prints “User already owns milestone badge.”
(And yes, i already have a leaderstats script in ServerScriptService.)
Thank in advance to everyone for helping me!
Jonas.
The easy and simplest way is everytime you coin value is changed, you check if it is bigger than your milestone and player doesnt yet have the badge, give it to him. However if there is more optimized way of doing it, hit me up, because i am implementing badges in my game too, and doing “if” statements everytime the value changes doesnt seem the perfect way
How could i make this in a script? Since I’m not the best at scripting 
There are multiple paths you can go with this, I’d like to ask you:
How quickly are players gaining coins? Would it be efficient to just check if the coin value is 1000, or would it be possible for players to gain more than one coin at once? If they can gain more than one coin at once, your only option here is really checking whenever the value is over 1000, rather than checking if the value is exactly 1000.
Are you looking for something that awards the badge right away, or instead something that would reward them with the badge right when they join the game. This would be more efficient then using changed events.
This script I’ve written below assumes that you want the badge to be rewarded right when they obtain 1000, and also assumes they can gain more than one coin at a time.
Also I want to say, it may be more efficient to simply only hook up the GetPropertyChangedSignal if the user doesn’t own the badge when they join, that way we’re not checking people constantly who won’t be able to get the badge as they already own it. Either way because you explicitly stated you wanted it to print in the output, I’ve done the following for you.
local BadgeId = 1 -- Badge ID goes here
local BS = game:GetService("BadgeService")
game.Players.PlayerAdded:Connect(function(plr)
plr:WaitForChild("NameOfTheIntValue"):GetPropertyChangedSignal("Value"):Connect(function() -- Like I said, might me better to put if BS:UserHasBadgeAsync(plr.UserId, BadgeId) above this and have the GetPropertyChangedSignal in an else statement, but either way this method works fine too.
if plr.NameOfTheIntValue.Value >= 1000 then
if BS:UserHasBadgeAsync(plr.UserId, BadgeId) then
print("User already owns milestone badge")
else
BS:AwardBadge(plr.UserId, BadgeId)
end
end
end)
end)
My friend is testing it, is it normal that he gets this warning?
Infinite yield possible on ‘Players.HmmmmYeahOkay:WaitForChild(“DogeCoins”)’
Yes, I added a WaitForChild there because essentially I’m unsure what your leaderstat script looks like. The WaitForChild prevents the script from not finding the actual leaderstat and erroring out. As long as it finds the “DogeCoins” eventually, the script will continue to run.
It would probably be better to have this in the actual leaderstat script itself and simply reference the value instead, although this is an alternative.
Answer to your first question,
i have a system that normal players get 1 DogeCoin every second but if the user owns on of my gamepasses it gives them 2 per second.
Answer second question,
I think it would be better with my system whenever it sees that the player has 1k, it automatically gives them the badge.
Hi,
You code looks 100% fine, but you should always wrap a pcall when working with such services - simply because they have a chance [low, but still exists] to fail, even though they have the badge, it can result in errors
If you want it to only attempt to award the badge with 1000 points, you’d change:
if plr.NameOfTheIntValue.Value >= 1000 then
--to..
if plr.NameOfTheIntValue.Value == 1000 then
Keep in mind, this might not be a good outcome though. Let’s say a player has 341 coins, at that point they decided to buy the x2 gamepass. Once they get past to 999 coins, the next coin they get will be 1001 coins, thus not rewarding them the badge.
Alternatively you could check for a certain range of coins. For example, you check to award the badge if they value is between two values, such as 1000 - 1005
Adding onto what @Valkyrop said here, there is of course, as always the potential that Roblox web-bound calls may fail, although frequency is extremally low. You should wrap this in a pcall, especially if you’re only checking if they have the certain amount or checking if its within a certain range as there is only one shot for the player to earn that badge rather than the original script where there is essentially unlimited opportunity to re-earn the badge assuming it fails, meaning if it fails they won’t obtain that badge at all. I would highly recommend you check whenever the player is above 1000 instead, as it won’t halt game performance too much compared to the ladder.
local BadgeId = 1 -- Badge ID goes here
local BS = game:GetService("BadgeService")
game.Players.PlayerAdded:Connect(function(plr)
task.wait(5)
plr:WaitForChild("NameOfTheIntValue"):GetPropertyChangedSignal("Value"):Connect(function() -- Like I said, might me better to put if BS:UserHasBadgeAsync(plr.UserId, BadgeId) above this and have the GetPropertyChangedSignal in an else statement, but either way this method works fine too.
if plr.NameOfTheIntValue.Value >= 1000 then
if BS:UserHasBadgeAsync(plr.UserId, BadgeId) then
print("User already owns milestone badge")
else
BS:AwardBadge(plr.UserId, BadgeId)
end
end
end)
end)
Just an edit to @alphadoggy111 script
See basically add a cool down
The player does not load fully just after joining, so you should add a cool down in this type of things
I see what you mean, the problem i have multiple badges for 1k , 10k, 100k so i think like you said would probably be better to do the >= 1000
Yeah, that would be recommended and I’m glad that you’ve decided to go that route. Is your script working currently? Are there any errors associated with it?
There are no errors, the one thing i don’t know if it actually works since i don’t really know how i could test this? Lemme show you my current line of code.
-- Badge rewarders
local badgefolder = script:WaitForChild("Badges")
local BadgeIds = {
badge1k = badgefolder.K.Value;
}
-- 1k badge
game.Players.PlayerAdded:Connect(function(plr)
plr:WaitForChild("DogeCoins"):GetPropertyChangedSignal("Value"):Connect(function()
if plr.leaderstats.DogeCoins.Value >= 1000 then
if BadgeService:UserHasBadgeAsync(plr.UserId, BadgeIds.badge1k) then
print("User already owns milestone badge")
else
print("Milestone Badge awarded.")
BadgeService:AwardBadge(plr.UserId, BadgeIds.badge1k)
end
end
end)
end)