How do I make ClickDetector work when a player has a tool in their inventory?

RainyBora · August 5, 2023, 7:01am

What I am trying to achieve is to make a part turn from transparency 0 to 0.1 when clicked, but
I want click detector to work when a player has a tool in their inventory.

local ToolA = script.Parent.Parent.Parent.StarterPack.ToolA
local Orbz = game:GetService("Workspace"):WaitForChild("Orbz")

local object = script.Parent
local clickdetector = script.Parent.ClickDetector
clickdetector.MouseClick:Connect(function()
	local player = game:GetService("Players"):GetPlayerFromCharacter(ToolA)
	if player then
		if player.Backpack:FindFirstChild(ToolA) then
			Orbz.Transparency = 0.1
		elseif player.Character:FindFirstChild(ToolA) and player.Character:FindFirstChild(ToolA):IsA("Tool") then
			Orbz.Transparency = 0.1
		end
	end
end)

OfficialPogCat · August 5, 2023, 7:08am

Your gonna have to make a custom one!!!

Something like this in the script should work and act like a normal one:

	local Mouse = player:GetMouse()
tool.Activated:Connect(function() --check if the tool is active and then next line that it is equipped
					if tool.Equipped then
						if Mouse.Target and Mouse.Target:FindFirstChild("ClickDetector") then -- checks for click detector 
							if (tool.Handle.Position - Mouse.Target.Position).Magnitude <= Mouse.Target.ClickDetector.MaxActivationDistance then --respects the max distance of it
--Code here!
end
end 
end 
end)

Basically .Activated is always called and not the click detector itself.

Aqua_Turneur · August 5, 2023, 7:20am

You could use a proximity prompt instead

RainyBora · August 5, 2023, 7:34am

That’s a much better idea. I know how to make code that makes proximity prompt cause an event, but I’m not sure how to make the proximity prompt activate when a player has a tool in their inventory.

TimeFrenzied · August 5, 2023, 7:42am

This is how.

local tool = player.BackPack:FindFirstChildWhichIsA("Tool") or char:FindFirstChildWhichIsA("Tool")
if tool.Name == "ToolA" then

end

This should work, there are multiple more methods like descendants or isdescendantof but this is a basic way to get the tool

RainyBora · August 5, 2023, 7:51am

I’m confused

local tool = player.BackPack:FindFirstChildWhichIsA("Tool") or char:FindFirstChildWhichIsA("Tool")
if tool.Name == "ToolA" then
	script.Parent.ProximityPrompt.Triggered:Connect(function(player)
		script.Parent.Transparency = 0.1
	end)

TimeFrenzied · August 5, 2023, 7:55am

You need to refrence the player and character first, put it after this line

so

local ToolA = script.Parent.Parent.Parent.StarterPack.ToolA
local Orbz = game:GetService("Workspace"):WaitForChild("Orbz")

local object = script.Parent
local clickdetector = script.Parent.ClickDetector
clickdetector.MouseClick:Connect(function(player)
	if player then
        local char = player.Character
        local tool = player.BackPack:FindFirstChildWhichIsA("Tool") or char:FindFirstChildWhichIsA("Tool")
    if tool and tool.Name == "ToolA" then
	    script.Parent.ProximityPrompt.Triggered:Connect(function(player)
		script.Parent.Transparency = 0.1
	end
    end
end)

RainyBora · August 5, 2023, 8:09am

I tried the code you provided, but didn’t work, so I altered it and still doesn’t work. Here’s what I got.

local ToolA = script.Parent.Parent.Parent.StarterPack.ToolA
local player = game:GetService("Players"):GetPlayerFromCharacter(ToolA)
if player then
	
end
local char = player.Character or player.CharacterAdded:Wait()
local player = game:GetService("Players"):GetPlayerFromCharacter(ToolA)
if player then
	
end


local tool = player.BackPack:FindFirstChildWhichIsA("Tool") or char:FindFirstChildWhichIsA("Tool")
if tool.Name == "ToolA" then

end


script.Parent.ProximityPrompt.Triggered:Connect(function(player)
	script.Parent.Transparency = 0.1
	end)

TimeFrenzied · August 5, 2023, 8:11am

i cant tell what im reading, can you format that in studio rq?
(To Format, Open The Script > Press Ctrl + A > Right Click > Press Format • As Document)

RainyBora · August 5, 2023, 8:12am

local ToolA = script.Parent.Parent.Parent.StarterPack.ToolA
local player = game:GetService("Players"):GetPlayerFromCharacter(ToolA)
if player then

end
local char = player.Character or player.CharacterAdded:Wait()
local player = game:GetService("Players"):GetPlayerFromCharacter(ToolA)
if player then

end


local tool = player.BackPack:FindFirstChildWhichIsA("Tool") or char:FindFirstChildWhichIsA("Tool")
if tool.Name == "ToolA" then

end


script.Parent.ProximityPrompt.Triggered:Connect(function(player)
	script.Parent.Transparency = 0.1
end)

TimeFrenzied · August 5, 2023, 8:15am

That script…Won’t work. Can you use the one that I gave you and tell me what errors you get?

RainyBora · August 5, 2023, 8:17am

Using the code you provided me, I get:

TimeFrenzied · August 5, 2023, 8:19am

I edited it, try the script now. To debug some of the parts yourself, you can keep using script analasys and clean up some of the code yourself.

RainyBora · August 5, 2023, 8:24am

Still doesn’t work, so I tried altering it and my output says:

local ToolA = script.Parent.Parent.Parent.StarterPack.ToolA
local Orbz = game:GetService("Workspace"):WaitForChild("Orbz")

local object = script.Parent
local clickdetector = script.Parent.ClickDetector
clickdetector.MouseClick:Connect(function()

end)
local player = game:GetService("Players"):GetPlayerFromCharacter(ToolA)
if player then

end
local char = player.Character
local tool = player.BackPack:FindFirstChildWhichIsA("Tool") or char:FindFirstChildWhichIsA("Tool")
if tool and tool.Name == "ToolA" then

end
script.Parent.ProximityPrompt.Triggered:Connect(function(player)
	script.Parent.Transparency = 0.1
end)

5kyBuilder · August 5, 2023, 8:25am

Bro seeing this script makes me want to vomit

TimeFrenzied · August 5, 2023, 8:25am

bro what do you keep altering it to, don’t alter it, just show me the error you’re getting from my script

RainyBora · August 5, 2023, 8:27am

Only thing wrong with the script is that is says, “attempt to index nil with 'Character” in the output

5kyBuilder · August 5, 2023, 8:28am

Watch scripting tutorials PLEASE

TimeFrenzied · August 5, 2023, 8:30am

yeah thats an error on your part, replace

local player = game:GetService("Players"):GetPlayerFromCharacter(ToolA)

Clickdetectors automatically return the player, so you can use clickdetector.MouseClick:Connect(function(player) instead. I’ve edited the script again, try it now

TimeFrenzied · August 5, 2023, 8:31am

Also you should try and solve these problems yourself a little, we’re not supposed to give you scripts, you’re supposed to look for past posts and event documents and trying them instead of asking here right away, Scripting Support isn’t a script request, it’s a place to learn and improve