How do I make make my DataStore save?

Da_Fr0st · January 16, 2021, 2:12pm

Firstly I have no idea how to make my DataStore save player data in timed intervals, and secondly I don’t know what the time limit is to saving data(I think its 60 seconds but I’m not sure.) This is my DataStore :


local ClickDataStore = DataStoreService:GetDataStore("ClickDataStore")

game.Players.PlayerAdded:Connect(function(player)
	local stats = Instance.new("Folder")
	stats.Name = "leaderstats"
	stats.Parent = player

	local Clicks = Instance.new("IntValue")
	Clicks.Name = "Clicks"
	Clicks.Parent = player.leaderstats
	local data
	local success, errormessage = pcall(function()


		data = ClickDataStore:GetAsync(player.userId.."Clicks")
	end)

	if success then
		Clicks.Value = data
		print("Player Data successfully saved!")
	else
		print("There was an error when saving data")
		warn(errormessage)
	end
end)

game.Players.PlayerRemoving:Connect(function(player)

	local success, errormessage =  pcall(function()
		ClickDataStore:SetAsync(player.UserId.."Clicks",player.leaderstats.Clicks.Value)
	end)

	if success then
		print("Player Data successfully saved!")
	else
		print("There was an error when saving data")
		warn(errormessage)
	end

end)```

TypicalHB · January 16, 2021, 2:33pm

Easy. Just use a while wait() do loop. add the following code to the bottom of your player added event.

while wait(60) do
	local success, err = pcall(function()
		ClickDataStore:SetAsync(player.UserId.."Clicks", Clicks.Value)	
	end)
	
	if success then
		print("Data auto saved")
	else
		warn(err)
	end
end

Da_Fr0st · January 16, 2021, 2:45pm

Is there a way of making it save faster or is that the fastest?

TypicalHB · January 16, 2021, 2:45pm

Yep. Just change the wait interval.

Da_Fr0st · January 16, 2021, 2:46pm

Is there a limit to how fast you can save?

TypicalHB · January 16, 2021, 2:48pm

Read this article. It tells you all of the limitations of datastores, common errors, and other stuff. This should answer all of your questions. Data Stores

Da_Fr0st · January 16, 2021, 2:54pm

So is this what the final script should look like?


local ClickDataStore = DataStoreService:GetDataStore("ClickDataStore")

game.Players.PlayerAdded:Connect(function(player)
	local stats = Instance.new("Folder")
	stats.Name = "leaderstats"
	stats.Parent = player


	local Clicks = Instance.new("IntValue")
	Clicks.Name = "Clicks"
	Clicks.Parent = player.leaderstats
	local data
	local success, errormessage = pcall(function()

		data = ClickDataStore:GetAsync(player.userId.."Clicks")
		while wait(60) do
			local success, err = pcall(function()
				ClickDataStore:SetAsync(player.UserId.."Clicks", Clicks.Value)	
			end)

			if success then
				print("Data auto saved")
			else
				print("There was an error when saving data")
				warn(error)
			end
		end
	end)

	if success then
		Clicks.Value = data
		print("Player Data successfully saved!")
	else
		print("There was an error when saving data")
		warn(errormessage)
	end
end)

game.Players.PlayerRemoving:Connect(function(player)

	local success, errormessage =  pcall(function()
		ClickDataStore:SetAsync(player.UserId.."Clicks",player.leaderstats.Clicks.Value)
	end)

	if success then
		print("Player Data successfully saved!")
	else
		print("There was an error when saving data")
		warn(errormessage)
	end

end)

TypicalHB · January 16, 2021, 2:55pm

No, put the while wait() do loop at the bottom, not in the pcall

TypicalHB · January 16, 2021, 2:59pm

No, put it at the bottom. Here, I fixed it for you.

game.Players.PlayerAdded:Connect(function(player)
	local stats = Instance.new("Folder")
	stats.Name = "leaderstats"
	stats.Parent = player


	local Clicks = Instance.new("IntValue")
	Clicks.Name = "Clicks"
	Clicks.Parent = stats
	local data
	local success, errormessage = pcall(function()
		data = ClickDataStore:GetAsync(player.userId.."Clicks")
	end)

	if success then
		Clicks.Value = data
		print("Player Data successfully saved!")
	else
		print("There was an error when saving data")
		warn(errormessage)
	end
	
	while wait(60) do
		local success, err = pcall(function()
			ClickDataStore:SetAsync(player.UserId.."Clicks", Clicks.Value)	
		end)

		if success then
			print("Data auto saved")
		else
			print("There was an error when saving data")
			warn(error)
		end
	end
end)

Da_Fr0st · January 16, 2021, 3:00pm

There is a error: W000: (12,10) Unknown global ‘ClickDataStore’

LucasMZ_RBX · January 16, 2021, 3:01pm

That I believe wouldn’t work; try doing coroutine.wrap(function()

I’m not sure but I think it would be better to performance still;

Or just spawn() since it’s simpler;

TypicalHB · January 16, 2021, 3:02pm

It’s because “ClickDataStore” doesn’t exist. All I sent was the PlayerAdded event. You replaced your entire script…

Da_Fr0st · January 16, 2021, 3:04pm

So like this:


local ClickDataStore = DataStoreService:GetDataStore("ClickDataStore")

game.Players.PlayerAdded:Connect(function(player)
	local stats = Instance.new("Folder")
	stats.Name = "leaderstats"
	stats.Parent = player


	local Clicks = Instance.new("IntValue")
	Clicks.Name = "Clicks"
	Clicks.Parent = stats
	local data
	local success, errormessage = pcall(function()
		data = ClickDataStore:GetAsync(player.userId.."Clicks")
	end)

	if success then
		Clicks.Value = data
		print("Player Data successfully saved!")
	else
		print("There was an error when saving data")
		warn(errormessage)
	end

	while wait(60) do
		local success, err = pcall(function()
			ClickDataStore:SetAsync(player.UserId.."Clicks", Clicks.Value)	
		end)

		if success then
			print("Data auto saved")
		else
			print("There was an error when saving data")
			warn(error)
		end
	end
end)

game.Players.PlayerRemoving:Connect(function(player)

	local success, errormessage =  pcall(function()
		ClickDataStore:SetAsync(player.UserId.."Clicks",player.leaderstats.Clicks.Value)
	end)

	if success then
		print("Player Data successfully saved!")
	else
		print("There was an error when saving data")
		warn(errormessage)
	end

end)

TypicalHB · January 16, 2021, 3:05pm

Yes, that’s correct. Finally lol. Although, you did make a small mistake. You’re trying to print “error”, but the variable name is “err”.

Da_Fr0st · January 16, 2021, 3:10pm

Like this?


local ClickDataStore = DataStoreService:GetDataStore("ClickDataStore")

game.Players.PlayerAdded:Connect(function(player)
	local stats = Instance.new("Folder")
	stats.Name = "leaderstats"
	stats.Parent = player


	local Clicks = Instance.new("IntValue")
	Clicks.Name = "Clicks"
	Clicks.Parent = stats
	local data
	local success, errormessage = pcall(function()
		data = ClickDataStore:GetAsync(player.userId.."Clicks")
	end)

	if success then
		Clicks.Value = data
		print("Player Data successfully saved!")
	else
		print("There was an error when saving data")
		warn(errormessage)
	end

	while wait(60) do
		local success, error = pcall(function()
			ClickDataStore:SetAsync(player.UserId.."Clicks", Clicks.Value)	
		end)

		if success then
			print("Data auto saved")
		else
			print("There was an error when saving data")
			warn(error)
		end
	end
end)

game.Players.PlayerRemoving:Connect(function(player)

	local success, errormessage =  pcall(function()
		ClickDataStore:SetAsync(player.UserId.."Clicks",player.leaderstats.Clicks.Value)
	end)

	if success then
		print("Player Data successfully saved!")
	else
		print("There was an error when saving data")
		warn(errormessage)
	end

end)

TypicalHB · January 16, 2021, 3:11pm

yep. That should be everything. Let me know if there are any other errors, but there shouldn’t be.