How do you structure combat framework?

Help and Feedback Scripting Support
#1

Hello! I wanted to know how people structure combat in their game since im terrible at it. Usually tools are my way to go since i know which module to require based on the tool. I construct a class based on the tool and when the tool is destroyed the controller is also destroyed.

Now this is easy to do with tools since you know what module to require since you need to actualy insert the local script inside the tool. But i want to structure combat where you can bind moves like tools but without them. If anyone ever did it themselves that could help me out much would be appreciated.

2 Likes
#2

I’ve never made a combat framework, but this is just my idea on a way you could do it

  1. Collect input data from client – Check if its a active ability – Send to server
  2. Collect the data sent on the server – Check for cooldowns & if they actually own and/or have the ability equipped – Run ability & apply cooldowns (send visual effects to all clients)
  3. Collect visual data sent from the server on all clients – Create the visual effects based on the data recieved

But there is probably a better way to do it, thats just my thinking

3 Likes
#4

Yes this is exactly my layout. Im trying to be able to work with a ton of abilities like i mentioned earlier. I also want to able to switch abilities per request and disconnect previous connections. The problem is communicating beteeen modules and creating controllers when needed.

2 Likes
#6

this is all backend, are you asking about how you can add abilities to tools? I’m confused then

2 Likes
#7

No, your reply is telling me how to rig a tool and create a hitbox.

I create a class which handles the tools moveset and everything regarding it. This is easy to do with tools since you know where the module is and which one to require based on the tool.

I want to structure framework with the same OOP structure but without the tools. Basicallt a moveset picker which gets abilities from different modules

2 Likes
#8

Yeah what I told you is exactly how you do it, here’s a paste of my implementation

2 Likes
#9

So your telling me you have a successful ability picker using oop here?

1 Like
#10

yeah? it’s probably the easiest thing to add out of all the functions there

2 Likes
#11

It looks like you have a successful tool with with abilities there. Im trying to AVOID tools and structure an ability picker on the client which can go to modules and bind those moves to client inputs (hopefully i explained it well) my problem is being able to refer to those little ability modules and being able to disconnect and connect those input connections.

1 Like
#12

so you just want abilities in general? you just apply the same logic but remove the model from it, select the abilities on the server fire the client with the ability information it needs set the keybinds on the client using a table then have it fire the server on the client with the mouse position and ability id, check on the server if the owner owns the ability and if the ability is on cooldown and depending on the results execute it in the direction of the mouse position

#13

Okay let me break it down.

Main Module:

local Abilities = {}
Abilities.__index = Abilities 

function Abilities.newController()
local self = {}
self.connections = {}
setmetatable(self, Abilities)

return self
end)

funcrion Abilities:BindMove()
--right here im trying to figure out how to bind other modules context and make them usable
end

Please im not asking for any cooldowns or hitboxes ive been knowing that, just how to implement these modules. Again my problem is finding these modules and actually binding the move.

#14

oh, like this

local Abilities = {};
setmetatable(Abilities, {
  __call = function(T, ...)
      return T:Start(...);
  end
});

function Abilities:Start(...)
 local packed_modules = {...}
 local AbilitiesInstance = {};

 for index, packed_module in pairs(packed_modules) do
  AbilitiesInstance[packed_module.Name] = packed_module.Env;
 end

 AbilitiesInstance.Moves = {};
 AbilitiesInstance.Environment = {};
 setmetatable(AbilitiesInstance, {__index = Abilities});
 return AbilitiesInstance;
end

function Abilities:BindMove(bind : Enum.Keybind, move : ModuleScript)
  self.Moves[bind] = require(move);
end

function Abilities:ExecuteMoveAt(bind : Enum.Keybind) 
  if not self.Moves[bind] then
   return false;
  end

  setfenv(self.Moves[bind], self); --// allows you to use methods in the superclass AbilitiesInstance, use Moves[bind] to get any move,will error in studio but in runtime it works
 self.Moves[bind]();
end

function Abilities:PackModule(requiredModule, id : string)
  return {Env = requiredModule, Name = id}
end
#15

If only i could just run the module script, that module has a controller attached with its own methods all im trying to do is create the new controller when i bind the move, but now its expecting that module to use the same keyword .new to create the new controller. Example: controller.new, controller.make, etc

#16

Why do you need different keywords to create the new controller? I mean I guess you could do it with the

setmetatable(Abilities, {
  __call = function(T, ...)
      return T:Start(...);
  end
});

part of the function, just replace

T:Start(...);

with

if T.new then
  return T.new(...);
elseif T.make then
  return T.make(...)
end

and just do

Abilities(...)
#17

I think you’re grossly overcomplicating this, the function just has to be what runs the move

#18

Im not trying to over complicate it, simply just trying to find ways which would achieve what im trying to do, sorry for the confusion.

#19

My understanding is, you make the moves in a module script which is a function, then require it and wrap it in an Abilities class, for like cooldowns and what not, store it in a main controller then make a method in the abilities class that calls the function and lets you use it whenever you need to use the ability

#20

Thats what i was looking for in the beginning glad we could filter this out