How to create a punch tool

NoobInAFishTank · October 13, 2024, 2:56pm

so i wanna create a punch tool and evertyime u click an anim plays and a part spawns for 0.1 second, and anyone inside the part gets damaged the punch tool users Strength leaderstat value, i alr made one but it doesnt change value when u get more strength heres my script:

local player = game.Players.LocalPlayer
local tool = script.Parent
local cd = false
local animation = Instance.new("Animation")
animation.AnimationId = "rbxassetid://72977696799369"

local screenGui = player:WaitForChild("PlayerGui"):WaitForChild("StrengthGui")
local textLabel = screenGui:FindFirstChild("StrengthAdded")

local function onTouched(part, player)
	local leaderstats = player:FindFirstChild("leaderstats")
	local strength = leaderstats:FindFirstChild("Endurance")
	local otherPlayer = game.Players:GetPlayerFromCharacter(part.Parent)
	if otherPlayer and otherPlayer ~= player then
		local otherHumanoid = otherPlayer.Character:FindFirstChildOfClass("Humanoid")
		if otherHumanoid then
			otherHumanoid:TakeDamage(strength.Value)
		end
	end
end

tool.Activated:Connect(function()
	if not cd then
		cd = true
		local LoadedAnimtion = player.Character:WaitForChild("Humanoid"):LoadAnimation(animation)
		LoadedAnimtion.Priority = Enum.AnimationPriority.Action
		LoadedAnimtion:Play()
		local punchPart = Instance.new("Part")
		punchPart.Size = Vector3.new(5, 5, 5)
		punchPart.Transparency = 0.5
		punchPart.Anchored = true
		punchPart.CanCollide = false
		punchPart.CFrame = player.Character.PrimaryPart.CFrame * CFrame.new(0, 0, -5)
		punchPart.Parent = workspace
		punchPart.Touched:Connect(onTouched)
		task.wait(0.01)
		cd = false
		punchPart:Destroy()
	end
end)

HeCatchThose · October 13, 2024, 5:03pm

Make sure the Requires Handle on the tool is disabled, b/c if it’s enabled then the tool won’t activate with a handle.

Real_Alyke · October 13, 2024, 5:19pm

I believe the issue here is that the value of the strength from the leaderstats doesnt change

VonsRevenges · October 13, 2024, 5:23pm

if @HeCatchThose solution didn’t work, my suggestion is to do smth like this:

local player = game.Players.LocalPlayer
local tool = script.Parent
local cd = false
local animation = Instance.new("Animation")
animation.AnimationId = "rbxassetid://72977696799369"

local screenGui = player:WaitForChild("PlayerGui"):WaitForChild("StrengthGui")
local textLabel = screenGui:FindFirstChild("StrengthAdded")

local function onTouched(part, player)
	local leaderstats = player:FindFirstChild("leaderstats")
	local strength = leaderstats:FindFirstChild("Endurance")
	local otherPlayer = game.Players:GetPlayerFromCharacter(part.Parent)
	if otherPlayer and otherPlayer ~= player then
		local otherHumanoid = otherPlayer.Character:FindFirstChildOfClass("Humanoid")
		if otherHumanoid then
			otherHumanoid:TakeDamage(strength.Value)
		end
	end
end

local function Punch()
	if not cd then
		cd = true
		local LoadedAnimtion = player.Character:WaitForChild("Humanoid"):LoadAnimation(animation)
		LoadedAnimtion.Priority = Enum.AnimationPriority.Action
		LoadedAnimtion:Play()
		local punchPart = Instance.new("Part")
		punchPart.Size = Vector3.new(5, 5, 5)
		punchPart.Transparency = 0.5
		punchPart.Anchored = true
		punchPart.CanCollide = false
		punchPart.CFrame = player.Character.PrimaryPart.CFrame * CFrame.new(0, 0, -5)
		punchPart.Parent = workspace
		punchPart.Touched:Connect(onTouched)
		task.wait(0.01)
		cd = false
		punchPart:Destroy()
	end
end

local UserInputService = game:GetService("UserInputService")

UserInputService.InputBegan:Connect(function(input, gp)
	if gp then return end

	if script.Parent.Parent == player.Character then
		if input.UserInputType == Enum.UserInputType.MouseButton1 then
			Punch()
		end

		if UserInputService.TouchEnabled and input.UserInputType == Enum.UserInputType.Touch then
			Punch()
		end
	end
end)

Lord_BradyRocks · October 13, 2024, 5:51pm

Hi, I tried this code, in a tool, and activated it, and nothing happens… the punch part does not get created…

(commented out screengui and textlabel…

Real_Alyke · October 13, 2024, 7:07pm

Hello, thank you for testing the code and figuring out if it worked or not, I rushed this script without testing

VonsRevenges · October 13, 2024, 7:18pm

Are u able to test my script? (Notice that theres leaderstats too)

NoobInAFishTank · October 14, 2024, 4:33pm

i tested it, the part spawns but deals no damage to players even if i have 1000 strength

NoobInAFishTank · October 14, 2024, 4:34pm

for me it spawns, maybe it didnt work bcuz it couldnt find and play anim bcuz for u its sanitized. also this is not related but what is that avatar bro

NoobInAFishTank · October 14, 2024, 4:34pm

sry guys if i didnt respond, u guys responded at midnight for me

VonsRevenges · October 14, 2024, 4:35pm

it deals damages to players, are u testing on a dummy? if yes i will edit the script.

NoobInAFishTank · October 14, 2024, 4:37pm

i was testing on my alt account both in a team test, but if u can i just want it to find a humanoid so i can test on a dummy too

VonsRevenges · October 14, 2024, 4:40pm

local player = game.Players.LocalPlayer
local tool = script.Parent
local cd = false
local animation = Instance.new("Animation")
animation.AnimationId = "rbxassetid://72977696799369"

local screenGui = player:WaitForChild("PlayerGui"):WaitForChild("StrengthGui")
local textLabel = screenGui:FindFirstChild("StrengthAdded")

local function onTouched(part: BasePart)
	if part and part.Parent:FindFirstChild("Humanoid") then
		local leaderstats = player:FindFirstChild("leaderstats")
		local strength = leaderstats:FindFirstChild("Endurance")
		
		if not part:IsDescendantOf(player.Character) then
			local otherHumanoid = part.Parent:FindFirstChild("Humanoid")
			if otherHumanoid then
				otherHumanoid:TakeDamage(strength.Value)
			end
		end
	end
end

local function Punch()
	if not cd then
		cd = true
		local LoadedAnimtion = player.Character:WaitForChild("Humanoid"):LoadAnimation(animation)
		LoadedAnimtion.Priority = Enum.AnimationPriority.Action
		LoadedAnimtion:Play()
		local punchPart = Instance.new("Part")
		punchPart.Size = Vector3.new(5, 5, 5)
		punchPart.Transparency = 0.5
		punchPart.Anchored = true
		punchPart.CanCollide = false
		punchPart.CFrame = player.Character.PrimaryPart.CFrame * CFrame.new(0, 0, -5)
		punchPart.Parent = workspace
		punchPart.Touched:Connect(onTouched)
		task.wait(0.01)
		cd = false
		punchPart:Destroy()
	end
end

local UserInputService = game:GetService("UserInputService")

UserInputService.InputBegan:Connect(function(input, gp)
	if gp then return end

	if script.Parent.Parent == player.Character then
		if input.UserInputType == Enum.UserInputType.MouseButton1 then
			Punch()
		end

		if UserInputService.TouchEnabled and input.UserInputType == Enum.UserInputType.Touch then
			Punch()
		end
	end
end)

NoobInAFishTank · October 14, 2024, 4:43pm

is it checking the strength of who its hitting or the person who is using the tool

VonsRevenges · October 14, 2024, 4:45pm

checks the strength of the one using the tool.

NoobInAFishTank · October 14, 2024, 4:49pm

um it deals damage but it deals like 5x more than my actual strength, when i kill it and check the. humanoid, it says the health is -6000, when i only have 1075 strength, then i set the rigs max health and health to 1076, 1 more than my strength, and kill it, i check its health and its -4000

VonsRevenges · October 14, 2024, 4:51pm

well that happens cuz its touching alot of parts, try this:

local player = game.Players.LocalPlayer
local tool = script.Parent
local cd = false
local animation = Instance.new("Animation")
animation.AnimationId = "rbxassetid://72977696799369"

local screenGui = player:WaitForChild("PlayerGui"):WaitForChild("StrengthGui")
local textLabel = screenGui:FindFirstChild("StrengthAdded")

local function onTouched(part: BasePart)
	if part and part.Parent:FindFirstChild("Humanoid") then
		local leaderstats = player:FindFirstChild("leaderstats")
		local strength = leaderstats:FindFirstChild("Endurance")
		
		if not part:IsDescendantOf(player.Character) then
			local otherHumanoid = part.Parent:FindFirstChild("Humanoid")
			if otherHumanoid then
				otherHumanoid:TakeDamage(strength.Value)
			end
		end
	end
end

local function Punch()
	if not cd then
		cd = true
		local LoadedAnimtion = player.Character:WaitForChild("Humanoid"):LoadAnimation(animation)
		LoadedAnimtion.Priority = Enum.AnimationPriority.Action
		LoadedAnimtion:Play()
		local punchPart = Instance.new("Part")
		punchPart.Size = Vector3.new(5, 5, 5)
		punchPart.Transparency = 0.5
		punchPart.Anchored = true
		punchPart.CanCollide = false
		punchPart.CFrame = player.Character.PrimaryPart.CFrame * CFrame.new(0, 0, -5)
		punchPart.Parent = workspace
		punchPart.Touched:Once(onTouched)
		task.wait(0.01)
		cd = false
		punchPart:Destroy()
	end
end

local UserInputService = game:GetService("UserInputService")

UserInputService.InputBegan:Connect(function(input, gp)
	if gp then return end

	if script.Parent.Parent == player.Character then
		if input.UserInputType == Enum.UserInputType.MouseButton1 then
			Punch()
		end

		if UserInputService.TouchEnabled and input.UserInputType == Enum.UserInputType.Touch then
			Punch()
		end
	end
end)

NoobInAFishTank · October 14, 2024, 4:52pm

um, i dont see a difference in the script?

VonsRevenges · October 14, 2024, 4:55pm

Changed the :connect, to :once, to fire once when the part is touched, not multiple times.

NoobInAFishTank · October 14, 2024, 4:59pm

, oh it works thx a lot

char limit