How to disconnect a function

happygilmoree15 · June 18, 2021, 3:01am

So I’m making a weapon for a game and the gun breaks every time you shoot and unequip it. I tried disconnecting the function but I just get an error in output.

The code goes something like this

local Plr = game:GetService("Players").LocalPlayer
local Mouse = Plr:GetMouse()

local function Shoot()
-- do stuff
end

local function WeaponUnequipped()
Shoot:Disconnect()
end

script.Parent.Unequipped:Connect(WeaponUnequipped)
Mouse.Button1Down:Connect(Shoot)

I receive "Attempt to index function with ‘Disconnect’ upon firing this code.
This code is in a local script in a tool.

caviarbro · June 18, 2021, 3:03am

Just do

return

--// instead of (it needs to be inside the functions that you want to "Disconnect") 
:Disconnect

happygilmoree15 · June 18, 2021, 3:04am

Inside of the function WeaponUnequipped()?

caviarbro · June 18, 2021, 3:05am

Check my latest edit .

Y_VRN · June 18, 2021, 3:07am

The Connect() function, if I recall, returns an object, which is the event. That object has the Disconnect() function. So you can try this:

local Plr = game:GetService("Players").LocalPlayer
local Mouse = Plr:GetMouse()
local ShootEvent -- Variable for the event

local function Shoot()
-- do stuff
end

local function WeaponUnequipped()
ShootEvent:Disconnect() -- Use the event variable instead of function.
end

script.Parent.Unequipped:Connect(WeaponUnequipped)
ShootEvent = Mouse.Button1Down:Connect(Shoot) -- Returns the event.

D0RYU · June 18, 2021, 3:07am

local Plr = game:GetService("Players").LocalPlayer
local Mouse = Plr:GetMouse()
local Connection = nil

local function Shoot()
   -- do stuff
end

local function WeaponUnequipped()
    Connection:Disconnect()
end

script.Parent.Unequipped:Connect(WeaponUnequipped)
Connection = Mouse.Button1Down:Connect(Shoot)

this is how to disconnect, you should use return like @caviarbro said instead tho

ReplicaService · June 18, 2021, 3:10am

I recommend using “Maid” by Quenty

github.com

Quenty/NevermoreEngine/blob/version2/Modules/Shared/Events/Maid.lua

---	Manages the cleaning of events and other things.
-- Useful for encapsulating state and make deconstructors easy
-- @classmod Maid
-- @see Signal

local Maid = {}
Maid.ClassName = "Maid"

--- Returns a new Maid object
-- @constructor Maid.new()
-- @treturn Maid
function Maid.new()
	return setmetatable({
		_tasks = {}
	}, Maid)
end

function Maid.isMaid(value)
	return type(value) == "table" and value.ClassName == "Maid"
end

This file has been truncated. show original

Its really practical

happygilmoree15 · June 18, 2021, 3:16am

Where does it need to be tho, start or end of the function

caviarbro · June 18, 2021, 3:19am

Try to look on this topic I had similiar problem months ago.

D0RYU · June 18, 2021, 3:26am

if you want to break a function just use “return”
if you disconnect then you need to reconnect which is dumb

Deadwoodx · May 20, 2022, 1:15pm

Its not dumb, thats how experienced scripters do,to avoid memory leaks
You shouldn’t run alot of functions consistently to maintain performance

BaldisFriend · June 7, 2022, 10:36pm

This should work. (didn’t notice this was already solved due to no mark)

local Plr = game:GetService("Players").LocalPlayer
local Mouse = Plr:GetMouse()
local shootEvent

shootEvent = Mouse.Button1Down:Connect(function()
	-- do stuff
end)

local function WeaponUnequipped()
	shootEvent:Disconnect()
end

script.Parent.Unequipped:Connect(WeaponUnequipped)