How to save a string value in datastore

Help and Feedback Scripting Support
#1

  1. Trying to save a string value

  2. I am having trouble saving the string value.

local dataStore = game:GetService("DataStoreService"):GetDataStore("myDataStore")


game.Players.PlayerAdded:Connect(function(plr)

	

	local playerUserId = "Player_"..plr.UserId

	local data
	local success, errormessage = pcall(function()
		data = dataStore:GetAsync(tostring(playerUserId))
	end)

	if success then
		if data ~= nil then
		plr.Character.FirstName.Value = data[1]
		plr.Character.LastName.Value = data[2]

		
	end
end

end)


game.Players.PlayerRemoving:Connect(function(plr)
	local playerUserId = "Player_"..plr.UserId

	local data = {plr.Character.FirstName.Value, plr.Character.LastName.Value}

	local success, errormessage = pcall(function()
		dataStore:SetAsync(tostring(playerUserId), data)
	end)

	if success then
		print("Data successfully saved.")
	else
		print("Error when saving data.")
		warn(errormessage)
	end
end)
1 Like
#2

What’s the issue? Does the data not load? Are there errors?

#3

Keeps telling me attempt to index nil with ‘FirstName’

#4

Does it occur within the PlayerAdded event or the PlayerRemoving event?

If it occurs in the PlayerAdded event, then that means that by the time the script gets the portion where it’s suppose to apply the DataStore values, the ValueBases have not yet been added to the player’s character.

If it occurs in the PlayerRemoving event, then that means that the ValueBases have been destroyed before the script could save the data.

#5

image
It happens here, on playeradded on Data.FirstName

#6

Judging by your screenshot, I assume you forgot to check if Data is not nil before proceeding

#7

Would I just add after if success then if Data ~= nil then

1 Like
#8

So it says data isn’t nil but when I print the data.LastName it returns blank.

#9

That’s because (I assume) you didn’t make a default value to be placed into the StringValues when Data is nil.

Example:

if success then
  if data ~= nil then
    --... 
    -- inserts the datastore's values
  else
    --...
    -- inserts default values from the script
  end
end
#10

I put a default value and now that is all it is saving. When I leave it saves the default value instead of the new value.

#11

Make sure you’re testing it in-game, studio’s DataStoreService can behave differently. And if you are testing in-game, I unfortunately can’t help you

#12

can you try adding WaitForChild()