How to stop a function inside a module?

[Nikitasuper63 (iii3)]

Hello. I wrote a module for player diseases. For example, a player becomes infected with a disease and a function is activated. The problem is I don’t know how to stop this function.

function module.Distrese(name)
if module[name] then
clone.Name = module[name].Name
clone.Image = module[name].Image
clone.Parent = Player.PlayerGui.Diseases.DiseasesFrame
Description.Text = module[name].Description
if module[name].Vibration == true then
if vibrating == nil then
vibrating = RunService.RenderStepped:Connect(function()
character.HumanoidRootPart.CFrame = character.HumanoidRootPart.CFrame * CFrame.new(.075math.sin(45tick()), 0,0) --anglemath.sin(velocitytick())
end)
else
vibrating:Disconnect()
vibrating = nil
end
end

	if module[name].RemoveHP == true then
		while true do
			character.Humanoid.Health -= 2
			wait(1)
		end
	end
end

end

[0786ideal (ideal)]

you should have variable inside module, and functions to change it, then while’s loop Running statement will change to false and loop will stop

Also use task.wait(), it’s higher frequence and don’t buggy like old wait()

[scavengingbot]

there are a couple of ways…
using a while loop condition:

local condition = true

while condition do
--code
end

to stop the loop, you can then set condition to false:

condition = false

or you can try using coroutines:

local thread = coroutine.create(function()
 while task.wait(1) do
  --logic
 end
end)

coroutine.resume(thread)

and then you can close it later:

coroutine.close(thread) --closes the thread and puts it in a dead state.

Hope this helps!

[0786ideal (ideal)]

corountines are pretty much unnecesary, condition will do on it’s own

[scavengingbot]

yeah but might aswell tell him coroutines exist.
But yeah condition fits perfectly here.

[Nikitasuper63 (iii3)]

I don’t really understand what coroutines are. Why shouldn’t they be used here?

[0786ideal (ideal)]

pretty much, they shouldn’t, corountines are multi-thread, dev king made tutorial about them, stick to conditions, they are more efficient

[Nikitasuper63 (iii3)]

OK, thank you. I would try to put it while I can. Just need to test it a little

[Nikitasuper63 (iii3)]

I have a problem. How can I pass this variable to another script?

[0786ideal (ideal)]

if you are using modules, you can make:

function module:StopDamage() condition = false end

[Nikitasuper63 (iii3)]

I do not quite understand. I put a variable in a function, but I want this variable to be changeable in localscript

function module.Distrese(name)
if module[name] then
local condition = true
clone.Name = module[name].Name
clone.Image = module[name].Image
clone.Parent = Player.PlayerGui.Diseases.DiseasesFrame
Description.Text = module[name].Description
while condition do
if module[name].Vibration == true then
if vibrating == nil then
vibrating = RunService.RenderStepped:Connect(function()
character.HumanoidRootPart.CFrame = character.HumanoidRootPart.CFrame * CFrame.new(.075math.sin(45tick()), 0,0) --anglemath.sin(velocitytick())
end)
else
vibrating:Disconnect()
vibrating = nil
end
end
task.wait()
end
end
end

[0786ideal (ideal)]

never put damage on the client side!!! it will not affect player at all!

you should create module on the server and listener that will have all player’s with effect of damage in list, then module would have 2 methoods:

function module:DealDamage()
-- code to deal damage if player is in player's list
end
function module:RemovePlayerEffect(plr:String)
  module.PlayerList[plr] = nil -- removes player from list, soo first function will not take him to damage list
end

[Nikitasuper63 (iii3)]

How can I check if a player is on the list?

[0786ideal (ideal)]

I made tutorial about lua, in 8th tutorial at the very end you have example of trick to make that:

Scripting Manual

Welcome to my Scripting Tutorial, i’ll expand it overtime, for now, let’s get started

About me

Hello, i’m Ideal, i code in Roblox for 7 years now and i wanted to share my knowledge When i started, there were no tutorials in my language (I’m Polish) apart of few very basic ones, i really like how the roblox changed, and this time there are tutorials, including this one Before we start, i dedicate this tutorial to my friend, Apro87 who is beginner and needs that help

Tutorials List: A) Lua ba…

[GIassWindows (glass)]

Just a question, is the “function” that you want to stop the RunService.RenderStepped?

[Nikitasuper63 (iii3)]

Excuse me, but I honestly didn’t understand very much. If it’s not difficult for you, explain what I did wrong. I didn’t damage the player

[0786ideal (ideal)]

Uhhh, simply, you have function that do something in while loop, and you want to stop this loop in specific case, you should create second function in your module, and this function will change condition to false, soo loop will automatically stop

[Nikitasuper63 (iii3)]

No

[Nikitasuper63 (iii3)]

Thanks I got it. I’ll try to do something

[Nikitasuper63 (iii3)]

Hi again. I tried to write something, but again I didn’t understand anything.