How would I make this code better? (OOP Handcuffs)

Place File:
OOP Handcuffs_Nevermore-Engine_Place_Code-Review.rbxl (252.8 KB)

  • What does the code do and what are you not satisfied with? The code lets a Player with the Handcuff tool grab another Player’s character.
  • What potential improvements have you considered? None, I don’t know how to do this stuff since it’s my first time doing OOP in Roblox Lua
  • How (specifically) do you want to improve the code? I think it looks pretty ugly and I would really appreciate some help making it not ugly, particularly the client-server communication
1 Like

Looks good and organized. I use nevermore a lot as well. If you are going to use Nevermore why not include all your remotes (using the GetRemoteEvent library) and modules inside the actual engine? I personally make a folder in all of the directories called “Game” and store all modules relating specifically to the game in there. This could probably make the entirety of what you are making more organized and modular. As for the code it looks pretty standard, “Grabbable” systems can be pretty tedious in terms of making it non-clunky for both users.

This is what i do regarding the engine:
image

Edit: Just work on making it more secure regarding the remote events. Don’t want exploiters firing running anything they shouldn’t (team checks, distance checks, blah blah, i assume you already know this though) :slight_smile:

4 Likes

I can’t get to my computer - would you mind posting the code?

You’re going to want a computer if you want to post for this Code Review. It’s more than just one script, integrated with a library loader (Nevermore) and a tool. Your feedback for this would also be all the more helpful if you were able to test the utility.

Hierarchy picture (click to see whole image if it doesn’t load fully):

2 Likes

cracks knuckles
Carpal tunnel has entered the chat.

Thanks! I’ll try to take a look tomorrow. I’m interested to see the implementation of OOP for handcuffs – I didn’t think much about that when I drew up plans for my prison system.

1 Like