I don't know why my script doesn't work

Mr_RainBowsYT · April 25, 2021, 9:10pm

Hi i’m making this post because I made a script that, when someone types a secret code, it prints either CORRECT or INCORRECT. But since i’m a beginner, it wasn’t working for some reason and there’s notihng on the output page

Scripts:

local CodeValue = script.Parent.Parent.Parent.Parent.Parent.PC.Screen.Code


script.Parent.Prompt.Triggered:Connect(function(player)
	game.ReplicatedStorage.EnableKGUI:FireClient(player)
	local GUI = player.PlayerGui.KeycodeGUI
	if GUI.Done.Value == true then
		print("User has given a code")
		if GUI.Frame.Frame.CodeSee.Text == CodeValue.Value then
			print("CORRECT")
		else
			print("INCORRECT")
		end
	end
end)

script path

local KGUI = game.Players.LocalPlayer.PlayerGui.KeycodeGUI
local Chiffre = KGUI.Frame.Frame.CodeSee
local frame = script.Parent.Frame.Frame.Frame

game.ReplicatedStorage.EnableKGUI.OnClientEvent:Connect(function()
	KGUI.Enabled = true
	KGUI.Frame:TweenPosition(UDim2.new(0,0,0,0),"Out","Back",1,false)
end)

KGUI.Frame.X.MouseButton1Click:Connect(function()
    KGUI.Enabled = false
end)

for i ,key in pairs(frame:GetChildren()) do
	if string.find(key.Name, "Key") then
		key.MouseButton1Click:Connect(function()
			Chiffre.Text ..= string.match(key.Name, "%d")
		end)
	elseif key.Name == "Back" then
		key.MouseButton1Click:Connect(function()
			Chiffre.Text = string.sub(Chiffre.Text,1,0)
		end)
	elseif key.Name == "Enter" then
	    key.MouseButton1Click:Connect(function()
			script.Parent.Done.Value = true
		end)
	end
end

localscript path

Note: Everything works except when the server tries to know if the value is true

I’m thinking maybe one of the 2 scripts can’t access the value but then it would probably error though …

remote event path :

i’m going to sleep sorry i’ll check on this post tomorrow

Aanggoodluck · April 25, 2021, 9:19pm

WHAT IS THIS?
shouldn’t it have .Text or .Value

Mr_RainBowsYT · April 25, 2021, 9:21pm

oh oops maybe it’s that it’s a textlabel to i’m goin to try to add .Text

Update: it’ wasn’t that rip

Mr_RainBowsYT · April 25, 2021, 9:23pm

i checked using print() and i saw that the script stops working here :
at the white line

when i enter a code it does make the value to true though

Aanggoodluck · April 25, 2021, 9:50pm

this should do:

--script
local CodeValue = script.Parent.Parent.Parent.Parent.Parent.PC.Screen.Code


game.ReplicatedStorage.EnableKGUI.OnServerEvent:Connect(function(player)
	local GUI = player.PlayerGui.KeycodeGUI
	if GUI.Done.Value == true then
		print("User has given a code")
		if GUI.Frame.Frame.CodeSee.Text == CodeValue.Value then
			print("CORRECT")
		else
			print("INCORRECT")
		end
	end
  end)
  
script.Parent.Prompt.Triggered:Connect(function(player)
	game.ReplicatedStorage.EnableKGUI:FireClient(player)
end)

--local

local KGUI = game.Players.LocalPlayer.PlayerGui.KeycodeGUI
local Chiffre = KGUI.Frame.Frame.CodeSee
local frame = script.Parent.Frame.Frame.Frame

game.ReplicatedStorage.EnableKGUI.OnClientEvent:Connect(function()
	KGUI.Enabled = true
	KGUI.Frame:TweenPosition(UDim2.new(0,0,0,0),"Out","Back",1,false)
end)

KGUI.Frame.X.MouseButton1Click:Connect(function()
    KGUI.Enabled = false
end)

for i ,key in pairs(frame:GetChildren()) do
	if string.find(key.Name, "Key") then
		key.MouseButton1Click:Connect(function()
			Chiffre.Text ..= string.match(key.Name, "%d")
      game.ReplicatedStorage.EnableKGUI:FireServer()
		end)
	elseif key.Name == "Back" then
		key.MouseButton1Click:Connect(function()
			Chiffre.Text = string.sub(Chiffre.Text,1,0)
      game.ReplicatedStorage.EnableKGUI:FireServer()
		end)
	elseif key.Name == "Enter" then
	    key.MouseButton1Click:Connect(function()
			script.Parent.Done.Value = true
      game.ReplicatedStorage.EnableKGUI:FireServer()
		end)
	end
end

RealMarcoos · April 25, 2021, 9:56pm

Instead of using a remoteevent and setting a bool val to true use a RemoteFunction as it returns info that is returned when calling the :InvokeServer or :InvokeClient!

Aanggoodluck · April 25, 2021, 9:57pm

you have replied to the wrong person

Mr_RainBowsYT · April 26, 2021, 7:48am

Aanggoodluck:

local KGUI = game.Players.LocalPlayer.PlayerGui.KeycodeGUI
local Chiffre = KGUI.Frame.Frame.CodeSee
local frame = script.Parent.Frame.Frame.Frame

game.ReplicatedStorage.EnableKGUI.OnClientEvent:Connect(function()
	KGUI.Enabled = true
	KGUI.Frame:TweenPosition(UDim2.new(0,0,0,0),"Out","Back",1,false)
end)

KGUI.Frame.X.MouseButton1Click:Connect(function()
    KGUI.Enabled = false
end)

for i ,key in pairs(frame:GetChildren()) do
	if string.find(key.Name, "Key") then
		key.MouseButton1Click:Connect(function()
			Chiffre.Text ..= string.match(key.Name, "%d")
      game.ReplicatedStorage.EnableKGUI:FireServer()
		end)
	elseif key.Name == "Back" then
		key.MouseButton1Click:Connect(function()
			Chiffre.Text = string.sub(Chiffre.Text,1,0)
      game.ReplicatedStorage.EnableKGUI:FireServer()
		end)
	elseif key.Name == "Enter" then
	    key.MouseButton1Click:Connect(function()
			script.Parent.Done.Value = true
      game.ReplicatedStorage.EnableKGUI:FireServer()
		end)
	end
end

still doesn’t work
maybe I have to use a remotefunction

Aanggoodluck · April 26, 2021, 7:49am

did you replace both local and server script?

Mr_RainBowsYT · April 26, 2021, 7:52am

yes I did I can see that you changed some functions place and added some fireserver()

Aanggoodluck · April 26, 2021, 7:55am

ok ill reply if i find something useful

Aanggoodluck · April 26, 2021, 8:21am

--script
local CodeValue = script.Parent.Parent.Parent.Parent.Parent.PC.Screen.Code


game.ReplicatedStorage.EnableKGUI.OnServerEvent:Connect(function(player)
	local GUI = player.PlayerGui.KeycodeGUI
	if GUI.Done.Value == true then
		print("User has given a code")
		if GUI.Frame.Frame.CodeSee.Text == CodeValue.Value then
			print("CORRECT")
		else
			print("INCORRECT")
		end
	end
  end)
  
script.Parent.Prompt.Triggered:Connect(function(player)
	game.ReplicatedStorage.EnableKGUI:FireClient(player)
end)

--local

local KGUI = game.Players.LocalPlayer.PlayerGui.KeycodeGUI
local Chiffre = KGUI.Frame.Frame.CodeSee
local frame = script.Parent.Frame.Frame.Frame

game.ReplicatedStorage.EnableKGUI.OnClientEvent:Connect(function()
	KGUI.Enabled = true
	KGUI.Frame:TweenPosition(UDim2.new(0,0,0,0),"Out","Back",1,false)
end)

KGUI.Frame.X.MouseButton1Click:Connect(function()
    KGUI.Enabled = false
end)

local function pressedButton(x)
  local s= string.sub(x,4,4)
  if Chiffre.Text~=""then
    Chiffre.Text=Chiffre.Text..s
  else
    Chiffre.Text=s
  end
end

for i,v in pairs(frame:GetChildren()) do
  v.MouseButton1Click:Connect(function()
    local len=#Chiffre.Text
    if v.Name=="Enter"then
			script.Parent.Done.Value = true
      game.ReplicatedStorage.EnableKGUI:FireServer()
   elseif v.Name=="Back"then
      if len>1 then
      local s=string.sub(Chiffre.Text,1,#Chiffre.Text-1)
      Chiffre.Text=s
      elseif len==1 then
        Chiffre.Text=""
      else
        Chiffre.Text=""
      end
      
    else
    v.MouseButton1Click:Connect(pressedButton(v.Name))
    end
  end)
end

That’s it
won’t edit anymore sorry about that

please tell me if this works
last try

Mr_RainBowsYT · April 26, 2021, 10:40am

Aanggoodluck:

local KGUI = game.Players.LocalPlayer.PlayerGui.KeycodeGUI
local Chiffre = KGUI.Frame.Frame.CodeSee
local frame = script.Parent.Frame.Frame.Frame

game.ReplicatedStorage.EnableKGUI.OnClientEvent:Connect(function()
	KGUI.Enabled = true
	KGUI.Frame:TweenPosition(UDim2.new(0,0,0,0),"Out","Back",1,false)
end)

KGUI.Frame.X.MouseButton1Click:Connect(function()
    KGUI.Enabled = false
end)

local function pressedButton(x)
  local s= string.sub(x,4,4)
  if Chiffre.Text~=""then
    Chiffre.Text=Chiffre.Text..s
  else
    Chiffre.Text=s
  end
end

for i,v in pairs(frame:GetChildren()) do
  v.MouseButton1Click:Connect(function()
    local len=#Chiffre.Text
    if v.Name=="Enter"then
			script.Parent.Done.Value = true
      game.ReplicatedStorage.EnableKGUI:FireServer()
   elseif v.Name=="Back"then
      if len>1 then
      local s=string.sub(Chiffre.Text,1,#Chiffre.Text-1)
      Chiffre.Text=s
      elseif len==1 then
        Chiffre.Text=""
      else
        Chiffre.Text=""
      end
      
    else
    v.MouseButton1Click:Connect(pressedButton(v.Name))
    end
  end)
end

Rip still doesn’t work but thanks a lot of helping though
i’m going to rewrite the script maybe

Aanggoodluck · April 26, 2021, 10:42am

Ok

no errors right?

Thanks for testing

Mr_RainBowsYT · April 26, 2021, 10:43am

yea there’s no errors but the script just stops itself

at this point i’ll just take a script from a free model

Aanggoodluck · April 26, 2021, 10:49am

sorry but the problem seem to be occuring because there is no update in the server
i found something lets try 1 more time and ill give up

Mr_RainBowsYT · April 26, 2021, 10:51am

Ok thank you so much for helping

Aanggoodluck · April 26, 2021, 10:58am

--script
local CodeValue =script.Parent.Parent.Parent.Parent.Parent.PC.Screen.ChildRemoved

game.ReplicatedStorage.EnableKGUI.OnServerEvent:Connect(function(player,complete,text)
	local GUI = player.PlayerGui.KeycodeGUI
  GUI.Done.Value=complete
	if GUI.Done.Value == true then
		print("User has given a code")
		if text == CodeValue.Value then
			print("CORRECT")
		else
			print("INCORRECT")
		end
	end
  end)
  
script.Parent.Prompt.Triggered:Connect(function(player)
	game.ReplicatedStorage.EnableKGUI:FireClient(player)
end)

--local

local KGUI = game.Players.LocalPlayer.PlayerGui.KeycodeGUI
local Chiffre = KGUI.Frame.Frame.CodeSee
local frame = script.Parent.Frame.Frame.Frame

game.ReplicatedStorage.EnableKGUI.OnClientEvent:Connect(function()
	KGUI.Enabled = true
	KGUI.Frame:TweenPosition(UDim2.new(0,0,0,0),"Out","Back",1,false)
end)

KGUI.Frame.X.MouseButton1Click:Connect(function()
    KGUI.Enabled = false
end)

local function pressedButton(x)
  local s= string.sub(x,4,4)
  if Chiffre.Text~=""then
    Chiffre.Text=Chiffre.Text..s
  else
    Chiffre.Text=s
  end
end

for i,v in pairs(frame:GetChildren()) do
  v.MouseButton1Click:Connect(function()
    local len=#Chiffre.Text
    local done=script.Parent.Done
    if v.Name=="Enter"then
			done.Value = true
      game.ReplicatedStorage.EnableKGUI:FireServer(done.Value,Chiffre.Text)
   elseif v.Name=="Back"then
      if len>1 then
      local s=string.sub(Chiffre.Text,1,#Chiffre.Text-1)
      Chiffre.Text=s
      elseif len==1 then
        Chiffre.Text=""
      else
        Chiffre.Text=""
      end
      
    else
    v.MouseButton1Click:Connect(pressedButton(v.Name))
    end
  end)
end

last try thanks for not giving up

Mr_RainBowsYT · April 26, 2021, 11:06am

Ok I think it works now it’s just my code value now but thanks for helping !

Aanggoodluck · April 26, 2021, 11:11am

seems you have some trouble since i modified the code:

--script
local CodeValue = script.Parent.Parent.Parent.Parent.Parent.PC.Screen.Code

game.ReplicatedStorage.EnableKGUI.OnServerEvent:Connect(function(player,complete,text)
	local GUI = player.PlayerGui.KeycodeGUI
  GUI.Done.Value=complete
	if GUI.Done.Value == true then
		print("User has given a code")
		if text == CodeValue.Value then
			print("CORRECT")
		else
			print("INCORRECT")
		end
	end
  end)

script.Parent.Prompt.Triggered:Connect(function(player)
	game.ReplicatedStorage.EnableKGUI:FireClient(player)
end)

--local
local KGUI = game.Players.LocalPlayer.PlayerGui.KeycodeGUI
local Chiffre = KGUI.Frame.Frame.CodeSee
local frame = script.Parent.Frame.Frame.Frame

game.ReplicatedStorage.EnableKGUI.OnClientEvent:Connect(function()
	KGUI.Enabled = true
	KGUI.Frame:TweenPosition(UDim2.new(0,0,0,0),"Out","Back",1,false)
end)

KGUI.Frame.X.MouseButton1Click:Connect(function()
    KGUI.Enabled = false
end)

for i ,key in pairs(frame:GetChildren()) do
	if string.find(key.Name, "Key") then
		key.MouseButton1Click:Connect(function()
			Chiffre.Text ..= string.match(key.Name, "%d")
		end)
	elseif key.Name == "Back" then
		key.MouseButton1Click:Connect(function()
			Chiffre.Text = string.sub(Chiffre.Text,1,0)
		end)
	elseif key.Name == "Enter" then
	    key.MouseButton1Click:Connect(function()
			script.Parent.Done.Value = true
        game.ReplicatedStorage.EnableKGUI:FireServer(script.Parent.Done.Value,Chiffre.Text)
		end)
	end
end

this version i just added the server event and passed arguments into the fire server everything else untouched