I need help, again

Help and Feedback Scripting Support
,
#1

well, I need help again… I think i screwed up right now.

local function makeSurrender()
	local npc = workspace.NPC
	local makeSurrender = npc:FindFirstChild("SurrenderAnimation")

	if makeSurrender then
		makeSurrender:Play()
	else
		print("SurrenderAnimation not found!")
	end
end

game.Players.PlayerAdded:Connect(function(player)
	player.CharacterAdded:Connect(function(character)
		local humanoid = character:WaitForChild("Humanoid")
		humanoid.HealthChanged:Connect(function(Health)
			if Health < 90 then
				makeSurrender()
			end
		end)
	end)
end)
2 Likes
#2

Instead of using HealthChanged, use :GetPropertyChangedSignal("Health"), and connect to that.

#3

Thank you, i’ll message you if i have any problems.

#4

Welp, the animation didn’t play, what should i do about that?

1 Like
#5

Is it not playing because the animation isn’t working, or your code isn’t running, use a print statement.

#6

I have the animation inside the NPC rig, You meant that?

#7

Load the animation using LoadAnimation():
local surrenderAnimation = npc.Humanoid.Animator:LoadAnimation(makeSurrender) surrenderAnimation:Play()

#8

May i ask where should i replace or should i add?

#9

Write it like this:

local npc = workspace.NPC
	local makeSurrender = npc:FindFirstChild("SurrenderAnimation"):LoadAnimation()

	if makeSurrender then
		makeSurrender:Play()
	else
		print("SurrenderAnimation not found!")
	end

It won’t work if you didn’t publish the animation, or you don’t own it.

#10

I own the animation, i did actually publish it. And it didn’t work.

1 Like
#11

This is what the function should look like.

local function makeSurrender()
	local npc = workspace.NPC
	local makeSurrender = npc:FindFirstChild("SurrenderAnimation")
local humanoid = npc:FindFirstChild("Humanoid")

	if makeSurrender and humanoid then
		local surrenderAnim = humanoid.Animator:LoadAnimation(makeSurrender)
surrenderAnim:Play()
	else
		print("SurrenderAnimation not found!")
	end
end
#12

It didn’t work unfortianately. (I’m sorry if i spell something incorrectly i’m hungarian and it is a bit hard to speak english.)

#13

Does it print “SurrenderAnimation not found!” or is there an error?

#14

It doesn’t print that, console doesn’t show any errors, same as the script.

#15

That means that the function is not being called, which means that you messed up somewhere here:

game.Players.PlayerAdded:Connect(function(player)
	player.CharacterAdded:Connect(function(character)
		local humanoid = character:WaitForChild("Humanoid")
		humanoid.HealthChanged:Connect(function(Health)
			if Health < 90 then
				makeSurrender()
			end
		end)
	end)
end)

Did you change the humanoid.HealthChanged:Connect() to what @Den_vers stated?: :GetPropertyChangedSignal("Health"):Connect()

#16

I actually did.
(30 thing bla bla)

#17

Here is the correct script.

local function makeSurrender()
	local npc = workspace.NPC
	local makeSurrender = npc:FindFirstChild("SurrenderAnimation")
	local humanoid = npc:FindFirstChild("Humanoid")

	if makeSurrender and humanoid then
		local surrenderAnim = humanoid.Animator:LoadAnimation(makeSurrender)
		surrenderAnim:Play()
	else
		print("SurrenderAnimation not found!")
	end
end

game.Players.PlayerAdded:Connect(function(player)
	player.CharacterAdded:Connect(function(character)
		local humanoid = character:WaitForChild("Humanoid")
		humanoid:GetPropertyChangedSignal("Health"):Connect(function()
			local Health = humanoid.Health
			if Health < 90 then
				makeSurrender()
			end
		end)
	end)
end)
#18

The issue I am seeing here, is first that you are not loading the animation properly. You must load it somewhat like this.

local function makeSurrender()
	local npc = workspace:FindFirstChild("NPC")
	local makeSurrenderAnim = -- [[Path to your animation instance for now it's nil]]
		nil
	
	if makeSurrenderAnim ~= nil then
		local makeSurrenderAnimTrack = npc:FindFirstChildOfClass("Humanoid").Animator:LoadAnimation(makeSurrenderAnim)
		
		makeSurrenderAnimTrack:Play()
	end
end

Also you are checking the player health and then making the NPC surrender which doesn’t make sense, so if you’re trying to make the NPC surrender at a certain health amount you need to connect the event to the NPC’s humanoid, not the player’s. Unless the player is getting hurt the NPC will not surrender in this instance.

EDIT: Adding documentation

Animator | Documentation - Roblox Creator Hub
AnimationTrack | Documentation - Roblox Creator Hub

#19

Ontop of @tannnxr 's post, you should add debounce to the surrender function because it’s going to trigger more than once if there’s regen enabled.

1 Like
#20

Also, where should i put the script? I used to leave this script inside the rig’s model