Infinite yield problem

Help and Feedback Scripting Support
#1

I know that infinite yield is just a warning but, it it doesn’t even do the local function. How do i fix this?

local replicatedstorage = game:GetService("ReplicatedStorage")
local armormodule = require(game.ServerScriptService:WaitForChild("ArmorHandler"))
	local function addToFrame(armor)
		local template = script.Parent.MainGui.Inventory.Templates.Template
		
		local newTemplate = template:Clone()
		newTemplate.Parent =  script.Parent.MainGui.Inventory.Duplicates
		newTemplate.Visible = true
		
		local newArmor = armormodule.chooseRandom():Clone()
		
		local camera = Instance.new("Camera")
		camera.CFrame = CFrame.new(newArmor.PrimaryPart.Position + (newArmor.PrimaryPart.CFrame.lookVector * 3), newArmor.PrimaryPart.Position)
		camera.Parent = newTemplate.ViewportFrame
		
		newTemplate.ViewportFrame.CurrentCamera = camera
end

replicatedstorage.Events.UpdateInventory.OnClientEvent:Connect(function(player, armor)
	addToFrame(armor)
end)
#2

The client can’t access the contents of ServerScriptService, move the module to ReplicatedStorage

#3

The infinite yield warning is when you do :WaitForChild(“String”) and leave the second parameter (the number timeout) empty.

#4

yes, now it works but can you also help me with

Screen Shot 2021-03-13 at 12.36.13 PM
Screen Shot 2021-03-13 at 12.36.13 PM954×40 8.21 KB

#5

You forgot to set PrimaryPart on the armor.

1 Like
#6

what do i set it to??

#7

That error is trying to say that newArmor.PrimaryPart is nil (meaning it doesn’t exist or have a value)

#8

the armor looks like this

Screen Shot 2021-03-13 at 12.37.53 PM
Screen Shot 2021-03-13 at 12.37.53 PM432×556 41 KB

#9

the armor looks like that on top, what do i set it to?

#10

You would have to create a base part for the armor similar to how player characters have HumanoidRootPart and set the Armor’s primary part to it

#11

so i set it to?
Screen Shot 2021-03-13 at 12.40.29 PM

#12

If the armor is going to attach to the player’s character then yea. But if it’s for display, you would have to create a new Part and set it to that

#13

It’s just blank?
Screen Shot 2021-03-13 at 12.43.27 PM

#14

You have to parent the armor to the viewportframe

Yes

newArmor.Parent = newTemplate.ViewportFrame
#15

in the script?

#16

yay, thanks it works now!