Is my script incorrect or wrong bcuz its not functioning

Help and Feedback Scripting Support
#1

i have this script thats not working and i think it should work, any ideas why its not working?

local replicatedStorage = game:GetService("ReplicatedStorage")
local mapValue = replicatedStorage:WaitForChild("Map")

local function onValueChanged()
	print("Hello World")
	if mapValue.Value == "Baseplate" then
		local currentmap = game.Workspace:WaitForChild("Map")
		currentmap:Destroy()

		local newmap = game.ServerStorage.Maps.Baseplate:Clone()
		newmap.Parent = workspace
		newmap.Name = "Map"
	end

	if mapValue.Value == "Crossroad" then
		local currentmap = game.Workspace:WaitForChild("Map")
		currentmap:Destroy()

		local newmap = game.ServerStorage.Maps.Crossroad:Clone()
		newmap.Parent = workspace
		newmap.Name = "Map"
	end
end

mapValue:GetPropertyChangedSignal("Value"):Connect(onValueChanged)
1 Like
#2

whats the output?

hello this is nothing aaaaaaaaa what?

#3

Attempt to connect failed: Passed value is not a function

#4

incorrect reference to the fucntion u tryna connect

#5

wdym
character limit is 30 30 30

#6 
local replicatedStorage = game:GetService("ReplicatedStorage")
local mapValue = replicatedStorage:WaitForChild("Map")

local function onValueChanged()
	print("running ok")

	local OLDMap = workspace:FindFirstChild("Map")
	if OLDMap then OLDMap:Destroy() end

	local newMap
	if mapValue.Value == "Baseplate" then
		newMap = game.ServerStorage.Maps.Baseplate:Clone()
	elseif mapValue.Value == "Crossroad" then
		newMap = game.ServerStorage.Maps.Crossroad:Clone()
	end

	if newMap then
		newMap.Parent = workspace
		newMap.Name = "Map"
	end
end

mapValue:GetPropertyChangedSignal("Value"):Connect(onValueChanged)

try this , show the output

#7

its still the same output as before: Attempt to connect failed: Passed value is not a function

#8

ouh bruh whats the map value ?

#9

try this:

local replicatedStorage = game:GetService("ReplicatedStorage")
local mapValue = replicatedStorage:WaitForChild("Map")

local function onValueChanged()
	print("running ok")

	local OLDMap = workspace:FindFirstChild("Map")
	if OLDMap then OLDMap:Destroy() end

	local newMap
	if mapValue.Value == "Baseplate" then
		newMap = game.ServerStorage.Maps.Baseplate:Clone()
	elseif mapValue.Value == "Crossroad" then
		newMap = game.ServerStorage.Maps.Crossroad:Clone()
	end

	if newMap then
		newMap.Parent = workspace
		newMap.Name = "Map"
	end
end

mapValue:GetPropertyChangedSignal("Value"):Connect(function()
onValueChanged()
end)
#10

doesnt work, same error
char limit

#11

#12

I suggest you to use attribute , its more way better and did u update the map value by client or server side?

#13

its from client and how would i use attribute, maybe bcuz its from client thats why it aint working

#14

Have you tried putting outside a local function?

local replicatedStorage = game:GetService("ReplicatedStorage")
local mapValue = replicatedStorage:WaitForChild("Map")

mapValue:GetPropertyChangedSignal("Value"):Connect(function()
  print("running ok")

	local OLDMap = workspace:FindFirstChild("Map")
	if OLDMap then OLDMap:Destroy() end

	local newMap
	if mapValue.Value == "Baseplate" then
		newMap = game.ServerStorage.Maps.Baseplate:Clone()
	elseif mapValue.Value == "Crossroad" then
		newMap = game.ServerStorage.Maps.Crossroad:Clone()
	end

	if newMap then
		newMap.Parent = workspace
		newMap.Name = "Map"
	end
end)
#15

where would i use a local function in this?

#16

No, i meant instead of putting the code inside a local function name(), just put the code directly inside the event (test what i sent)

#17

hm ok ill try that right now
char limit

1 Like
#18

if u mean like this then it doesnt work

local replicatedStorage = game:GetService("ReplicatedStorage")
local mapValue = replicatedStorage:WaitForChild("Map")

local function ChangeMap()
	print("running ok")

	local OLDMap = workspace:FindFirstChild("Map")
	if OLDMap then OLDMap:Destroy() end

	local newMap
	if mapValue.Value == "Baseplate" then
		newMap = game.ServerStorage.Maps.Baseplate:Clone()
	elseif mapValue.Value == "Crossroad" then
		newMap = game.ServerStorage.Maps.Crossroad:Clone()
	end

	if newMap then
		newMap.Parent = workspace
		newMap.Name = "Map"
	end
end

mapValue:GetPropertyChangedSignal("Value"):Connect(ChangeMap)
#19

No i meant test this:

local replicatedStorage = game:GetService("ReplicatedStorage")
local mapValue = replicatedStorage:WaitForChild("Map")

mapValue:GetPropertyChangedSignal("Value"):Connect(function()
  print("running ok")

	local OLDMap = workspace:FindFirstChild("Map")
	if OLDMap then OLDMap:Destroy() end

	local newMap
	if mapValue.Value == "Baseplate" then
		newMap = game.ServerStorage.Maps.Baseplate:Clone()
	elseif mapValue.Value == "Crossroad" then
		newMap = game.ServerStorage.Maps.Crossroad:Clone()
	end

	if newMap then
		newMap.Parent = workspace
		newMap.Name = "Map"
	end
end)

You were putting it inside a local function onValueChanged(), i said to try the script without putting it inside a function.

#20

that aint working too… is it not working bcuz it changed the value from client side?