Is there a Better way of doing this for loop?

Help and Feedback Scripting Support
,
#1

Hello,

So I am wondering if there is a better way of doing this for loop?

for _,Ex in pairs(workspace:GetDescendants()) do

if Condition then -- Finds a Part under a Condition

end

if AnotherCondition then -- Finds a Part under another Condition, not similar to First

end

end

Although this is the right way to do it, it gets a bit messy and annoying to look for specific Parts, is there a better way of doing this?

#2

You could use collectionService to give parts tags, and then check for their tags.

2 Likes
#3

That Kind of Sounds like a for loop with an extra step, can you explain?

#4

You can assign parts a different tags, then you can use collectionService to later on, to get all parts with that tag, and do something to it.

If you mean that your for-loop the right way of doing something, then you really gotta specify what your goal is. You should always try to narrow down the stuff you would loop through.

1 Like
#5

if you can, placing them in a folder would help or referencing them in a table. Other than that I don’t think there is a way to get a bunch of parts without a for loop. Might be wrong though

#6

This still doesn’t really help, What you are Saying there is what the for loop already does depending on the specification.

I Already do this, i am refrencing certain objects and applying functions to them (This off topic from the post however)

#7

The best way is to narrow your selection of things you loop through, before doing a loop. :slight_smile:

#8

I think collection service just uses a function to provide a table with instances that has a tag

either way you’ll have to for loop in order to get all instances from a table

1 Like
#9

As i stated above, thats what im doing

#10

I agree with @TortenSkjold and @4vI7 . Using CollectionService is a good method to get shorter tables to perform the loop, and using folders correctly is very helpful too.
Doing a loop from game.Workspace:GetDescendants() sounds like a very bad idea to me…
Could be thousands of Instances there… what would be the point on doing that just to give functions to specific parts if you can just iterate from folders and CollectionService?

#11

Your code is already both clean and efficient. If you favor this style over performance though, it might help organize your script depending on how many times or ways you need to collect parts.

local function collect_with_condition(condition)
    local result = {}
    for _, obj in workspace:GetDescendants() do
        local a,b = pcall(condition, obj)
        if a and b then
            table.insert(result, obj)
        end
    end
    return result
end

local red_parts = collect_with_condition(
    function(obj) return obj.BrickColor == BrickColor.new("Bright red") end
)
for _, obj in red_parts do print(obj) end
#12

Yea, you’re already doing a loop, and I’m just telling you what you asked for, if there is a better way - No, the way you’re doing it would be the best, if you did not use :GetDescendants() on the whole workspace :smiley: Instead you should create folders with the specific parts, and go through them instead.

#13

I guess that could work, I fixed my issues with the current code I have, however I will still mark your post as the solution @TortenSkjold .

Some Stuff Isn’t helpful, but its a good tip to know, I’ll be sure to try it

#14

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.