Is there a way to make this more efficent?

[MrPieFace10 (typ)]

I created this script for a custom proximity prompt sorta thing yesterday but it causes lag spikes and frame drops. I think it may have something to do with the for loop, but I’m not entirely sure.

assigning all of the prompts to a table:

for i, v in pairs(game.Workspace:GetDescendants()) do
	if v.Name == "Prompt" then
		table.insert(prompts, v)
	end
end

main code:

while true do
	local refrencedPrompt = PromptModule.FindClosestPrompt(player.Character, prompts)
	
	PromptModule.CheckShowPrompt(player, refrencedPrompt)
	
	for i, v in ipairs(prompts) do
		if v == refrencedPrompt then
		else
			v.Enabled = false

			if v.Parent:FindFirstChild("PromptBack") then
				v.Parent:FindFirstChild("PromptBack").Enabled = false
			end

			v.Parent.Beam.Attachment0 = nil
		end
	end
	
	local magnitude = (player.Character.HumanoidRootPart.Position - refrencedPrompt.Parent.Position).Magnitude
	
	if magnitude <= refrencedPrompt.Parent.Settings.MaxDistance.Value then
		promptShown = refrencedPrompt
		
	else
		promptShown = nil
	end
	
	wait()
end

the module script works really well and i wont get into why it isnt here

[ThinkingAIINight (oscy)]

while wait() do
	local Magnitude = (Player.Character.HumanoidRootPart.Position - RefrencedPrompt.Parent.Position).Magnitude
	local RefrencedPrompt = PromptModule.FindClosestPrompt(Player.Character, Prompts)
	PromptModule.CheckShowPrompt(Player, RefrencedPrompt)
	
	for i, v in ipairs(Prompts) do
		if v == RefrencedPrompt then
		else
			v.Enabled = false
			if v.Parent:FindFirstChild("PromptBack") then
				v.Parent:FindFirstChild("PromptBack").Enabled = false
			end
			v.Parent.Beam.Attachment0 = nil
		end
	end

	if Magnitude <= RefrencedPrompt.Parent.Settings.MaxDistance.Value then
		PromptShown = RefrencedPrompt
	else
		PromptShown = nil
	end
end

[MrPieFace10 (typ)]

Is there an alternative to continuously checking the position or is there a way to update it when the player moves?

[ThinkingAIINight (oscy)]

I’m not too sure, sorry! (char lim)

[Valkyrop (JustAGuy)]

Maybe one of these would help

Check if the player is moving?

The Humanoid has a property called MoveDirection which determines, as a unit vector, the direction a player is moving in. You can access the Magnitude property and see if it’s greater than 0 to know if there is active movement without relying on what their HumanoidStateType is. Refer to the code sample on the page.

Best way to detect if a Player IS moving

Using Humanoid.MoveDirection and Humanoid.Running doesn’t work Humanoid.Running only fires when the Speed changes [image] Using Humanoid:GetPropertyChangesSignal(“MoveDirection”) also doesn’t work because it only fires when the “MoveDirection” changes… it seems like my only option is to use a Heartbeat connection or Bind to Renderstepped in which I would like to avoid if possible Is there a better way to detect if a player is moving? I would prefer not to check every Frame (60 times per sec…

How would I check to see if my player is moving?

I’m trying to make my own project custom footstep sound system from scratch, and came across and issue. I’m trying to make a line of code that detects if the player is moving before it casts a ray below them to see what they are walking on, but the script keeps seeming to break. What way could I fix this?: local Players = game:GetService(“Players”) local player = Players.LocalPlayer local character = player.Character local humanoid = character:WaitForChild(“Humanoid”) if not character or n…

Check if the player moves

Hello there, I’m making a floor particle script and the first part works just fine. My problem now is that I want it to activate whenever the player moves and I don’t know how to do that. If you could help me make a function that checks if the player is moving or not. Thank you.

[MrPieFace10 (typ)]

The articles help a lot, I will get one of my testers to see if it is less laggy

[Valkyrop (JustAGuy)]

No problems, if it helped you, please make it as a solution

Good luck!