Is this the best way of having an NPC with turn animations face the player?

Help and Feedback Code Review
#1

I have an NPC with specific animations for turning 20 degrees and 90 degrees. The code below is a stripped down version of the logic for determining what animation to play and when. The actual rotation of the NPC is done through an AlignOrientation constraint when the animation reaches a keyframe marker.

local partA = workspace.PartA
local partB = workspace.PartB

while task.wait() do

	local targetVector = CFrame.lookAt(partA.Position, partB.Position).LookVector
	local currentLookVector = partA.CFrame.LookVector
	local angle = math.floor(math.deg(math.acos(currentLookVector:Dot(targetVector))))
	local dir = 0 -- 0 = left 1 = right
	
	if angle ~= angle then angle = 0 end -- NaN check
	
	if partA.CFrame:PointToObjectSpace(partB.Position).X > 0 then
		dir = 1
	else
		dir = 0
	end

	if angle > 20 then
		partA.CFrame = partA.CFrame * CFrame.Angles(0,dir == 1 and math.rad(-20) or math.rad(20) ,0)
	end

end
1 Like