Please ignore the other bits of code, only focus on the if and for statement within the function.
The while loop is a MUST have. I will ignore any comments on it as it is fine where it is.
Please read the full script snippet and give me your thoughts on anything I could do better
-- ai sits idle like in NFS 2015 and waits for a new target to appear if theyre above a certain speed
function new.idle()
local originPosition = new.seat.CFrame.Position
local radius = 30 -- STUDS DISTANCE
local findNearbyInstances = function(position, radius)
local parts = workspace:GetChildren()
local nearbyInstances = {}
if #parts > 0 then
for _, part in ipairs(parts) do
if part:IsA("Model") and #part:GetChildren() > 0 and part:IsDescendantOf(script.Parent) == false then
-- i need to rewrite this part. it is old and outdated for what i am doing.
if part:FindFirstChildOfClass("VehicleSeat") then
local distance = (part:FindFirstChildOfClass("VehicleSeat").CFrame.Position - position).magnitude
if distance <= radius then
table.insert(nearbyInstances, part)
end
end
end
end
end
return nearbyInstances
end
local nearbyInstances = findNearbyInstances(originPosition, radius)
local TargetModel = new.ChaseTarget or nil
local TController = nil
-- here we resolve the controller for the target
local resolveTController = function(TModel: Model)
return TModel:WaitForChild("Scripts"):WaitForChild("Controller")
end
if TargetModel ~= nil then
TController = require(resolveTController(TargetModel))
end
if new.isIdle == true and new.inChase == false and new.ChaseTarget == nil then
for _, instance: Model in ipairs(nearbyInstances) do
if instance ~= nil then
if instance:WaitForChild("Inputs") then
local Tinputs = instance:WaitForChild("Inputs")
local Throttle = Tinputs:GetAttribute("throttleInput")
if Throttle ~= 0 then
if TController ~= nil then
local speed = TController:getChassisForwardSpeed()
if speed == nil then
continue
end
if speed > 0 and speed > 20 or speed < 0 and speed < -20 then
new.isIdle = false
new.inChase = true
new.ChaseTarget = instance -- sets the target model
task.spawn(coroutine.wrap(function()
local seat = instance:WaitForChild("DriverSeat")
while task.wait(1/15) do
new.advancedPath(seat)
end
end))
end
else
continue
end
else
continue
end
else -- if its not a car then skip
continue
end
else -- if it is nil then skip
continue
end
end -- end of for
-- gets ran once when the ai is started
elseif new.isIdle == true or new.inChase == false or seat == nil or new.ChaseTarget == nil then
new.inChase = false
new.ChaseTarget = nil
new.isIdle = true
new.pathfindingCompleted:Fire(true)
end
end
