Issue with tool.Equipped

DarkSide_091 · August 27, 2022, 12:34pm

Hello, here is my issue. So the issue is that, I want the function to run only when the tool is equipped. I tried and it doesn’t work. Thanks in advance if you help me fix it.

-- Variables
local plr = game:GetService("Players").LocalPlayer
local plrGui = plr.PlayerGui
local cuffGui = plrGui:WaitForChild("CuffGUI") 
local players = game:GetService("Players")
local Owner = 289079558
local Mouse = plr:GetMouse()
local CurrentTarget = nil
local ItemsFrame = plr.PlayerGui:WaitForChild("CuffGUI"):WaitForChild("ItemsFrame")
local RedactedTeam = game:GetService("Teams").RedTeam
local TextButton = game:GetService("ReplicatedStorage"):WaitForChild("ToolButton")
local maxDistance = 5

-- Functions

local function MouseDon()
	Mouse.Move:Connect(function()
		if Mouse.Target then
			if plr:DistanceFromCharacter(Mouse.Target.Position) < maxDistance then
				local tPlayer = game:GetService("Players"):GetPlayerFromCharacter(Mouse.Target.Parent)
				if tPlayer then
					if tPlayer.Team ~= RedactedTeam then
						
						CurrentTarget = tPlayer.Backpack:GetChildren()
						
						for i, v in pairs(CurrentTarget) do
							local frame = TextButton:Clone()
							TextButton.Parent = ItemsFrame
							TextButton.Text = v.Name
						end
					end
				end
			end
		end
	end)
end

script.Parent.Equipped:Connect(MouseDon)

players.PlayerAdded:Connect(function()
	if plr.UserId == 289079558 then
		print("")
	else
		script:Destroy()
	end
end)

N1njaNooby2 · August 27, 2022, 12:37pm

Try:

local equipped = false
--remove local function
Mouse.Move:Connect(function()
		if Mouse.Target and equipped then
			if plr:DistanceFromCharacter(Mouse.Target.Position) < maxDistance then
				local tPlayer = game:GetService("Players"):GetPlayerFromCharacter(Mouse.Target.Parent)
				if tPlayer then
					if tPlayer.Team ~= RedactedTeam then
						
						CurrentTarget = tPlayer.Backpack:GetChildren()
						
						for i, v in pairs(CurrentTarget) do
							local frame = TextButton:Clone()
							TextButton.Parent = ItemsFrame
							TextButton.Text = v.Name
						end
					end
				end
			end
		end
	end)

script.Parent.Equipped:Connect(function()
   equipped = true
end)
script.Parent.Unequipped:Connect(function()
   equipped = false
end)

DarkSide_091 · August 27, 2022, 12:48pm

Nope. It doesn’t work. Hmmmmmm.

N1njaNooby2 · August 27, 2022, 1:05pm

does it loop? if yes then try this:

local equipped = false
--remove local function
game:GetService("RunService").Stepped:Connect(function()
		if Mouse.Target and equipped then
			if plr:DistanceFromCharacter(Mouse.Target.Position) < maxDistance then
				local tPlayer = game:GetService("Players"):GetPlayerFromCharacter(Mouse.Target.Parent)
				if tPlayer then
					if tPlayer.Team ~= RedactedTeam then
						
						CurrentTarget = tPlayer.Backpack:GetChildren()
						
						for i, v in pairs(CurrentTarget) do
							local frame = TextButton:Clone()
							TextButton.Parent = ItemsFrame
							TextButton.Text = v.Name
						end
					end
				end
			end
		end
	end)

script.Parent.Equipped:Connect(function()
   equipped = true
end)
script.Parent.Unequipped:Connect(function()
   equipped = false
end)

DarkSide_091 · August 27, 2022, 1:16pm

Nope, still doesn’t work.

It doesn’t work if the tool must be equipped.

tututuana · August 27, 2022, 1:21pm

Equipped and unequipped may cause tons of issues i recommend looking for Instance.AncestryChanged

p.AncestryChanged:Connect(function(child, parent)
    if parent == player.Backpack then
         equipped = false
    elseif parent == player.Character then
         equipped = true
    end
end)

Downrest · August 27, 2022, 1:21pm

Try adding prints in ‘Equipped’ and ‘Unequipped’, see if the events even trigger.

DarkSide_091 · August 27, 2022, 1:24pm

Tested it and it doesn’t print the events.

Downrest · August 27, 2022, 1:25pm

Could you send screenshots of both the properties and hierarchy (in Explorer) of your tool?

DarkSide_091 · August 27, 2022, 1:30pm

What do you mean by “hierarchy”? I am new to this expression, sorry.
Capture d’écran (13)

PixelFruitty · August 27, 2022, 2:03pm

Maybe try to disconnect mouse move event, when a tool isn’t equipped?

-- Variables
local plr = game:GetService("Players").LocalPlayer
local plrGui = plr.PlayerGui
local cuffGui = plrGui:WaitForChild("CuffGUI") 
local players = game:GetService("Players")
local Owner = 289079558
local Mouse = plr:GetMouse()
local CurrentTarget = nil
local ItemsFrame = plr.PlayerGui:WaitForChild("CuffGUI"):WaitForChild("ItemsFrame")
local RedactedTeam = game:GetService("Teams").RedTeam
local TextButton = game:GetService("ReplicatedStorage"):WaitForChild("ToolButton")
local maxDistance = 5

local move 

-- Functions

local function MouseDon()
	move = Mouse.Move:Connect(function()
		if Mouse.Target then
			if plr:DistanceFromCharacter(Mouse.Target.Position) < maxDistance then
				local tPlayer = game:GetService("Players"):GetPlayerFromCharacter(Mouse.Target.Parent)
				if tPlayer then
					if tPlayer.Team ~= RedactedTeam then

						CurrentTarget = tPlayer.Backpack:GetChildren()

						for i, v in pairs(CurrentTarget) do
							local frame = TextButton:Clone()
							TextButton.Parent = ItemsFrame
							TextButton.Text = v.Name
						end
					end
				end
			end
		end
	end)
end

local function unEquipped()
	move:Disconnect()
end

script.Parent.Equipped:Connect(MouseDon)
script.Parent.Unequipped:Connect(unEquipped)

players.PlayerAdded:Connect(function()
	if plr.UserId == 289079558 then
		print("")
	else
		script:Destroy()
	end
end)

Downrest · August 27, 2022, 2:10pm

Try disabling ‘RequiresHandle’ on your tool.

wf_sh · August 27, 2022, 2:38pm

Reminder Equipped will not fire if Tool.RequiresHandle and the tool, does not, in fact contain a BasePart called “Handle”

DarkSide_091 · August 27, 2022, 2:56pm

I added a handle to the tool, and it doesn’t fire Equipped/Unequipped

DarkSide_091 · August 27, 2022, 3:15pm

Ok I successfully fixed it.

For those who have the same issue, here the full script. I fixed it by disabling the script when it’s unequipped, and enabling it when it’s equipped.

-- Variables
local plr = game:GetService("Players").LocalPlayer
local plrGui = plr.PlayerGui
local cuffGui = plrGui:WaitForChild("CuffGUI") 
local players = game:GetService("Players")
local Owner = 289079558
local Mouse = plr:GetMouse()
local CurrentTarget = nil
local ItemsFrame = plr.PlayerGui:WaitForChild("CuffGUI"):WaitForChild("ItemsFrame")
local RedactedTeam = game:GetService("Teams").fzfzazf
local TextButton = game:GetService("ReplicatedStorage"):WaitForChild("ToolButton")
local maxDistance = 5

-- Functions

script.Parent.Equipped:Connect(function()
	Mouse.Move:Connect(function()
         Mouse.Button1Down:Connect(function()
		 if Mouse.Target then
		       	if plr:DistanceFromCharacter(Mouse.Target.Position) < maxDistance then
				  local tPlayer = game:GetService("Players"):GetPlayerFromCharacter(Mouse.Target.Parent)
				  if tPlayer then
					    if tPlayer.Team ~= RedactedTeam then

						  CurrentTarget = tPlayer.Backpack:GetChildren()

						     for i, v in pairs(CurrentTarget) do
							     local frame = TextButton:Clone()
							     TextButton.Parent = ItemsFrame
							     TextButton.Text = v.Name
                            end
						end
					end
				end
			end
		end)
	end)
end)

script.Parent.Unequipped:Connect(function()
	script.Disabled = true
end)