I've made a Global Leaderboard but nothing is showing! SOLUTION FOUND!

georgGe8Stream · October 3, 2023, 3:46pm

I’ve made a Global Leaderboard but if it updates nothing shows on it so i wanted to ask if anybody could help me since there was another topic but the person sound the solution by its self so im asking here again! would be nice if i could get a quick response

here my code:

local DataStoreService = game:GetService("DataStoreService")
local WinsLeaderboard = DataStoreService:GetOrderedDataStore("WinsLeaderboard")

local function updateLeaderboard()
	local success, errorMessage = pcall(function()
		local Data = WinsLeaderboard:GetSortedAsync(false, 5)
		local WinsPage = Data:GetCurrentPage()
		for Rank, data in ipairs(WinsPage) do
			local userName = game.Players:GetNameFromUserIdAsync(tonumber(data.key))
			local Name = userName
			local Wins = data.Value
			local isOnLeaderboard = false
			for i, v in pairs(game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder:GetChildren()) do
				if v.Player.Text == Name then
					isOnLeaderboard = true
					break
				end
			end
			
			if Wins and isOnLeaderboard == false then
				local newLbFrame = game.ReplicatedStorage:WaitForChild("LeaderboardFrameWins"):Clone()
				newLbFrame.Player.Text = Name
				newLbFrame.Wins.Text = Wins
				newLbFrame.Rank.Text = "#"..Rank
				newLbFrame.Position = UDim2.new(0, 0, newLbFrame.Position.Y.Scale + (.08 + #game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder:GetChildren()), 0)
				newLbFrame.Parent = game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder
			end
		end
	end)
	if not success then
		print(errorMessage)
	end
end

while true do 
	

	for _, player in pairs(game.Players:GetPlayers()) do
		WinsLeaderboard:SetAsync(player.userId, player.leaderstats.Wins.Value)
	end
	
	for _, frame in pairs(game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder:GetChildren()) do
		frame:Destroy()	
	end
	
	updateLeaderboard()
	print("Updated!")
	
	wait(10)
end

it would be nice if you could send the fixed code when you may help me

no errors btw ^^^

Pure_Bacn · October 3, 2023, 4:45pm

Are there any errors? Are you testing in studio or roblox client? If you are on studio you have to turn on API services. Also, can you print out Rank and data in your loop? You also have to use pairs instead of ipairs.

Moneypro456789 · October 3, 2023, 5:05pm

I think maybe because you IsOnLeaderboards variable to be false, this happens. Also, can you give a brief of why you added this variable?

georgGe8Stream · October 3, 2023, 5:08pm

so I used the tutorial (made by TheDevKing) since im not good at scripting and he said to add it and i just followed the steps

georgGe8Stream · October 3, 2023, 5:09pm

there arent any errors and everything on studio is activated (only third party teleports is disabled) and imma change ipairs to pairs and try then!

Moneypro456789 · October 3, 2023, 5:10pm

Hmm, but what he said about this variable like the reason to add this?

georgGe8Stream · October 3, 2023, 5:12pm

i dont know let me check into the video he made and see what he says.

Update: he didnt say anything abt this vabriable

Moneypro456789 · October 3, 2023, 5:14pm

Alr, surely take your time. My best guess is to remove that variable because from looking at the way this variable is used, I’m assuming that it’s just for checking if player is in leaderboards or not, but you don’t really need to check it.

Edit -

Hmm, then just remove the condition and this variable. I will send the code in a moment like how am I saying

georgGe8Stream · October 3, 2023, 5:15pm

what do you mean by printing out rank and data?

Moneypro456789 · October 3, 2023, 5:16pm

local DataStoreService = game:GetService("DataStoreService")
local WinsLeaderboard = DataStoreService:GetOrderedDataStore("WinsLeaderboard")

local function updateLeaderboard()
	local success, errorMessage = pcall(function()
		local Data = WinsLeaderboard:GetSortedAsync(false, 5)
		local WinsPage = Data:GetCurrentPage()
		for Rank, data in ipairs(WinsPage) do
print(Rank, data) --he means to add this line
			local userName = game.Players:GetNameFromUserIdAsync(tonumber(data.key))
			local Name = userName
			local Wins = data.Value
			local isOnLeaderboard = false
			for i, v in pairs(game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder:GetChildren()) do
				if v.Player.Text == Name then
					isOnLeaderboard = true
					break
				end
			end
			
			if Wins and isOnLeaderboard == false then
				local newLbFrame = game.ReplicatedStorage:WaitForChild("LeaderboardFrameWins"):Clone()
				newLbFrame.Player.Text = Name
				newLbFrame.Wins.Text = Wins
				newLbFrame.Rank.Text = "#"..Rank
				newLbFrame.Position = UDim2.new(0, 0, newLbFrame.Position.Y.Scale + (.08 + #game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder:GetChildren()), 0)
				newLbFrame.Parent = game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder
			end
		end
	end)
	if not success then
		print(errorMessage)
	end
end

while true do 
	

	for _, player in pairs(game.Players:GetPlayers()) do
		WinsLeaderboard:SetAsync(player.userId, player.leaderstats.Wins.Value)
	end
	
	for _, frame in pairs(game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder:GetChildren()) do
		frame:Destroy()	
	end
	
	updateLeaderboard()
	print("Updated!")
	
	wait(10)
end

georgGe8Stream · October 3, 2023, 5:17pm

let me test if this works now if so it would really help

Moneypro456789 · October 3, 2023, 5:18pm

local DataStoreService = game:GetService("DataStoreService")
local WinsLeaderboard = DataStoreService:GetOrderedDataStore("WinsLeaderboard")

local function updateLeaderboard()
	local success, errorMessage = pcall(function()
		local Data = WinsLeaderboard:GetSortedAsync(false, 5)
		local WinsPage = Data:GetCurrentPage()
		for Rank, data in ipairs(WinsPage) do
			local userName = game.Players:GetNameFromUserIdAsync(tonumber(data.key))
			local Name = userName
			local Wins = data.Value
				local newLbFrame = game.ReplicatedStorage:WaitForChild("LeaderboardFrameWins"):Clone()
				newLbFrame.Player.Text = Name
				newLbFrame.Wins.Text = Wins
				newLbFrame.Rank.Text = "#"..Rank
				newLbFrame.Position = UDim2.new(0, 0, newLbFrame.Position.Y.Scale + (.08 + #game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder:GetChildren()), 0)
				newLbFrame.Parent = game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder
	end
end)
	if not success then
		print(errorMessage)
	end
end

while true do 
	

	for _, player in pairs(game.Players:GetPlayers()) do
		WinsLeaderboard:SetAsync(player.userId, player.leaderstats.Wins.Value)
	end
	
	for _, frame in pairs(game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder:GetChildren()) do
		frame:Destroy()	
	end
	
	updateLeaderboard()
	print("Updated!")
	
	wait(10)
end

georgGe8Stream · October 3, 2023, 5:19pm

it gives me this right here:

georgGe8Stream · October 3, 2023, 5:21pm

this script doesnt work aither sadly thats the output it gives me:

georgGe8Stream · October 3, 2023, 5:33pm

@Moneypro456789 Are you still there? May you look at what it prints and its still not working!

georgGe8Stream · October 3, 2023, 6:42pm

I’ve now fixed it by my self thank you for helping tho

Moneypro456789 · October 3, 2023, 6:45pm


```local DataStoreService = game:GetService("DataStoreService")
local WinsLeaderboard = DataStoreService:GetOrderedDataStore("WinsLeaderboard")

local function updateLeaderboard()
	local success, errorMessage = pcall(function()
		local Data = WinsLeaderboard:GetSortedAsync(false, 5)
		local WinsPage = Data:GetCurrentPage()
		for Rank, data in ipairs(WinsPage) do
			local userName = game.Players:GetNameFromUserIdAsync(tonumber(data.key))
			local Name = userName
			local Wins = data.Value
				local newLbFrame = game.ReplicatedStorage:WaitForChild("LeaderboardFrameWins"):Clone()
				newLbFrame.Player.Text = Name
				newLbFrame.Wins.Text = tostring(Wins)
				newLbFrame.Rank.Text = "#"..tostring(Rank)
				newLbFrame.Position = UDim2.new(0, 0, newLbFrame.Position.Y.Scale + (.08 + #game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder:GetChildren()), 0)
				newLbFrame.Parent = game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder
	end
end)
	if not success then
		print(errorMessage)
	end
end

while true do 
	

	for _, player in pairs(game.Players:GetPlayers()) do
		WinsLeaderboard:SetAsync(player.userId, player.leaderstats.Wins.Value)
	end
	
	for _, frame in pairs(game.Workspace.Lobby.Leaderboards.Leaderboard_Wins.WinLeaderboard.SurfaceGui.Holder:GetChildren()) do
		frame:Destroy()	
	end
	
	updateLeaderboard()
	print("Updated!")
	
	wait(10)
end

georgGe8Stream · October 3, 2023, 7:32pm

@Moneypro456789 thank you but ive not got it fixed but i need help at another globale leaderboard because there is nothing showing up AGAIN. this time the lobal leaderboard is a global death leaderboard

here is the code:

local DataStoreService = game:GetService("DataStoreService")
local DeathsLeaderboard = DataStoreService:GetOrderedDataStore("DeathsLeaderboard")

local function updateLeaderboard()
	local success, errorMessage = pcall(function()
		local Data = DeathsLeaderboard:GetSortedAsync(false, 5)
		local DeathsPage = Data:GetCurrentPage()
		for Rank, data in ipairs(DeathsPage) do
			local userName = game.Players:GetNameFromUserIdAsync(tonumber(data.key))
			local Name = userName
			local Deaths = data.value
			local isOnLB = false
			for i, v in pairs(game.Workspace.Lobby.Leaderboards.Leaderboard_Deaths.DeathLeaderboard.SurfaceGui.Holder:GetChildren()) do
				if v.Player.Text == Name then
					isOnLB = true
					break
				end
			end
			
			if Deaths and isOnLB == false then
				local newLBFrame = game.ReplicatedStorage:WaitForChild("LeaderboardFrameDeaths"):Clone()
				newLBFrame.Player.Text = Name
				newLBFrame.Deaths.Text = Deaths
				newLBFrame.Rank.Text = "#"..Name
				newLBFrame.Position = UDim2.new(0, 0, newLBFrame.Position.Y.Scale + (.1 * game.Workspace.Lobby.Leaderboards.Leaderboard_Deaths.DeathLeaderboard.SurfaceGui.Holder:GetChildren()), 0)
				newLBFrame.Parent = game.Workspace.Lobby.Leaderboards.Leaderboard_Deaths.DeathLeaderboard.SurfaceGui.Holder
			end
		end
	end)
	
	if not success then
		print(errorMessage)
	end
end

while true do
	
	for _, player in pairs(game.Players:GetPlayers()) do
		DeathsLeaderboard:SetAsync(player.UserId, player.leaderstats.Deaths.Value)
	end
	
	for _, frame in pairs(game.Workspace.Lobby.Leaderboards.Leaderboard_Deaths.DeathLeaderboard.SurfaceGui.Holder:GetChildren()) do
		frame:Destroy()
	end
	
	updateLeaderboard()
	print("Updated!")
	
	wait(10)
end

if i made any mistakes tell me or fix them if possible

Moneypro456789 · October 4, 2023, 2:48pm

Hmm, just copy the fixed code you had for WinsLeaderboard, and just change the Datastore name to DeathsLeaderboard

georgGe8Stream · October 4, 2023, 2:54pm

i’ve already found a solution but thank you