Jail script help!

Help and Feedback Scripting Support
#1

Jail script, teleports target player upon pressing button and then checks the magnitude of the player to see if he glitched or exploited out. Does not work, does not error.

Script:

jail.OnServerEvent:Connect(function(player, playerToJail)
	if not table.find(ADMIN, player.UserId) then return end
	if not game.Players:FindFirstChild(playerToJail) then print("Player not in-game!") return end
	playeruserID = getUserIdFromUsername(playerToJail)
	if playeruserID == 1 then
		return
	else
		local success, errormessage = pcall(function()
			JailData:SetAsync(playeruserID)
		end)
		if success then
			game.Workspace:FindFirstChild(playerToJail).HumanoidRootPart.CFrame = game.Workspace:FindFirstChild("Torment").CFrame
				local mag = (game.Workspace:FindFirstChild("Torment").CFrame - game.Workspace:FindFirstChild(playerToJail).HumanoidRootPart.CFrame).Magnitude
				while true do
					wait(60)
				if mag > 15 then
					game.Workspace:FindFirstChild(playerToJail).HumanoidRootPart.CFrame = game.Workspace:FindFirstChild("Torment").CFrame
					end
				end
			end
		end
end)

Jail data errors saying that i tried to call a nil value of “HumanoidRootPart”, i tried putting WaitForChild and FindFirstChild but it said the same thing "tried to call nil value of “WaitForChild” or “FindFirstChild”.

Jail Data:



local DataStore = game:GetService("DataStoreService")
local jailData = DataStore:GetDataStore("Jailed")
local man = {}


game.Players.PlayerAdded:Connect(function(player)
	wait(10)
	local char = player.Character
	local HumanoidRootPart = char.HumanoidRootPart

	local playerID = player.UserId

	local jailed
	local success, errormessage = pcall(function()
		jailed = jailData:GetAsync(playerID)
	end)

	if jailed then
		game.Workspace:FindFirstChild(player):WaitForChild("HumanoidRootPart").CFrame = game.Workspace:FindFirstChild("Torment").CFrame
			local mag = (game.Workspace:FindFirstChild("Torment").CFrame - game.Workspace:FindFirstChild(player).HumanoidRootPart.CFrame).Magnitude
			while true do
				wait(60)
				if mag > 15 then
					game.Workspace:FindFirstChild(player).HumanoidRootPart.CFrame = game.Workspace:FindFirstChild("Torment").CFrame
			end
		end
	end
end)

EDIT: FIXED!

#2

Why are you doing this when u referenced the HumanoidRootPart variable before?

(Oh yeah it might not be ‘updated’ correctly)

I have maybe found your issue.

Try to put the player variable to tostring() or player.Name because it is instance and not string.

1 Like
#3

You should implement another sanity check if success returned back as true, otherwise it’ll bring that error & make sure to print what jailed really gives you

Also you should encase this with/inside a CharacterAdded event as well so it’ll detect whenever every time the Character respawns:

game.Players.PlayerAdded:Connect(function(player)
	wait(10)
	local char = player.Character or player.CharacterAdded:Wait()
	local HumanoidRootPart = char.HumanoidRootPart

	local playerID = player.UserId

	local jailed
	local success, errormessage = pcall(function()
		jailed = jailData:GetAsync(playerID)
	end)
    print(jailed)

	if jailed and success then
		game.Workspace:FindFirstChild(player):WaitForChild("HumanoidRootPart").CFrame = game.Workspace:FindFirstChild("Torment").CFrame
			local mag = (game.Workspace:FindFirstChild("Torment").CFrame - game.Workspace:FindFirstChild(player).HumanoidRootPart.CFrame).Magnitude
			while true do
				wait(60)
				if mag > 15 then
					game.Workspace:FindFirstChild(player).HumanoidRootPart.CFrame = game.Workspace:FindFirstChild("Torment").CFrame
			end
		end
    else
        warn(errormessage)
	end
end)
1 Like
#4

Do you know what the problem is on the first script, though? Thanks for the reply!

#5

Judging by the error, playerToJail could be referenced as a nil value if you haven’t defined it property which is why you’re getting the HumanoidRootPart nil values even if you call WaitForChild/FindFirstChild on it

I’d recommend adding print statements to see what it’s really defined at

#6

No. playerToJail is not nil, and the error isn’t coming from that script but the jail data one.

#7

Did u try what I told you?
@Hocevar

1 Like
#8

You still should check to make sure whenever a Player Joins, debugging is always important after all

#9

I tried, though it did not appear to work. :sad:

#10

Can you tell me which line is erroring.

#11

I added a waitforchild and it worked!

1 Like
#12

So it was the problem the “player” without tostring() or player.Name?

1 Like
#13

Though it does not appear to be teleporting me back after crossing the magnitude

#14

Can you show me the edited script again?

#15 
game.Players.PlayerAdded:Connect(function(player)

	local playerID = player.UserId

	local jailed
	local success, errormessage = pcall(function()
		jailed = jailData:GetAsync(playerID)
	end)

	if jailed and success then
		table.insert(jail, player)
		if table.find(jail, player) then
			game.Workspace:FindFirstChild(player.Name):WaitForChild("HumanoidRootPart").Position = game.Workspace:FindFirstChild("Torment").Position
			local mag = (game.Workspace:FindFirstChild("Torment").Position - game.Workspace:FindFirstChild(player.Name).HumanoidRootPart.Position).Magnitude
			while true do
				wait(60)
				if mag > 15 then
					game.Workspace:FindFirstChild(player.Name).HumanoidRootPart.Position = game.Workspace:FindFirstChild("Torment").Position
				end
			end
		end
	end
end)
#16

Try to add print after the if mag > 15 then

#17

Nothing appears to be printing.

#18

Because you will need to wait 60 seconds before the magnitude check run.

#19

Already waited that long and it doesn’t appear to be doing anything.

#20

Try to

print(mag)

before it.