Jump Damage Script doesn't damage enemies all of the time

[garnet_dev (Garnet)]

So, I’m trying to create a 3D platformer and I want to allow players to jump on enemies in order to do damage . The problem is that while it does work, there are times where the player lands on the enemy and no damage is done. It seems that the script only works if the enemy is moving. Here are all scripts involved:
Summary: A local script detects when a player lands which is sent to the server to spawn a part under the player. The part has a kill brick script in it that damages anything below it.
Local script used for detecting when a player lands

local humanoid = script.Parent:FindFirstChildOfClass("Humanoid")

humanoid.StateChanged:Connect(function(oldstate, newstate)
	if newstate == Enum.HumanoidStateType.Landed then
		print("Player has landed")
		game.ReplicatedStorage.RemoteEvent:FireServer()
	end
end)

Server Script for spawning a part under the player

game.ReplicatedStorage.RemoteEvent.OnServerEvent:Connect(function(plr)

	local function createBrick(cframe)
		local ScriptToCopy = script:WaitForChild("ScriptToCopy"):Clone()

		local brick = Instance.new("Part")
		brick.Size = Vector3.new(5, 5, 5)
		brick.Name = "DMGPart_" .. math.random(1, 10000)  
		brick.Transparency = 1
		brick.CFrame = cframe
		brick.Anchored = true
		brick.CanCollide = false
		brick.Parent = workspace
		brick.CanTouch = true
		ScriptToCopy.Parent = brick
		ScriptToCopy.Disabled = false
		print("Script Enabled")

		print("Created")
		return brick
	end

	local player = plr
	local character = player.Character or player.CharacterAdded:Wait()
	local rootPart = character:WaitForChild("HumanoidRootPart")

	if rootPart then
		local createdBrick = createBrick(rootPart.CFrame * CFrame.new(0, -5, 0))
		print("Activated")
		wait(0.1)
		if createdBrick and createdBrick.Parent then
			print("Part Destroyed")
			createdBrick:Destroy()
		end
	end
end)

Script for damage

local debounce = false

local enemy = game.Workspace.Enemies

script.Parent.Touched:Connect(function(hit)
	local humanoid = hit.Parent:FindFirstAncestor("Enemies") and hit.Parent:FindFirstChildOfClass("Humanoid")
	local HRP = hit.Parent:FindFirstChild("HumanoidRootPart")
	

	if humanoid and not debounce then
		print("HRP Found")
		debounce = true
		humanoid:TakeDamage(50)
		wait()
		debounce = false
	end
end)

So far I have tried to allow for the npc to move a few studs in order to be detectable by the part, changing what part must be pressed and even the size of the part. Any help would be appreciated.

[BamzOfficial (Bamz)]

So aside from a few questions, this fix should be pretty easy. Personally I would also use a different query method seeing as .Touched is unreliable to an extent. I’m not too sure if your enemies declar is a folder or what, but I assumed so.

I would try using Overlap params and a partsinboundbox query instead: you can edit the size of the box in the script provided, but I’m pretty sure it might work (i haven’t tested). Just make sure you have all of the variables listed in each script correctly named.

I’m using add to filter which is basically a debounce, so the hitbox will be able to hit more enemies but only each enemy once. I also chose to fire the position of the root from the client seeing as it will be more reliable than on the server., (yes this can be an issue if they feed in a false value, but i was just making this in 2 mins)

PS: Also make sure the local script is in StarterPlayerScripts, instead of StarterCharacterScripts
PPS: Let me know if you still have an issue with the enemies not registering the hits while standing still, I would also like to know how your enemies are structured and if you could send a screenshot, that would be helpful.

Local Script:

---// Service(s) //
local Players = game:GetService("Players")
local ReplicatedStorage = game:GetService("ReplicatedStorage")
local RunService = game:GetService("RunService")
local UserInputService = game:GetService("UserInputService")

---// Player Variable(s) //
local player = Players.LocalPlayer
local character = player.Character or player.CharacterAdded:Wait()
local humanoid = character:WaitForChild("Humanoid")
local root = character:WaitForChild("HumanoidRootPart")

---// Variable(s) //
local remote = ReplicatedStorage:WaitForChild('RemoteEvent')

humanoid.StateChanged:Connect(function(oldState, newState)
	if newState == Enum.HumanoidStateType.Landed then
		print("Player has landed")
		if root then
			remote:FireServer(root.Position)
		end
	end
end)

---

Server Script:

---// Service(s) //
local CollectionService = game:GetService('CollectionService')
local ReplicatedStorage = game:GetService('ReplicatedStorage')
local Debris = game:GetService('Debris')

---// Variable(s) //
local RemoteEvent = ReplicatedStorage:WaitForChild('RemoteEvent')
local EnemiesFolder = workspace:WaitForChild('Enemies')

---// Setting(s) //
local HurtboxSize = Vector3.new(2.25, 2, 1.5)
local Damage = 25
local Duration = 0.25

---// Function(s) //
local function createHurtbox(characterMakingBox : Model, position)
	local hurtbox = Instance.new("Part")
	hurtbox.Size = HurtboxSize
	hurtbox.Position = position - Vector3.new(0, 5, 0)
	hurtbox.Anchored = true
	hurtbox.Transparency = 0.5
	hurtbox.CastShadow = false
	hurtbox.CanCollide = false
	hurtbox.Parent = workspace
	Debris:AddItem(hurtbox, Duration)
	
	local params = OverlapParams.new()
	params.FilterDescendantsInstances = {characterMakingBox}
	params.FilterType = Enum.RaycastFilterType.Exclude
	
	task.spawn(function()
		while hurtbox and hurtbox.Parent == workspace do
			local parts = workspace:GetPartBoundsInBox(hurtbox.CFrame, hurtbox.Size, params)
			local hitCharacters = {}

			for _, part in pairs(parts) do
				local character = part.Parent
				if character.Parent ~= EnemiesFolder then return end
				local humanoid = character:FindFirstChildOfClass('Humanoid')
				if humanoid and humanoid.Health > 0 then
					if character and not table.find(hitCharacters, character) then
						table.insert(hitCharacters, character)
						print(hitCharacters, "Hitcharacters..")
						humanoid:TakeDamage(Damage)
					end
				end
			end

			params:AddToFilter(hitCharacters)
			task.wait()
		end
	end)
end

RemoteEvent.OnServerEvent:Connect(function(player, position)
	local Character = player and player.Character
	if not Character then return end
	local HumanoidRootPart = Character:FindFirstChild("HumanoidRootPart")
	if not HumanoidRootPart then return end
	local Humanoid = Character:FindFirstChildOfClass('Humanoid')
	if Humanoid and Humanoid.Health > 0 then
		createHurtbox(Character, position)
	end
end)

[garnet_dev (Garnet)]

The script seems to work better than mine, however there are some times in which the npc doesn’t get damaged. Here’s the screenshots of the npc and scripts as requested:

Module Script for Ragdoll

local ragdoll = {}

function ragdoll.SetRagdoll(char)
	task.spawn(function()
		for _, attach in pairs(char:GetDescendants()) do
			if attach:IsA("Motor6D") then
				local att0, att1 = Instance.new("Attachment"), Instance.new("Attachment")
				att0.CFrame = attach.C0
				att1.CFrame = attach.C1
				if attach.Name == "Right Hip" then
					att1.Position = Vector3.new(0, 1, 0)
					att0.Position = Vector3.new(0.5, -1, 0)
				end
				if attach.Name == "Left Hip" then
					att1.Position = Vector3.new(0, 1, 0)
					att0.Position = Vector3.new(-0.5, -1, 0)
				end
				att0.Parent = attach.Part0
				att1.Parent = attach.Part1

				local BSC = Instance.new("BallSocketConstraint")
				BSC.Attachment0 = att0
				BSC.Attachment1 = att1
				BSC.Parent = attach.Part0

				if attach.Name == "Right Hip" then
					BSC.LimitsEnabled = true
					BSC.TwistLimitsEnabled = true
					BSC.UpperAngle = 85
					BSC.TwistLowerAngle = -15
					BSC.TwistUpperAngle = 15
				end
				if attach.Name == "Left Hip" then
					BSC.LimitsEnabled = true
					BSC.TwistLimitsEnabled = true
					BSC.UpperAngle = 85
					BSC.TwistLowerAngle = -15
					BSC.TwistUpperAngle = 15
				end
				if attach.Name == "Neck" then
					BSC.LimitsEnabled = true
					BSC.TwistLimitsEnabled = true
					BSC.UpperAngle = 75
					BSC.TwistLowerAngle = -60
					BSC.TwistUpperAngle = 60
				end
				attach:Destroy()
			end
		end
		for _, part in pairs(char:GetChildren()) do
			if part and part:IsA("Part") and part.Parent:FindFirstChildOfClass("Humanoid") then
				for i, bodyPart in pairs(game.ReplicatedStorage.RagdollModule.RagdollAssets:GetChildren()) do
					if bodyPart.Name == part.Name then
						local clonedBodyPart = bodyPart:Clone()
						local weld = Instance.new("Weld", clonedBodyPart)
						clonedBodyPart.Parent = part
						weld.Part0 = clonedBodyPart
						weld.Part1 = part
						clonedBodyPart.Transparency = 1
						clonedBodyPart.CanTouch = true
						local soundDebounce = true
						local touchTrigger = clonedBodyPart.Touched:Connect(function(hit)
							if hit and not hit.Parent:FindFirstChild("Humanoid") and not hit.Parent.Parent:FindFirstChild("Humanoid") then
								local clonedPartVelocity = math.round(((clonedBodyPart.Velocity).Magnitude))
								if clonedPartVelocity > 2 and soundDebounce == true then
									soundDebounce = false
									local randomSound = game.ReplicatedStorage.RagdollModule.colisionSounds:GetChildren()[math.random(1, #game.ReplicatedStorage.RagdollModule.colisionSounds:GetChildren())]:Clone()
									randomSound.Parent = clonedBodyPart
									randomSound.RollOffMaxDistance = 70
									randomSound.RollOffMinDistance = 5
									randomSound.RollOffMode = Enum.RollOffMode.LinearSquare
									randomSound.Volume = 0.1
									randomSound:Play()
									task.delay(randomSound.TimeLength, function()
										randomSound:Destroy()
										soundDebounce = true
									end)
								end
							end
						end)
					end
				end
				part.CanCollide = false
				part.CanTouch = false
			end
		end
	end)
end

return ragdoll

[BamzOfficial (Bamz)]

Did you try editing the size of the hitbox back to what you had it to? I made it smaller for testing sakes. But after doing some research, after the state is triggered on the humanoid and sends the position data, the query will obviously intake that original position data, but any amount of query method might be inconsistent due to how some/most query methods on the server are heavily server timed and can be physics based (like .Touched).

I do apologize for not originally testing the script I made, but I was just trying to get a quick answer out. If you’d like I can now go through a test and revise what I’ve sent. And if you’d like me to try and help with another solution that works 100% of the time then I can do that. ( I would most likely use modules but I wasn’t sure on your current scripting experience)

[BamzOfficial (Bamz)]

I just tested my code and decided that :GetPartBoundsInBox() was not correct, and changed it to :GetPartsInPart() which showed significant improvement with damage consistency.

PS: I changed the hitbox to your sizing of Vector3.new(5,5,5) btw

Here’s a place file if you’d like to see what I did exactly:
JumpingDamageExample.rbxl (76.9 KB)

[Den_vers]

I didn’t read the code, but from first-hand experience I know that Humanoid States can be gimmicky. Sometimes they aren’t what you expect, and I believe it’s because of the nature of them, so the jump state doesn’t always register on them, I know it’s frustrating.

[BamzOfficial (Bamz)]

The Humanoid State was firing perfectly fine, it was just the damage being done through .Touched that was the issue.

[Den_vers]

Why does OP need another script to do the damage, why not track it in the same script that you listen for the event in? More script is less performant. All the code you run in the last script I’d just run in the second script.

if humanoid and not debounce then
		print("HRP Found")
		debounce = true
		humanoid:TakeDamage(50)
		wait()
		debounce = false
	end

Here bugs me too, this is practically useless because you’re only disabling it for a single frame, I’m not even sure if *`.Touched events can fire multiple times in a frame, it’s not a useful debounce, are you trying to instant kill the player?

Another question, in the original script you have many print statements, which ones are firing and which ones are not?

[BamzOfficial (Bamz)]

I already posted a suggested fix that reduced his multiple script setup down to one server script and a function instead. He just needed a different outlook on it, no need to bash him for using multiple scripts. We all start somewhere and he posted in here for good reason, because he wanted someone else’s help with the issue that he was experiencing.

[Den_vers]

It’s constructive criticism, I’m not bashing. I’m really interested in what the console is printing. Could you send that info, OP?

[sizzlegames3]

I agree with @BamzOfficial he already sent a clear fix. it seems like he is new to the platform and you came here without giving anyone help. he was printing in the console to debug

[awakenedUnmiser (Unmiser)]

This looks like a valid fix, good work @BamzOfficial

[garnet_dev (Garnet)]

Thanks for the help! This works really well for my purposes

[BamzOfficial (Bamz)]

No problem! I’m glad to have helped you fix your issue with this system. Enjoy your stay on the DevForum.