Knockback system not working

Help and Feedback Scripting Support
#1

Hi so I’m trying to make a basic knockback system,
a player hits another player or NPC and the NPC gets knocked back.
This code below doesn’t give any error outputs but it’s not knocking any NPCs back.
I checked and they’re not anchored.

It’s detecting the player and the NPC as well so I’m not sure what is going on here.
Any help would be appreciated.

game.ReplicatedStorage.knockback.knockback.OnServerEvent:Connect(function(player)
	for _, target in pairs(game.Workspace:GetDescendants()) do
		if target:IsA("Humanoid") and target.Parent.Name ~= player.Name then
			if (target.Parent.HumanoidRootPart.Position - player.Character.HumanoidRootPart.Position).magnitude < 5 then
				
				
				local targetRootPart = target.Parent.PrimaryPart
				local playerRootPart = player.Character.PrimaryPart
		
				
				local velocity = Instance.new("BodyVelocity", targetRootPart)
				
				velocity.MaxForce = Vector3.new(100000,100000,10000)
				velocity.P = 10000
				
				local angle = ((targetRootPart.Position - playerRootPart.Position) * Vector3.new(10,0,10)).Unit * 50 + Vector3.new(0,25,0)
				
				velocity.Velocity = angle
				wait(0.1)
				velocity:Destroy()
				
				print(target.Parent.Name, "was touched")
				
			end
		end
	end
end)
#2

The parent parameter of Instance.new() is deprecated. You’ll have to assign it in a different line.

#3

how would that look like, am I supposed to add it in another variable or?

#4 
game.ReplicatedStorage.knockback.knockback.OnServerEvent:Connect(function(player)
	for _, target in pairs(game.Workspace:GetDescendants()) do
		if target:IsA("Humanoid") and target.Parent.Name ~= player.Name then
			if (target.Parent.HumanoidRootPart.Position - player.Character.HumanoidRootPart.Position).magnitude < 5 then
				
				
				local targetRootPart = target.Parent.PrimaryPart
				local playerRootPart = player.Character.PrimaryPart
		
				
				local velocity = Instance.new("BodyVelocity")
				velocity.Parent = targetRootPart;
				velocity.MaxForce = Vector3.new(100000,100000,10000)
				velocity.P = 10000
				
				local angle = ((targetRootPart.Position - playerRootPart.Position) * Vector3.new(10,0,10)).Unit * 50 + Vector3.new(0,25,0)
				
				velocity.Velocity = angle
				wait(0.1)
				velocity:Destroy()
				
				print(target.Parent.Name, "was touched")
				
			end
		end
	end
end)
#5

Oh okay, thanks I changed it. It’s still not giving any knockback I don’t know why though.

1 Like
#6

Does the print statement print to the output?

#7

Yeah all the print statements print to the output.
image

#8

Add one more zero to the maxforce

#9

It’s still not doing anything sadly

#10

Maybe you could try parenting the BodyVelocity after you setup all the other properties? Especially the velocity. I usually do that for all instances, including my knockback system.

#11

sorry for the long reply, I tried doing that but it still doesn’t manage to do anything. Kind of odd, I’m not really sure what’s 100% the issue since there’s literally no error output, everything runs it just seems that it doesn’t make the humanoid get knocked back.

#12

Well that’s weird. I’ve rewritten the code a little, tested it in Studio and it works fine for me:

local targetRootPart = target.Parent.PrimaryPart
local playerRootPart = player.Character.PrimaryPart
				
local velocity = Instance.new("BodyVelocity");
velocity.MaxForce = Vector3.new(100000,100000,10000);
			
local angle = ((targetRootPart.Position - playerRootPart.Position) * Vector3.new(10,0,10)).Unit * 50 + Vector3.new(0,25,0);		
velocity.Velocity = angle;
velocity.Parent = targetRootPart;

game.Debris:AddItem(velocity, 0.1);
#13

could you show me a screen recording maybe, that might help me see what it’s actually supposed to do

#14

Sure, here:
https://gyazo.com/49ad0c962639adb0a1475665cd6693f7

#15

okay so I tested it out and it actually works when I published the game and played it with a friend. Maybe it seems that it doesn’t work in the studio for me (maybe because of something I did but I’m not sure) so I’ll keep this for now. Thank you so much.

1 Like